NetBSD Problem Report #42155

From cheusov@tut.by  Tue Oct  6 09:50:05 2009
Return-Path: <cheusov@tut.by>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id BF6F163B8B6
	for <gnats-bugs@gnats.netbsd.org>; Tue,  6 Oct 2009 09:50:04 +0000 (UTC)
Message-Id: <s9363asonr4.fsf@chel.imb.invention.com>
Date: Tue, 06 Oct 2009 12:49:51 +0300
From: cheusov@tut.by
To: gnats-bugs@gnats.netbsd.org
Subject: lang/perl5 vs. DB_File module required for www/ikiwiki
X-Send-Pr-Version: 3.113.1
X-GNATS-Notify:

>Number:         42155
>Category:       pkg
>Synopsis:       lang/perl5 vs. DB_File module required for www/ikiwiki
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkgsrc-p5-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 06 09:55:00 +0000 2009
>Last-Modified:  Wed Apr 13 21:28:09 +0000 2011
>Originator:     Aleksey Cheusov
>Release:        Linux 2.6.26.1
>Organization:
<organization of PR author (multiple lines)>
>Environment:
System: Linux chel 2.6.26.1 #1 SMP Mon Oct 6 18:40:10 EEST 2008 i686 GNU/Linux
Architecture: i686

>Description:
www/ikiwiki package doesn't work under Linux and says 

   Error: new(): failed: couldn't load CGI::Session::Driver::db_file: 
   Can't locate DB_File.pm in @INC 

This happens because under Linux lang/perl5 is built without DB_File.pm.
At the same time DB_File.pm is built normally under NetBSD.

The following patch fixes the problem.

>How-To-Repeat:
Build www/ikiwiki under Linux and try to use it.

>Fix:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/lang/perl5/Makefile,v
retrieving revision 1.153
diff -u -r1.153 Makefile
--- Makefile	11 Jun 2009 10:35:07 -0000	1.153
+++ Makefile	6 Oct 2009 09:48:53 -0000
@@ -4,7 +4,7 @@

 DISTNAME=	perl-5.10.0
 CATEGORIES=	lang devel perl5
-PKGREVISION=	6
+PKGREVISION=	7
 MASTER_SITES=	${MASTER_SITE_PERL_CPAN:S,/modules/by-module/$,/src/,}
 DISTFILES+=	${DISTNAME}${EXTRACT_SUFX}

@@ -74,6 +74,7 @@
 CONFIGURE_ARGS+=	-Doptimize=${CFLAGS:M*:Q}
 CONFIGURE_ARGS+=	-Ui_malloc
 CONFIGURE_ARGS+=	-Uinstallusrbinperl
+CONFIGURE_ARGS+=	-Dldflags=${LDFLAGS:Q}\ ${BDB_LIBS:Q}
 MAKE_ENV+=		LC_ALL="C"
 MAKE_JOBS_SAFE=		no

@@ -446,4 +447,10 @@
 	} | ${SED} -e "s,^"${PREFIX:Q}"/,," > ${PLIST_SRC}

 .include "packlist.mk"
+
+.include "../../mk/bdb.buildlink3.mk"
+.if !empty(BUILDLINK_INCDIRS.${BDB_TYPE})
+LOCINCPATH+=	${LOCALBASE}/${BUILDLINK_INCDIRS.${BDB_TYPE}}
+.endif
+
 .include "../../mk/bsd.pkg.mk"

>Release-Note:

>Audit-Trail:
From: Jens Rehsack <rehsack@googlemail.com>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, 
 pkgsrc-bugs@netbsd.org
Subject: Re: pkg/42155: lang/perl5 vs. DB_File module required for www/ikiwiki
Date: Tue, 06 Oct 2009 10:46:15 +0000

 cheusov@tut.by wrote:
 >> Number:         42155
 >> Category:       pkg
 >> Synopsis:       lang/perl5 vs. DB_File module required for www/ikiwiki
 >> Confidential:   no
 >> Severity:       serious
 >> Priority:       medium
 >> Responsible:    pkg-manager
 >> State:          open
 >> Class:          sw-bug
 >> Submitter-Id:   net
 >> Arrival-Date:   Tue Oct 06 09:55:00 +0000 2009
 >> Originator:     Aleksey Cheusov
 >> Release:        Linux 2.6.26.1
 >> Organization:
 > <organization of PR author (multiple lines)>
 >> Environment:
 > System: Linux chel 2.6.26.1 #1 SMP Mon Oct 6 18:40:10 EEST 2008 i686 GNU/Linux
 > Architecture: i686

 This is a good point and would allow us to remove databases/p5-gdbm, too.
 Would it be ok to commit this during freeze or better after it?


 Jens

From: Tobias Nygren <tnn@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/42155: lang/perl5 vs. DB_File module required for
 www/ikiwiki
Date: Tue, 6 Oct 2009 14:25:30 +0200

 On Tue,  6 Oct 2009 10:50:03 +0000 (UTC)
 Jens Rehsack <rehsack@googlemail.com> wrote:

 >  This is a good point and would allow us to remove databases/p5-gdbm, too.
 >  Would it be ok to commit this during freeze or better after it?

 perl5 is imho too important to risk breaking for a Linux fix that may
 cause unforseen problems on other platforms. Please hold this until
 after the branch, but feel free to request a pullup later, after it's
 gotten some testing.

 +LOCINCPATH+=	${LOCALBASE}/${BUILDLINK_INCDIRS.${BDB_TYPE}}

 Shouldn't that be ${PREFIX}?
 (I know there are other LOCALBASE references in the Makefile.)

From: Aleksey Cheusov <cheusov@tut.by>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/42155: lang/perl5 vs. DB_File module required for www/ikiwiki
Date: Sun, 18 Oct 2009 18:06:40 +0300

  >>  This is a good point and would allow us to remove databases/p5-gdbm, too.
  >>  Would it be ok to commit this during freeze or better after it?

 >  perl5 is imho too important to risk breaking for a Linux fix that may
 >  cause unforseen problems on other platforms. Please hold this until
 >  after the branch, but feel free to request a pullup later, after it's
 >  gotten some testing.

 If I understand correctly there were no objections against commiting.
 Freeze is in the past. I've checked patch perl under NetBSD-5/pkgsrc-2009Q3.
 It is built fine and PLIST doesn't change.
 perl -V also doesn't show significant difference.

 >  +LOCINCPATH+=	${LOCALBASE}/${BUILDLINK_INCDIRS.${BDB_TYPE}}
 >  
 >  Shouldn't that be ${PREFIX}?

 Probably yes, I followed minimal patch size principle and
 used LOCALBASE just because there were other places with it.

 >  (I know there are other LOCALBASE references in the Makefile.)

 -- 
 Best regards, Aleksey Cheusov.

From: Aleksey Cheusov <cheusov@tut.by>
To: gnats-bugs@NetBSD.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/42155: lang/perl5 vs. DB_File module required for www/ikiwiki
Date: Sat, 24 Oct 2009 12:16:51 +0300

  >>  perl5 is imho too important to risk breaking for a Linux fix that may
  >>  cause unforseen problems on other platforms. Please hold this until
  >>  after the branch, but feel free to request a pullup later, after it's
  >>  gotten some testing.
 >  
 >  If I understand correctly there were no objections against commiting.
 >  Freeze is in the past. I've checked patch perl under NetBSD-5/pkgsrc-2009Q3.
 >  It is built fine and PLIST doesn't change.
 >  perl -V also doesn't show significant difference.

 My patch introduces the problem.
 http://mova.org/~cheusov/pub/pkgsrc-distbb/Linux/current/logs/20091016.2105/net_p5-Net-LibIDN_p5-Net-LibIDN-0.12/stage_configure.html

 After some thoughts I came to a conclusion that it is better to revert my
 original proposal and to *remove* DB_File extension from perl on all
 platforms including NetBSD. In this case perl will become lighter and
 packages requering DB_Fill (e.g. ikiwiki) should depend on
 databases/p5-DB_File.

 -- 
 Best regards, Aleksey Cheusov.

Responsible-Changed-From-To: pkg-manager->pkgsrc-p5-people
Responsible-Changed-By: sno@NetBSD.org
Responsible-Changed-When: Wed, 13 Apr 2011 21:28:09 +0000
Responsible-Changed-Why:
p5 people should be responsible and I hope I get it done for Q2 freeze when gnats reminds me ...


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.