NetBSD Problem Report #42159
From apb@cequrux.com Tue Oct 6 19:08:26 2009
Return-Path: <apb@cequrux.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by www.NetBSD.org (Postfix) with ESMTP id A55D263B8B6
for <gnats-bugs@gnats.NetBSD.org>; Tue, 6 Oct 2009 19:08:26 +0000 (UTC)
Message-Id: <20091006190813.9B6F1100F0AF@apb-laptoy.apb.alt.za>
Date: Tue, 6 Oct 2009 19:08:13 +0000 (UTC)
From: apb@cequrux.com
Reply-To: apb@cequrux.com
To: gnats-bugs@gnats.NetBSD.org
Subject: /usr/tests/** files use HOST_SH instead of /bin/sh
X-Send-Pr-Version: 3.95
>Number: 42159
>Category: bin
>Synopsis: /usr/tests/** files use HOST_SH instead of /bin/sh
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: bin-bug-people
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Tue Oct 06 19:10:00 +0000 2009
>Last-Modified: Mon Oct 19 02:15:02 +0000 2009
>Originator: Alan Barrett
>Release: NetBSD 5.99.18
>Organization:
Not much
>Environment:
System: NetBSD 5.99.18
Architecture: i386
Machine: i386
>Description:
When a build is done using build.sh, many shell scripts
under ${DESTDIR}/usr/tests have the value of ${HOST_SH}
instead of /bin/sh in the #! line.
These scripts are build products intended to run
on the target system, not on the build system, so it's
wrong for them to use ${HOST_SH}.
>How-To-Repeat:
$ HOST_SH=/usr/pkg/bin/bash ./build.sh build
$ head -1 ${DESTDIR}/usr/tests/atf/test_programs/t_config
#! /usr/pkg/bin/bash
>Fix:
Fix the build process to pass ATF_SHELL=/bin/sh in appropriate
places. Parts of ATF that run on the host should use
${HOST_SH}, and parts of ATF that run on the target should use
/bin/sh.
>Audit-Trail:
From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: bin/42159: /usr/tests/** files use HOST_SH instead of /bin/sh
Date: Mon, 19 Oct 2009 02:13:23 +0000
On Tue, Oct 06, 2009 at 07:10:00PM +0000, apb@cequrux.com wrote:
> When a build is done using build.sh, many shell scripts
> under ${DESTDIR}/usr/tests have the value of ${HOST_SH}
> instead of /bin/sh in the #! line.
As I recall some of the sh tests will end up testing ${HOST_SH} also,
which isn't really the right idea. I fixed at least a couple of them
at one point, but I don't think all and whoever digs into this should
probably check on it.
--
David A. Holland
dholland@netbsd.org
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.