NetBSD Problem Report #42168
From dan@mcmahill.net Sat Oct 10 02:10:09 2009
Return-Path: <dan@mcmahill.net>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by www.NetBSD.org (Postfix) with ESMTP id 04C3463B8B6
for <gnats-bugs@gnats.netbsd.org>; Sat, 10 Oct 2009 02:10:09 +0000 (UTC)
Message-Id: <20091010021005.5C9052460224@bondage.mcmahill.net>
Date: Fri, 9 Oct 2009 22:10:05 -0400 (EDT)
From: dmcmahill@netbsd.org
Reply-To: dmcmahill@netbsd.org
To: gnats-bugs@gnats.NetBSD.org
Subject: devel/scmgit-base broken on netbsd
X-Send-Pr-Version: 3.95
>Number: 42168
>Category: pkg
>Synopsis: devel/scmgit-base broken on netbsd
>Confidential: no
>Severity: serious
>Priority: medium
>Responsible: bjs
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sat Oct 10 02:15:00 +0000 2009
>Closed-Date: Sat Jan 30 19:32:22 +0000 2010
>Last-Modified: Sat Jan 30 19:32:22 +0000 2010
>Originator: Dan McMahill
>Release: NetBSD 5.0_STABLE
>Organization:
NetBSD
>Environment:
>Description:
a couple of shell (/bin/sh) scripts in git use "cd -P". The -P part is not known to
our shell. The result is a totally non-functional git.
find and grep for 'cd -P' over the git source tree will show the couple of spots.
>How-To-Repeat:
>Fix:
probably just rremoving -P will usually work, maybe need something a bit better.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: pkg-manager->bjs
Responsible-Changed-By: asau@NetBSD.org
Responsible-Changed-When: Sat, 10 Oct 2009 09:06:45 +0000
Responsible-Changed-Why:
Assign to maintainer.
From: der Mouse <mouse@Rodents-Montreal.ORG>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/42168: 1.6.4.1 on 4.0.1 success
Date: Wed, 30 Dec 2009 22:57:03 -0500 (EST)
I found building git 1.6.4.1 on NetBSD/i386 4.0.1 to be a fairly easy
thing. In off-list email, I was prompted to drop a note to this PR
reporting this.
Checking my git install, I find cd -P in only one place, that being
git-sh-setup. This might have caused trouble if I were trying to set
up a git repository on my machine, which I wasn't; while possibly a
problem, it did not lead to "a totally non-functional git".
Perhaps breaking setup is enough for dmcmahill to consider git totally
non-functional. Or perhaps this is a version difference.
In any case, here are the changes I made for 4.0.1. (For 1.4T, in case
anyone cares (yeahright!), change OLD_ICONV to NO_ICONV in the first
patch's first hunk.) The patch to builtin-diff.c is unnecessary (but
harmless) on systems that have had lib/41919 fixed. How relevant they
may be to pkgsrc is perhaps debatable, but this might at least help
someone who wants to get git working. Note that you probably do not
want these patches directly, since they include heavy-handed changes to
make it install where I want it, but they may serve as a useful
starting point.
/~\ The ASCII Mouse
\ / Ribbon Campaign
X Against HTML mouse@rodents-montreal.org
/ \ Email! 7D C8 61 52 5D E7 2D 39 4E F1 31 3E E8 B3 27 4B
diff -u -r git-1.6.4.1/Makefile git-1.6.4.1+/Makefile
--- git-1.6.4.1/Makefile 2009-08-22 00:54:01.000000000 -0400
+++ git-1.6.4.1+/Makefile 2009-08-22 18:38:01.000000000 -0400
@@ -199,6 +199,17 @@
#
# Define NO_REGEX if you have no or inferior regex support in your C library.
+NO_OPENSSL=1
+NO_CURL=1
+NO_EXPAT=1
+NO_SVN_TESTS=1
+MOZILLA_SHA1=1
+OLD_ICONV=1
+NO_PERL=1
+NO_TCLTK=1
+INTERNAL_QSORT=1
+NO_DEFLATE_BOUND=1
+
GIT-VERSION-FILE: .FORCE-GIT-VERSION-FILE
@$(SHELL_PATH) ./GIT-VERSION-GEN
-include GIT-VERSION-FILE
@@ -230,21 +241,21 @@
# runtime figures out where they are based on the path to the executable.
# This can help installing the suite in a relocatable way.
-prefix = $(HOME)
-bindir_relative = bin
-bindir = $(prefix)/$(bindir_relative)
-mandir = share/man
-infodir = share/info
-gitexecdir = libexec/git-core
-sharedir = $(prefix)/share
-template_dir = share/git-core/templates
-htmldir = share/doc/git-doc
+prefix = /SHOULD/NOT/APPEAR
+bindir_relative = /SHOULD/NOT/APPEAR
+bindir = /local/.bin/git-1.6.4.1
+mandir = /local/.man/git-1.6.4.1
+infodir = /local/src/git/git-1.6.4.1/junk.info
+gitexecdir = $(bindir)
+sharedir = /SHOULD/NOT/APPEAR
+template_dir = /local/.lib/git-1.6.4.1/templates
+htmldir = /local/src/git/git-1.6.4.1/junk.html
ifeq ($(prefix),/usr)
sysconfdir = /etc
ETC_GITCONFIG = $(sysconfdir)/gitconfig
else
-sysconfdir = $(prefix)/etc
-ETC_GITCONFIG = etc/gitconfig
+sysconfdir = /local/etc/git
+ETC_GITCONFIG = /local/etc/git
endif
lib = lib
# DESTDIR=
diff -u -r git-1.6.4.1/builtin-diff.c git-1.6.4.1+/builtin-diff.c
--- git-1.6.4.1/builtin-diff.c 2009-08-22 00:54:01.000000000 -0400
+++ git-1.6.4.1+/builtin-diff.c 2009-08-22 17:37:55.000000000 -0400
@@ -92,7 +92,7 @@
int argc, const char **argv,
struct blobinfo *blob)
{
- unsigned mode = canon_mode(S_IFREG | 0644);
+ unsigned mode = canon_mode((S_IFREG | 0644));
if (argc > 1)
usage(builtin_diff_usage);
diff -u -r git-1.6.4.1/xdiff/xmerge.c git-1.6.4.1+/xdiff/xmerge.c
--- git-1.6.4.1/xdiff/xmerge.c 2009-08-22 00:54:01.000000000 -0400
+++ git-1.6.4.1+/xdiff/xmerge.c 2009-08-22 17:33:42.000000000 -0400
@@ -22,6 +22,8 @@
#include "xinclude.h"
+#define xisalnum(x) isalnum((unsigned char)(x))
+
typedef struct s_xdmerge {
struct s_xdmerge *next;
/*
@@ -314,7 +316,7 @@
static int line_contains_alnum(const char *ptr, long size)
{
while (size--)
- if (isalnum(*(ptr++)))
+ if (xisalnum(*(ptr++)))
return 1;
return 0;
}
diff -u -r git-1.6.4.1/xdiff/xutils.c git-1.6.4.1+/xdiff/xutils.c
--- git-1.6.4.1/xdiff/xutils.c 2009-08-22 00:54:01.000000000 -0400
+++ git-1.6.4.1+/xdiff/xutils.c 2009-08-22 17:27:26.000000000 -0400
@@ -26,7 +26,7 @@
#define XDL_GUESS_NLINES 256
-
+#define xisspace(x) isspace((unsigned char)(x))
long xdl_bogosqrt(long n) {
@@ -192,11 +192,11 @@
if (flags & XDF_IGNORE_WHITESPACE) {
for (i1 = i2 = 0; i1 < s1 && i2 < s2; ) {
- if (isspace(l1[i1]))
- while (isspace(l1[i1]) && i1 < s1)
+ if (xisspace(l1[i1]))
+ while (xisspace(l1[i1]) && i1 < s1)
i1++;
- if (isspace(l2[i2]))
- while (isspace(l2[i2]) && i2 < s2)
+ if (xisspace(l2[i2]))
+ while (xisspace(l2[i2]) && i2 < s2)
i2++;
if (i1 < s1 && i2 < s2 && l1[i1++] != l2[i2++])
return 0;
@@ -204,12 +204,12 @@
return (i1 >= s1 && i2 >= s2);
} else if (flags & XDF_IGNORE_WHITESPACE_CHANGE) {
for (i1 = i2 = 0; i1 < s1 && i2 < s2; ) {
- if (isspace(l1[i1])) {
- if (!isspace(l2[i2]))
+ if (xisspace(l1[i1])) {
+ if (!xisspace(l2[i2]))
return 0;
- while (isspace(l1[i1]) && i1 < s1)
+ while (xisspace(l1[i1]) && i1 < s1)
i1++;
- while (isspace(l2[i2]) && i2 < s2)
+ while (xisspace(l2[i2]) && i2 < s2)
i2++;
} else if (l1[i1++] != l2[i2++])
return 0;
@@ -218,9 +218,9 @@
} else if (flags & XDF_IGNORE_WHITESPACE_AT_EOL) {
for (i1 = i2 = 0; i1 < s1 && i2 < s2; ) {
if (l1[i1] != l2[i2]) {
- while (i1 < s1 && isspace(l1[i1]))
+ while (i1 < s1 && xisspace(l1[i1]))
i1++;
- while (i2 < s2 && isspace(l2[i2]))
+ while (i2 < s2 && xisspace(l2[i2]))
i2++;
if (i1 < s1 || i2 < s2)
return 0;
@@ -240,9 +240,9 @@
char const *ptr = *data;
for (; ptr < top && *ptr != '\n'; ptr++) {
- if (isspace(*ptr)) {
+ if (xisspace(*ptr)) {
const char *ptr2 = ptr;
- while (ptr + 1 < top && isspace(ptr[1])
+ while (ptr + 1 < top && xisspace(ptr[1])
&& ptr[1] != '\n')
ptr++;
if (flags & XDF_IGNORE_WHITESPACE)
From: Dan McMahill <dmcmahill@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: bjs@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/42168: 1.6.4.1 on 4.0.1 success
Date: Wed, 30 Dec 2009 23:15:32 -0500
der Mouse wrote:
> The following reply was made to PR pkg/42168; it has been noted by GNATS.
>
> From: der Mouse <mouse@Rodents-Montreal.ORG>
> To: gnats-bugs@NetBSD.org
> Cc:
> Subject: Re: pkg/42168: 1.6.4.1 on 4.0.1 success
> Date: Wed, 30 Dec 2009 22:57:03 -0500 (EST)
>
> I found building git 1.6.4.1 on NetBSD/i386 4.0.1 to be a fairly easy
> thing. In off-list email, I was prompted to drop a note to this PR
> reporting this.
>
> Checking my git install, I find cd -P in only one place, that being
> git-sh-setup. This might have caused trouble if I were trying to set
> up a git repository on my machine, which I wasn't; while possibly a
> problem, it did not lead to "a totally non-functional git".
>
> Perhaps breaking setup is enough for dmcmahill to consider git totally
> non-functional. Or perhaps this is a version difference.
It has been a while, but I think the first thing I tried was to clone a
repository and it failed with the 'cd -P' thing. I can't recall now if
there were 2 spots or just the 1 spot that had 'cd -P'. As near as I
can tell this is the first operation that most users probably need to do
so I considered it quite fatal.
Anyway, thanks for attaching the patches. I've just been way to buried
to spend the small amount of time needed to fix this.
-Dan
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/42168 CVS commit: src/bin/sh
Date: Fri, 1 Jan 2010 19:35:00 +0000
Module Name: src
Committed By: dholland
Date: Fri Jan 1 19:34:59 UTC 2010
Modified Files:
src/bin/sh: cd.c sh.1
Log Message:
Make the cd builtin accept and ignore -P, which is a kshism that has been
allowed to leak into POSIX and selects the behavior cd already implements.
Closes PR bin/42557 and also relevant to PR pkg/42168.
I suppose this should probably be pulled up to both -4 and -5...
To generate a diff of this commit:
cvs rdiff -u -r1.39 -r1.40 src/bin/sh/cd.c
cvs rdiff -u -r1.94 -r1.95 src/bin/sh/sh.1
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: pkg/42168: devel/scmgit-base broken on netbsd
Date: Fri, 1 Jan 2010 21:24:09 +0000
On Sat, Oct 10, 2009 at 02:15:00AM +0000, dmcmahill@netbsd.org wrote:
> a couple of shell (/bin/sh) scripts in git use "cd -P". The -P
> part is not known to our shell. The result is a totally
> non-functional git.
> [...]
> probably just rremoving -P will usually work, maybe need something
> a bit better.
It is now, but even if it gets pulled up everywhere there are
doubtless other systems whose shells don't support this inanity, so we
need a fix in pkgsrc too.
Unfortunately, since for ksh the -P is required for correct behavior
it isn't necessarily so simple as just patching it out.
--
David A. Holland
dholland@netbsd.org
State-Changed-From-To: open->feedback
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sat, 09 Jan 2010 15:52:37 +0000
State-Changed-Why:
Better now?
From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/42168 CVS commit: pkgsrc/devel/scmgit-base
Date: Sat, 9 Jan 2010 15:52:19 +0000
Module Name: pkgsrc
Committed By: wiz
Date: Sat Jan 9 15:52:19 UTC 2010
Modified Files:
pkgsrc/devel/scmgit-base: Makefile
Log Message:
Fix PR 42168:
Remove '-P' argument from cd.
Bump PKGREVISION.
To generate a diff of this commit:
cvs rdiff -u -r1.16 -r1.17 pkgsrc/devel/scmgit-base/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Steven Drake <sdrake@xnet.co.nz>
To: Thomas Klausner <wiz@netbsd.org>
Cc: bjs@NetBSD.org, gnats-bugs@gnats.netbsd.org, pkgsrc-bugs@netbsd.org,
dmcmahill@netbsd.org
Subject: Re: PR/42168 CVS commit: pkgsrc/devel/scmgit-base
Date: Sun, 10 Jan 2010 20:08:24 +1300 (NZDT)
On Sat, 9 Jan 2010, Thomas Klausner wrote:
> Module Name: pkgsrc
> Committed By: wiz
> Date: Sat Jan 9 15:52:19 UTC 2010
>
> Modified Files:
> pkgsrc/devel/scmgit-base: Makefile
>
> Log Message:
> Fix PR 42168:
> Remove '-P' argument from cd.
>
> Bump PKGREVISION.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.16 -r1.17 pkgsrc/devel/scmgit-base/Makefile
I should point out that the above commit will change/break the behaviour
of git shell scripts on most system's (system's were /bin/sh follows the
ksh behaviour).
It's would be a lot better to inclose the SUBST_*.fix-cd-PD section in with
".if ${OPSYS} == ..." with the systems that need it.
From looking at the online man pages of the pkgsrc supported systems it
looks like the systems that don't support 'cd -P' are:
NetBSD, SunOS, OSF1, HPUX, QNX and UnixWare.
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/devel/scmgit-base/Makefile,v
retrieving revision 1.17
diff -u -p -r1.17 Makefile
--- Makefile 9 Jan 2010 15:52:19 -0000 1.17
+++ Makefile 10 Jan 2010 06:57:03 -0000
@@ -80,6 +80,7 @@ SUBST_MESSAGE.fix-paths=Fixing hard-code
SUBST_STAGE.fix-paths= pre-build
SUBST_VARS.fix-paths= PREFIX
+.if ${OPSYS} == "NetBSD" || ${OPSYS} == "SunOS" || ${OPSYS} == "OSF1" || ${OPSYS} == "HPUX" || ${OPSYS} == "QNX" || ${OPSYS} == "UnixWare"
SUBST_CLASSES+= fix-cd-P
SUBST_FILES.fix-cd-P= git-sh-setup.sh
SUBST_FILES.fix-cd-P+= t/t0000-basic.sh
@@ -88,6 +89,7 @@ SUBST_FILES.fix-cd-P+= t/test-lib.sh
SUBST_MESSAGE.fix-cd-P= Fixing cd arguments.
SUBST_STAGE.fix-cd-P= pre-build
SUBST_SED.fix-cd-P= -e "s/cd -P/cd/g"
+.endif
#.include "../../editors/emacs/modules.mk" # XXX TODO (see patch-ad)
--
Steven
From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/42168 CVS commit: pkgsrc/devel/scmgit-base
Date: Sun, 10 Jan 2010 07:53:10 +0000
Module Name: pkgsrc
Committed By: wiz
Date: Sun Jan 10 07:53:10 UTC 2010
Modified Files:
pkgsrc/devel/scmgit-base: Makefile
Log Message:
Wrap 'cd -P' replacement code in platform ifdefs.
From Steven Drake in PR 42168.
To generate a diff of this commit:
cvs rdiff -u -r1.17 -r1.18 pkgsrc/devel/scmgit-base/Makefile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Thomas Klausner <wiz@netbsd.org>
To: Steven Drake <sdrake@xnet.co.nz>
Cc: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Subject: Re: PR/42168 CVS commit: pkgsrc/devel/scmgit-base
Date: Sun, 10 Jan 2010 08:53:43 +0100
On Sun, Jan 10, 2010 at 08:08:24PM +1300, Steven Drake wrote:
> I should point out that the above commit will change/break the behaviour
> of git shell scripts on most system's (system's were /bin/sh follows the
> ksh behaviour).
>
> It's would be a lot better to inclose the SUBST_*.fix-cd-PD section in with
> ".if ${OPSYS} == ..." with the systems that need it.
>
> >From looking at the online man pages of the pkgsrc supported systems it
> looks like the systems that don't support 'cd -P' are:
> NetBSD, SunOS, OSF1, HPUX, QNX and UnixWare.
Thanks, committed (with an additional inclusion of bsd.prefs.mk).
Thomas
From: Steven Drake <sdrake@xnet.co.nz>
To: Thomas Klausner <wiz@netbsd.org>
Cc: bjs@NetBSD.org, gnats-bugs@gnats.netbsd.org, pkgsrc-bugs@netbsd.org,
dmcmahill@netbsd.org
Subject: Re: PR/42168 CVS commit: pkgsrc/devel/scmgit-base
Date: Sun, 10 Jan 2010 20:59:19 +1300 (NZDT)
Or you could try the following patches that I've also sent to the git list.
Index: patches/patch-ad
===================================================================
RCS file: patches/patch-ad
diff -N patches/patch-ad
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-ad 10 Jan 2010 07:54:08 -0000
@@ -0,0 +1,14 @@
+$NetBSD$
+
+--- Documentation/git-rev-parse.txt.orig 2009-07-29 20:18:18.000000000 +1200
++++ Documentation/git-rev-parse.txt
+@@ -112,6 +112,9 @@ OPTIONS
+ --remotes::
+ Show tag refs found in `$GIT_DIR/refs/remotes`.
+
++--show-toplevel::
++ Show the absolute path of the top-level directory.
++
+ --show-prefix::
+ When the command is invoked from a subdirectory, show the
+ path of the current directory relative to the top-level
Index: patches/patch-aj
===================================================================
RCS file: patches/patch-aj
diff -N patches/patch-aj
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-aj 10 Jan 2010 07:54:08 -0000
@@ -0,0 +1,20 @@
+$NetBSD$
+
+Add 'git rev-parse --show-toplevel' option.
+Shows the absolute path of the top-level working directory.
+
+--- builtin-rev-parse.c.orig 2009-07-29 20:18:18.000000000 +1200
++++ builtin-rev-parse.c
+@@ -560,6 +560,12 @@ int cmd_rev_parse(int argc, const char *
+ for_each_remote_ref(show_reference, NULL);
+ continue;
+ }
++ if (!strcmp(arg, "--show-toplevel")) {
++ const char *work_tree = get_git_work_tree();
++ if (work_tree)
++ printf("%s\n", work_tree);
++ continue;
++ }
+ if (!strcmp(arg, "--show-prefix")) {
+ if (prefix)
+ puts(prefix);
Index: patches/patch-ak
===================================================================
RCS file: patches/patch-ak
diff -N patches/patch-ak
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-ak 10 Jan 2010 07:54:08 -0000
@@ -0,0 +1,28 @@
+$NetBSD$
+
+Use $(git rev-parse --show-toplevel) in cd_to_toplevel()
+as it gives the absolute (aka "physical") path of the toplevel directory
+and 'cd -P' is not supported by all shell implementations.
+
+--- git-sh-setup.sh.orig 2009-07-29 20:18:18.000000000 +1200
++++ git-sh-setup.sh
+@@ -119,16 +119,10 @@ is_bare_repository () {
+ }
+
+ cd_to_toplevel () {
+- cdup=$(git rev-parse --show-cdup)
+- if test ! -z "$cdup"
++ if test ! -z "$(git rev-parse --show-cdup)"
+ then
+- # The "-P" option says to follow "physical" directory
+- # structure instead of following symbolic links. When cdup is
+- # "../", this means following the ".." entry in the current
+- # directory instead textually removing a symlink path element
+- # from the PWD shell variable. The "-P" behavior is more
+- # consistent with the C-style chdir used by most of Git.
+- cd -P "$cdup" || {
++ cdup=$(git rev-parse --show-toplevel)
++ cd "$cdup" || {
+ echo >&2 "Cannot chdir to $cdup, the toplevel of the working tree"
+ exit 1
+ }
--
Steven
From: Steven Drake <sdrake@xnet.co.nz>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: PR/42168 CVS commit: pkgsrc/devel/scmgit-base
Date: Wed, 13 Jan 2010 12:18:47 +1300 (NZDT)
This problem has been fixed upstream by commit 91dc602d.
http://git.kernel.org/?p=git/git.git;a=commit;h=91dc602d
--
Steven
From: Manuel Bouyer <bouyer@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/42168 CVS commit: [netbsd-4] src/bin/sh
Date: Wed, 27 Jan 2010 21:01:58 +0000
Module Name: src
Committed By: bouyer
Date: Wed Jan 27 21:01:58 UTC 2010
Modified Files:
src/bin/sh [netbsd-4]: cd.c sh.1
Log Message:
Pull up following revision(s) (requested by dholland in ticket #1380):
bin/sh/cd.c: revision 1.40
bin/sh/sh.1: revision 1.95
bin/sh/sh.1: revision 1.97
Make the cd builtin accept and ignore -P, which is a kshism that has been
allowed to leak into POSIX and selects the behavior cd already implements.
Closes PR bin/42557 and also relevant to PR pkg/42168.
I suppose this should probably be pulled up to both -4 and -5...
Bump date for cd -P support.
To generate a diff of this commit:
cvs rdiff -u -r1.39 -r1.39.4.1 src/bin/sh/cd.c
cvs rdiff -u -r1.85.2.1 -r1.85.2.2 src/bin/sh/sh.1
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: Soren Jacobsen <snj@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/42168 CVS commit: [netbsd-5] src/bin/sh
Date: Sat, 30 Jan 2010 19:24:33 +0000
Module Name: src
Committed By: snj
Date: Sat Jan 30 19:24:33 UTC 2010
Modified Files:
src/bin/sh [netbsd-5]: cd.c sh.1
Log Message:
Pull up following revision(s) (requested by dholland in ticket #1274):
bin/sh/cd.c: revision 1.40
bin/sh/sh.1: revision 1.95
Make the cd builtin accept and ignore -P, which is a kshism that has been
allowed to leak into POSIX and selects the behavior cd already implements.
Closes PR bin/42557 and also relevant to PR pkg/42168.
I suppose this should probably be pulled up to both -4 and -5...
To generate a diff of this commit:
cvs rdiff -u -r1.39 -r1.39.26.1 src/bin/sh/cd.c
cvs rdiff -u -r1.87.18.1 -r1.87.18.2 src/bin/sh/sh.1
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 30 Jan 2010 19:32:22 +0000
State-Changed-Why:
Fixed in NetBSD base, fixed upstream, and we have Steven Drake's patches in
place, so I think we can close this now.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home