NetBSD Problem Report #42586

From www@NetBSD.org  Wed Jan  6 15:38:19 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 14AE063C430
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  6 Jan 2010 15:38:19 +0000 (UTC)
Message-Id: <20100106153818.D438963C37E@www.NetBSD.org>
Date: Wed,  6 Jan 2010 15:38:18 +0000 (UTC)
From: giffunip@tutopia.com
Reply-To: giffunip@tutopia.com
To: gnats-bugs@NetBSD.org
Subject: Memory leak in fsck_ext2fs
X-Send-Pr-Version: www-1.0

>Number:         42586
>Category:       bin
>Synopsis:       Memory leak in fsck_ext2fs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 06 15:40:00 +0000 2010
>Closed-Date:    Sat Jan 23 20:11:18 +0000 2010
>Last-Modified:  Sat Jan 23 20:11:18 +0000 2010
>Originator:     Pedro F. Giffuni
>Release:        N/A
>Organization:
N/A
>Environment:
N/A
>Description:
I am checking differences between NetBSD and OpenBSD's fsck_ext2fs and I noticed they have cleaned up a memory leak and other issues that NetBSD hasn't yet.

Revision 1.18
do not leak memory, found by parfait, ok millert otto
(one case was a false positive, but one is a modified copy of the other)

Revision 1.17
solve some signal races; from fsck_ffs; ok pedro

>How-To-Repeat:

>Fix:
http://www.openbsd.org/cgi-bin/cvsweb/src/sbin/fsck_ext2fs/utilities.c.diff?r1=1.16;r2=1.18

>Release-Note:

>Audit-Trail:

From: Christos Zoulas <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/42568 CVS commit: src/sbin
Date: Wed, 6 Jan 2010 13:12:37 -0500

 Module Name:	src
 Committed By:	christos
 Date:		Wed Jan  6 18:12:37 UTC 2010

 Modified Files:
 	src/sbin/fsck_ext2fs: main.c utilities.c
 	src/sbin/fsck_ffs: main.c utilities.c
 	src/sbin/fsck_lfs: main.c utilities.c

 Log Message:
 PR/42568: Pedro F. Giffuni: Better signal handling from OpenBSD, but simplified.


 To generate a diff of this commit:
 cvs rdiff -u -r1.34 -r1.35 src/sbin/fsck_ext2fs/main.c
 cvs rdiff -u -r1.19 -r1.20 src/sbin/fsck_ext2fs/utilities.c
 cvs rdiff -u -r1.73 -r1.74 src/sbin/fsck_ffs/main.c
 cvs rdiff -u -r1.56 -r1.57 src/sbin/fsck_ffs/utilities.c
 cvs rdiff -u -r1.40 -r1.41 src/sbin/fsck_lfs/main.c
 cvs rdiff -u -r1.27 -r1.28 src/sbin/fsck_lfs/utilities.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.



State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 23 Jan 2010 20:11:18 +0000
State-Changed-Why:
Christos committed it on January 6 but the commit message got misdirected to
the wrong PR.
That has now been straightened out...
Thanks for the fix.


>Unformatted:

Home	PR Database Search