NetBSD Problem Report #426
From gnats Sat Aug 20 23:59:13 1994
Received: from wildcat.demon.co.uk (root@wildcat.demon.co.uk [158.152.43.69]) by sun-lamp.cs.berkeley.edu (8.6.9/8.6.9) with ESMTP id XAA02151 for <gnats-bugs@sun-lamp.cs.berkeley.edu>; Sat, 20 Aug 1994 23:58:59 -0700
Message-Id: <199408201423.PAA00413@wildcat.demon.co.uk>
Date: Sat, 20 Aug 1994 15:23:07 +0100
From: Alasdair Baird <alasdair@wildcat.demon.co.uk>
Reply-To: alasdair@wildcat.demon.co.uk
To: gnats-bugs@sun-lamp.cs.berkeley.edu
Subject: mistake in /sys/arch/i386/isa/com.c
X-Send-Pr-Version: 3.2
>Number: 426
>Category: port-i386
>Synopsis: error in com.c that prevents MDMBUF flag being respected
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: gnats-admin (GNATS administrator)
>State: closed
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Sun Aug 21 00:05:03 +0000 1994
>Closed-Date: Sun Aug 21 15:05:27 +0000 1994
>Last-Modified:
>Originator: Alasdair Baird
>Release: current (Aug 18)
>Organization:
absolutely none whatsoever
>Environment:
System: NetBSD wildcat.demon.co.uk 1.0_BETA NetBSD 1.0_BETA (WILDCAT) #38: Tue Aug 16 14:09:12 BST 1994 root@wildcat.demon.co.uk:/usr/src/sys/arch/i386/compile/WILDCAT i386
>Description:
In com.c the MDMBUF flag is looked for in the tty struct's
t_lflag field to determine whether it should be assumed that
a carrier is present. However, the MDMBUF flag doesn't live
in t_lflag; it is to be found in the t_cflag field.
>How-To-Repeat:
Found by inspection. (Does anyone actually use MDMBUF?)
>Fix:
Change an occurance of t_lflag to be t_cflag as follows:
*** com.c.old Sat Aug 20 15:06:42 1994
--- com.c Sat Aug 20 15:07:48 1994
***************
*** 313,319 ****
sc->sc_msr = inb(iobase + com_msr);
if (sc->sc_swflags & COM_SW_SOFTCAR || sc->sc_msr & MSR_DCD ||
! tp->t_lflag&MDMBUF)
tp->t_state |= TS_CARR_ON;
else
tp->t_state &= ~TS_CARR_ON;
--- 313,319 ----
sc->sc_msr = inb(iobase + com_msr);
if (sc->sc_swflags & COM_SW_SOFTCAR || sc->sc_msr & MSR_DCD ||
! tp->t_cflag & MDMBUF)
tp->t_state |= TS_CARR_ON;
else
tp->t_state &= ~TS_CARR_ON;
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: mycroft
State-Changed-When: Sun Aug 21 08:05:27 PDT 1994
State-Changed-Why:
Patch applied.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.