NetBSD Problem Report #42628

From dyoung@ojctech.com  Sat Jan 16 18:58:03 2010
Return-Path: <dyoung@ojctech.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 3156463C561
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 16 Jan 2010 18:58:03 +0000 (UTC)
Message-Id: <20100116185716.CBABB1BFB5C@elmendorf.ojctech.com>
Date: Sat, 16 Jan 2010 12:57:16 -0600 (CST)
From: dyoung@ojctech.com
Reply-To: dyoung@ojctech.com
To: gnats-bugs@gnats.NetBSD.org
Subject: unifdef is broken
X-Send-Pr-Version: 3.95

>Number:         42628
>Category:       bin
>Synopsis:       unifdef is broken
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 16 19:00:00 +0000 2010
>Closed-Date:    Tue May 03 07:24:02 +0000 2011
>Last-Modified:  Tue May 03 07:25:00 +0000 2011
>Originator:     David Young
>Release:        NetBSD 5.99.23
>Organization:
David Young             OJC Technologies
dyoung@ojctech.com      Urbana, IL * (217) 278-3933
>Environment:
System: NetBSD elmendorf.ojctech.com 5.99.23 NetBSD 5.99.23 (GENERIC) #15: Thu Jan 7 18:46:33 CST 2010 dyoung@cuw.ojctech.com:/u5/dyoung-scratch/pristine/i386/O/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
unifdef -Usym is not removing lines bracketed
by #if defined(sym)/#endif.
>How-To-Repeat:
Try this:

unifdef -U__FreeBSD__ <<EOF
#if defined(__FreeBSD__)
#include <netinet/if_fddi.h>
#else
#include <net/if_fddi.h>
#endif
EOF

The output is the same as the input:

#if defined(__FreeBSD__)
#include <netinet/if_fddi.h>
#else
#include <net/if_fddi.h>
#endif

Ditto the output of unifdef -U __FreeBSD__ (i.e., with a space between
the -U and its argument).

>Fix:
Unknown.

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/42628: unifdef is broken
Date: Mon, 3 May 2010 06:08:10 +0000

 Not sent to gnats.

    ------

 From: Tony Finch <dot@dotat.at>
 To: netbsd-bugs@netbsd.org
 cc: dot@dotat.at
 Subject: bin/42628: unifdef is broken
 Date: Wed, 10 Feb 2010 01:29:02 +0000

 I can't reproduce this bug with the latest version of unifdef from
 http://dotat.at/prog/unifdef/

 Tony.
 -- 
 f.anthony.n.finch  <dot@dotat.at>  http://dotat.at/
 GERMAN BIGHT HUMBER: SOUTHWEST 5 TO 7. MODERATE OR ROUGH. SQUALLY SHOWERS.
 MODERATE OR GOOD.

State-Changed-From-To: open->feedback
State-Changed-By: ginsbach@NetBSD.org
State-Changed-When: Fri, 14 Jan 2011 22:42:55 +0000
State-Changed-Why:
Appears that christos fixed this in Revision 1.16 (it was broke in 1.13).
The fix should be pulled up to the appropriate branches.


State-Changed-From-To: feedback->closed
State-Changed-By: jruoho@NetBSD.org
State-Changed-When: Tue, 03 May 2011 07:24:02 +0000
State-Changed-Why:

Should be fixed.



From: "Jukka Ruohonen" <jruoho@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/42628 CVS commit: src
Date: Tue, 3 May 2011 07:23:20 +0000

 Module Name:	src
 Committed By:	jruoho
 Date:		Tue May  3 07:23:19 UTC 2011

 Modified Files:
 	src/distrib/sets/lists/tests: mi
 	src/etc/mtree: NetBSD.dist.tests
 	src/tests/usr.bin: Makefile
 Added Files:
 	src/tests/usr.bin/unifdef: Makefile d_basic.in d_basic.out t_basic.sh

 Log Message:
 Verify that PR bin/42628 is no longer an issue.


 To generate a diff of this commit:
 cvs rdiff -u -r1.322 -r1.323 src/distrib/sets/lists/tests/mi
 cvs rdiff -u -r1.42 -r1.43 src/etc/mtree/NetBSD.dist.tests
 cvs rdiff -u -r1.2 -r1.3 src/tests/usr.bin/Makefile
 cvs rdiff -u -r0 -r1.1 src/tests/usr.bin/unifdef/Makefile \
     src/tests/usr.bin/unifdef/d_basic.in \
     src/tests/usr.bin/unifdef/d_basic.out \
     src/tests/usr.bin/unifdef/t_basic.sh

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search