NetBSD Problem Report #42776

From www@NetBSD.org  Tue Feb  9 09:10:38 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 8981363C44D
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  9 Feb 2010 09:10:38 +0000 (UTC)
Message-Id: <20100209091038.42A5D63C44B@www.NetBSD.org>
Date: Tue,  9 Feb 2010 09:10:38 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Eliminate dead store in fvwrite.c
X-Send-Pr-Version: www-1.0

>Number:         42776
>Category:       lib
>Synopsis:       Eliminate dead store in fvwrite.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    lib-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 09 09:15:00 +0000 2010
>Closed-Date:    Thu Mar 24 02:44:20 +0000 2011
>Last-Modified:  Thu Mar 24 02:44:20 +0000 2011
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Eliminate dead store in fvwrite.c .
>How-To-Repeat:

>Fix:
diff -u -r1.21 fvwrite.c
--- lib/libc/stdio/fvwrite.c	25 Oct 2009 20:44:13 -0000	1.21
+++ lib/libc/stdio/fvwrite.c	9 Feb 2010 08:32:58 -0000
@@ -75,7 +75,7 @@
 		errno = EINVAL;
 		return (EOF);
 	}
-	if ((len = uio->uio_resid) == 0)
+	if (uio->uio_resid == 0)
 		return (0);
 	/* make sure we can write */
 	if (cantwrite(fp)) {

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/42776 CVS commit: src/lib/libc/stdio
Date: Thu, 24 Mar 2011 02:29:33 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Thu Mar 24 02:29:33 UTC 2011

 Modified Files:
 	src/lib/libc/stdio: fvwrite.c

 Log Message:
 Eliminate dead store. From Henning Petersen in PR 42776. Doesn't change
 the output .o file.


 To generate a diff of this commit:
 cvs rdiff -u -r1.21 -r1.22 src/lib/libc/stdio/fvwrite.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Thu, 24 Mar 2011 02:44:20 +0000
State-Changed-Why:
Applied, thanks.
(no idea why it took more than a year for someone to handle it)


>Unformatted:

Home	PR Database Search