NetBSD Problem Report #42976

From tron@zhadum.org.uk  Mon Mar 15 11:18:50 2010
Return-Path: <tron@zhadum.org.uk>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 8E2D863B11D
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 15 Mar 2010 11:18:50 +0000 (UTC)
Message-Id: <20100315111848.01C303E3A7@mail.zhadum.org.uk>
Date: Mon, 15 Mar 2010 11:18:47 +0000 (GMT)
From: tron@zhadum.org.uk
Reply-To: tron@zhadum.org.uk
To: gnats-bugs@gnats.NetBSD.org
Subject: "install-sh" makes still required "-c" option
X-Send-Pr-Version: 3.95

>Number:         42976
>Category:       pkg
>Synopsis:       "install-sh" makes still required "-c" option
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 15 11:20:00 +0000 2010
>Closed-Date:    Mon Oct 11 04:30:56 +0000 2010
>Last-Modified:  Mon Oct 11 04:30:56 +0000 2010
>Originator:     Matthias Scheler
>Release:        pkgsrc-HEAD 2010-03-15
>Organization:
Matthias Scheler                                  http://zhadum.org.uk/
>Environment:
System: SunOS iduna 5.10 Generic_142901-03 i86pc i386 i86pc
Architecture: i386
Machine: i86pc

>Description:
Under Solaris "pkgsrc" uses the "install-sh" package to provide the
"install" command (instead of using "/usr/ucb/install" for whatever
reasons). This command does however still insists on the use of
the "-c" option to prevent the deletion of the source file. This
behaviour was broken to start with and has been fixed in
NetBSD's install(1) a while ago. "install-sh" should be changed
in a similar way.

>How-To-Repeat:
Build any package that use "install" without the "-c" option
e.g. "ffmpeg" before yesterday's fixes.

>Fix:
None provided.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: gls@NetBSD.org
Responsible-Changed-When: Mon, 15 Mar 2010 23:25:38 +0000
Responsible-Changed-Why:
Solaris specific issue, over to Solaris pkg maintainers


Responsible-Changed-From-To: solaris-pkg-people->pkg-manager
Responsible-Changed-By: tron@NetBSD.org
Responsible-Changed-When: Tue, 16 Mar 2010 07:22:40 +0000
Responsible-Changed-Why:
The "install-sh" package is used by multiple platforms, not only
by Solaris.


From: Tim Zingelman <zingelman@gmail.com>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, solaris-pkg-people@netbsd.org, 
	pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org, tron@netbsd.org, 
	tron@zhadum.org.uk
Subject: Re: pkg/42976 ("install-sh" makes still required "-c" option)
Date: Tue, 24 Aug 2010 11:50:36 -0500

 On Tue, Mar 16, 2010 at 2:22 AM,  <tron@netbsd.org> wrote:
 > Synopsis: "install-sh" makes still required "-c" option
 >
 > Responsible-Changed-From-To: solaris-pkg-people->pkg-manager
 > Responsible-Changed-By: tron@NetBSD.org
 > Responsible-Changed-When: Tue, 16 Mar 2010 07:22:40 +0000
 > Responsible-Changed-Why:
 > The "install-sh" package is used by multiple platforms, not only
 > by Solaris.

 Here's a patch... If I hear no concerns I'll commit it.  copy (vs. mv)
 seems to be default on every install I looked at (NetBSD 5.0.1,
 FreeBSD >= 6.4, Linux, Solaris 10) and this just brings install_sh in
 line with all the others...

 RCS file: /usr/cvs/pkgsrc/sysutils/install-sh/Makefile,v
 retrieving revision 1.7
 diff -w -u -b -r1.7 Makefile
 --- Makefile    9 Apr 2009 00:48:16 -0000       1.7
 +++ Makefile    24 Aug 2010 16:29:38 -0000
 @@ -1,6 +1,6 @@
 -# $NetBSD: Makefile,v 1.6 2009/04/08 22:43:25 joerg Exp $
 +# $NetBSD: Makefile,v 1.7 2009/04/09 00:48:16 joerg Exp $

 -DISTNAME=      install-sh-20070712
 +DISTNAME=      install-sh-20100824
  CATEGORIES=    sysutils
  MASTER_SITES=  # empty
  DISTFILES=     # empty
 Index: files/install-sh.in
 ===================================================================
 RCS file: /usr/cvs/pkgsrc/sysutils/install-sh/files/install-sh.in,v
 retrieving revision 1.4
 diff -w -u -b -r1.4 install-sh.in
 --- files/install-sh.in 12 Jul 2007 18:32:50 -0000      1.4
 +++ files/install-sh.in 24 Aug 2010 16:28:33 -0000
 @@ -44,7 +44,7 @@
  rmprog="${RMPROG-rm}"
  mkdirprog="${MKDIRPROG-mkdir}"

 -instcmd="$mvprog"
 +instcmd="$cpprog"
  pathcompchmodcmd="$chmodprog @DEFAULT_INSTALL_MODE@"
  chmodcmd="$chmodprog @DEFAULT_INSTALL_MODE@"
  chowncmd=""

 Thanks,
  - Tim

 p.s. this fixes install of scmgit-base on solaris and others that use
 install_sh too.

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/42976: "install-sh" makes still required "-c" option
Date: Mon, 11 Oct 2010 03:04:49 +0000

 From: Tim Zingelman <tez@netbsd.org>
 To: pkgsrc-changes@NetBSD.org
 Subject: CVS commit: pkgsrc/sysutils/install-sh
 Date: Fri, 8 Oct 2010 19:57:05 +0000

 Module Name:	pkgsrc
 Committed By:	tez
 Date:		Fri Oct  8 19:57:05 UTC 2010

 Modified Files:
 	pkgsrc/sysutils/install-sh: Makefile
 	pkgsrc/sysutils/install-sh/files: install-sh.in

 Log Message:
 Make -c (copy) the default operation (vs. move) to come in line with other
 install tools this is built to emulate.  This should fix at least:
 pkg/42976
 pkg/43951


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 pkgsrc/sysutils/install-sh/Makefile
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/sysutils/install-sh/files/install-sh.in

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 11 Oct 2010 04:30:56 +0000
State-Changed-Why:
fixed


>Unformatted:

Home	PR Database Search