NetBSD Problem Report #43079

From www@NetBSD.org  Tue Mar 30 04:31:36 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 6413A63B86C
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 30 Mar 2010 04:31:36 +0000 (UTC)
Message-Id: <20100330043136.0178B63B11D@www.NetBSD.org>
Date: Tue, 30 Mar 2010 04:31:35 +0000 (UTC)
From: schaecsn@gmx.net
Reply-To: schaecsn@gmx.net
To: gnats-bugs@NetBSD.org
Subject: graphics/xv can't be patched with gnutar
X-Send-Pr-Version: www-1.0

>Number:         43079
>Category:       pkg
>Synopsis:       graphics/xv can't be patched with gnutar
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    linux-pkg-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Mar 30 04:35:00 +0000 2010
>Closed-Date:    Tue Mar 30 10:41:47 +0000 2010
>Last-Modified:  Tue Mar 30 10:41:47 +0000 2010
>Originator:     Stefan
>Release:        
>Organization:
>Environment:
Linux vaio 2.6.29.6 #2 Mon Dec 7 17:31:46 CST 2009 i686 Intel(R) Pentium(R) 4 CPU 2.80GHz GenuineIntel GNU/Linux

>Description:
Makefile in graphics/xv from pkgsrc-2009Q4 does not extract patches on Linux


# bmake patch
:
:

=> Applying distribution patches for xv-3.10anb14
/bin/tar: Pattern matching characters used in file names. Please,
/bin/tar: use --wildcards to enable pattern matching, or --no-wildcards to
/bin/tar: suppress this warning.
/bin/tar: *-patch-*: Not found in archive
/bin/tar: Exiting with failure status due to previous errors
=> Applying pkgsrc patches for xv-3.10anb14
1 out of 1 hunk FAILED -- saving rejects to file vdcomp.c.rej
Patch /usr/pkgsrc/graphics/xv/patches/patch-ab failed
1 out of 1 hunk FAILED -- saving rejects to file config.h.rej
Patch /usr/pkgsrc/graphics/xv/patches/patch-ac failed
1 out of 4 hunks FAILED -- saving rejects to file Imakefile.rej
Patch /usr/pkgsrc/graphics/xv/patches/patch-ad failed
4 out of 4 hunks FAILED -- saving rejects to file xv.h.rej
Patch /usr/pkgsrc/graphics/xv/patches/patch-af failed
ERROR: Patching failed due to modified or broken patch file(s):
ERROR:  /usr/pkgsrc/graphics/xv/patches/patch-ab
ERROR:  /usr/pkgsrc/graphics/xv/patches/patch-ac
ERROR:  /usr/pkgsrc/graphics/xv/patches/patch-ad
ERROR:  /usr/pkgsrc/graphics/xv/patches/patch-af

Linux comes with gnutar in /bin/tar. For gnutar, option --wildcards must be added in Makefile

--- snip ----------------------------------------------------------------------
PATCH_DIST_CAT=		${GZCAT} $$patchfile | ${TAR} --wildcards  -Oxf - "*-patch-*"
--- snip ----------------------------------------------------------------------

This option does not work with bsdtar, though.


Alternatively, make a dependency on bsdtar (archive/bsdtar)?
>How-To-Repeat:
bmake patch
>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->linux-pkg-people
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Tue, 30 Mar 2010 08:41:12 +0000
Responsible-Changed-Why:
Linux specific problem?


From: Stefan Schaeckeler <schaecsn@gmx.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/43079 (graphics/xv can't be patched with gnutar)
Date: Tue, 30 Mar 2010 02:18:55 -0700 (PDT)

 > From: wiz@NetBSD.org
 > 
 > Synopsis: graphics/xv can't be patched with gnutar
 > 
 > Responsible-Changed-From-To: pkg-manager->linux-pkg-people
 > Responsible-Changed-By: wiz@NetBSD.org
 > Responsible-Changed-When: Tue, 30 Mar 2010 08:41:12 +0000
 > Responsible-Changed-Why:

 > Linux specific problem?

 Yes (also a problem for Solaris and other systems that don't use bsdtar under /bin).

State-Changed-From-To: open->feedback
State-Changed-By: obache@NetBSD.org
State-Changed-When: Tue, 30 Mar 2010 09:52:28 +0000
State-Changed-Why:
should be fixed in pkgsrc-current.


From: OBATA Akio <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/43079 CVS commit: pkgsrc/graphics/xv
Date: Tue, 30 Mar 2010 09:51:30 +0000

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Tue Mar 30 09:51:30 UTC 2010

 Modified Files:
 	pkgsrc/graphics/xv: Makefile

 Log Message:
 The patch file in jumbo-patches is extracted in ${WRKDIR}, use it for patch,
 to avoid wildcards for tar portability issue reported in PR#43079.


 To generate a diff of this commit:
 cvs rdiff -u -r1.79 -r1.80 pkgsrc/graphics/xv/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Stefan Schaeckeler <schaecsn@gmx.net>
To: gnats-bugs@NetBSD.org
Cc: 	linux-pkg-people@netbsd.org,pkgsrc-bugs@netbsd.org,gnats-admin@netbsd.org,obache@NetBSD.org
Subject: Re: pkg/43079 (graphics/xv can't be patched with gnutar)
Date: Tue, 30 Mar 2010 03:22:34 -0700 (PDT)

 > From: obache@NetBSD.org
 > 
 > Synopsis: graphics/xv can't be patched with gnutar
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: obache@NetBSD.org
 > State-Changed-When: Tue, 30 Mar 2010 09:52:28 +0000
 > State-Changed-Why:

 > should be fixed in pkgsrc-current.

 Patches now nicely on Linux.

 Stefan

State-Changed-From-To: feedback->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Tue, 30 Mar 2010 10:41:47 +0000
State-Changed-Why:
confirmed fixed.  Thanks!


>Unformatted:

Home	PR Database Search