NetBSD Problem Report #43113
From www@NetBSD.org Sun Apr 4 14:30:58 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by www.NetBSD.org (Postfix) with ESMTP id 8711263B86C
for <gnats-bugs@gnats.NetBSD.org>; Sun, 4 Apr 2010 14:30:58 +0000 (UTC)
Message-Id: <20100404143058.3BA5D63B11D@www.NetBSD.org>
Date: Sun, 4 Apr 2010 14:30:58 +0000 (UTC)
From: polachok@gmail.com
Reply-To: polachok@gmail.com
To: gnats-bugs@NetBSD.org
Subject: misc/fbreader incorrect patch (maybe?)
X-Send-Pr-Version: www-1.0
>Number: 43113
>Category: pkg
>Synopsis: misc/fbreader incorrect patch (maybe?)
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: pkg-manager
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Sun Apr 04 14:35:00 +0000 2010
>Closed-Date: Mon Apr 05 18:51:07 +0000 2010
>Last-Modified: Mon Apr 05 18:55:01 +0000 2010
>Originator: Alexander Polakov
>Release: n/a
>Organization:
>Environment:
DragonFly noisy 2.7-DEVELOPMENT DragonFly v2.7.0.45.g5d6a9-DEVELOPMENT #16: Fri Apr 2 23:54:49 MSD 2010 polachok@noisy:/usr/obj/usr/src/sys/XEON i386
>Description:
I think patches/patch-ad is incorrect.
#ifdef DO_ICONV_CAST
iconv(myIConverter, (const char**)&in, &inSize, &out, &outSize);
#else // DO_ICONV_CAST
- iconv(myIConverter, &in, &inSize, &out, &outSize);
+ iconv(myIConverter, (const char **)&in, &inSize, &out, &outSize);
#endif // DO_ICONV_CAST
See? Now the code with #ifdef and without is the same, which it is not meant to be (I think).
>How-To-Repeat:
build fbreader on dragonfly.
>Fix:
Remove patches/patch-ad, everything builds fine.
>Release-Note:
>Audit-Trail:
From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: pkg/43113: misc/fbreader incorrect patch (maybe?)
Date: Mon, 05 Apr 2010 13:52:20 +0900
On Sun, 04 Apr 2010 23:35:00 +0900, <polachok@gmail.com> wrote:
> I think patches/patch-ad is incorrect.
>
> #ifdef DO_ICONV_CAST
> iconv(myIConverter, (const char**)&in, &inSize, &out, &outSize);
> #else // DO_ICONV_CAST
> - iconv(myIConverter, &in, &inSize, &out, &outSize);
> + iconv(myIConverter, (const char **)&in, &inSize, &out, &outSize);
> #endif // DO_ICONV_CAST
>
> See? Now the code with #ifdef and without is the same, which it is not meant to be (I think).
Probably, instead of the patch, DO_ICONV_CAST should be defined on
certain platforms (NetBSD and Solaris?).
State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Mon, 05 Apr 2010 18:51:07 +0000
State-Changed-Why:
Fixed, thanks.
From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/43113 CVS commit: pkgsrc/misc/fbreader
Date: Mon, 5 Apr 2010 18:50:48 +0000
Module Name: pkgsrc
Committed By: wiz
Date: Mon Apr 5 18:50:48 UTC 2010
Modified Files:
pkgsrc/misc/fbreader: Makefile distinfo
pkgsrc/misc/fbreader/patches: patch-ai
Removed Files:
pkgsrc/misc/fbreader/patches: patch-ad
Log Message:
Pass in DO_ICONV_CAST on Solaris and NetBSD instead of incorrect
patch. Noted by Alexander Polakov in PR 43113.
To generate a diff of this commit:
cvs rdiff -u -r1.7 -r1.8 pkgsrc/misc/fbreader/Makefile
cvs rdiff -u -r1.2 -r1.3 pkgsrc/misc/fbreader/distinfo
cvs rdiff -u -r1.1.1.1 -r0 pkgsrc/misc/fbreader/patches/patch-ad
cvs rdiff -u -r1.1.1.1 -r1.2 pkgsrc/misc/fbreader/patches/patch-ai
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.