NetBSD Problem Report #43140

From www@NetBSD.org  Thu Apr  8 13:45:24 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 64AEC63C479
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  8 Apr 2010 13:45:24 +0000 (UTC)
Message-Id: <20100408134524.2F00E63BA59@www.NetBSD.org>
Date: Thu,  8 Apr 2010 13:45:24 +0000 (UTC)
From: joern.clausen@uni-bielefeld.de
Reply-To: joern.clausen@uni-bielefeld.de
To: gnats-bugs@NetBSD.org
Subject: benchmarks/bonnie++ does not compile on Solaris
X-Send-Pr-Version: www-1.0

>Number:         43140
>Category:       pkg
>Synopsis:       benchmarks/bonnie++ does not compile on Solaris
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 08 13:50:00 +0000 2010
>Closed-Date:    Mon Jan 03 14:09:02 +0000 2011
>Last-Modified:  Mon Jan 03 14:09:02 +0000 2011
>Originator:     Jörn Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
>Description:
bonnie++-1.03e does not compile on Solaris:

g++ -O2  -DNDEBUG -Wall -W -Wshadow -Wpointer-arith -Wwrite-strings -pedantic -ffor-scope   -c bon_io.cpp
bon_io.cpp: In member function `int CFileOp::m_open(const char*, int, bool)':
bon_io.cpp:398: error: `O_DIRECT' was not declared in this scope
bon_io.cpp:398: warning: unused variable 'O_DIRECT'

This has been documented in the author's blog for more than a year now, so an upstream fix seems improbable:

http://etbe.coker.com.au/2008/12/10/new-version-of-bonnie-and-violin-memory/#comments
>How-To-Repeat:

>Fix:
This is a very superficial patch, as the command line option for direct IO is simply ignored on Suns:

--- /software/pkgsrc/source/local/bonnie++-1.03e/bon_io.cpp     Fri Sep 26 05:19:38 2008
+++ work.spare4200/bonnie++-1.03e/bon_io.cpp    Thu Apr  8 15:38:21 2010
@@ -393,6 +393,8 @@
     createFlag = OPEN_ACTION_CREATE_IF_NEW | OPEN_ACTION_REPLACE_IF_EXISTS;
 #else
     flags = O_RDWR | O_CREAT | O_EXCL;
+#endif
+#ifndef sun
     if(m_use_direct_io)
     {
       flags |= O_DIRECT;

I haven't investigated the development branch, but the changelog for 1.96 mentions a fix for Solaris as well:

http://etbe.coker.com.au/2009/07/05/released-bonnie-1-96/

>Release-Note:

>Audit-Trail:
From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: PR/43140 CVS commit: pkgsrc/benchmarks/bonnie++
Date: Mon, 03 Jan 2011 10:04:06 +0900

 From: "Jaromir Dolecek" <jdolecek@netbsd.org>
 To: pkgsrc-changes@netbsd.org
 Cc:
 Subject: CVS commit: pkgsrc/benchmarks/bonnie++
 Date: Mon, 03 Jan 2011 02:45:07 +0900

 Module Name:	pkgsrc
 Committed By:	jdolecek
 Date:		Sun Jan  2 17:45:06 UTC 2011

 Modified Files:
 	pkgsrc/benchmarks/bonnie++: Makefile distinfo
 Added Files:
 	pkgsrc/benchmarks/bonnie++/patches: patch-ac patch-ad

 Log Message:
 make compile on systems without O_DIRECT (i.e. Mac OS 10.6)


 To generate a diff of this commit:
 cvs rdiff -u -r1.24 -r1.25 pkgsrc/benchmarks/bonnie++/Makefile
 cvs rdiff -u -r1.8 -r1.9 pkgsrc/benchmarks/bonnie++/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/benchmarks/bonnie++/patches/patch-ac \
      pkgsrc/benchmarks/bonnie++/patches/patch-ad

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: obache@NetBSD.org
State-Changed-When: Mon, 03 Jan 2011 01:06:08 +0000
State-Changed-Why:
fixed?


From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: gnats-bugs@NetBSD.org
Cc: obache@NetBSD.org, pkg-manager@NetBSD.org, pkgsrc-bugs@NetBSD.org,
 gnats-admin@NetBSD.org
Subject: Re: pkg/43140 (benchmarks/bonnie++ does not compile on Solaris)
Date: Mon, 03 Jan 2011 14:04:31 +0100

 bonnie++ now compiles out of the box again on Solaris 10.

 Thanks!

 -- 
   Jörn Clausen                             joern.clausen@uni-bielefeld.de
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld

State-Changed-From-To: feedback->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Mon, 03 Jan 2011 14:09:02 +0000
State-Changed-Why:
confirmed fixed.  thanks!


>Unformatted:

Home	PR Database Search