NetBSD Problem Report #43209

From jwodder@sdf.lonestar.org  Sun Apr 25 18:43:38 2010
Return-Path: <jwodder@sdf.lonestar.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 7304663BA59
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 25 Apr 2010 18:43:38 +0000 (UTC)
Message-Id: <201004251843.o3PIhaC9009101@sdf.lonestar.org>
Date: Sun, 25 Apr 2010 18:43:36 GMT
From: jwodder@sdf.lonestar.org
Reply-To: jwodder@sdf.lonestar.org
To: gnats-bugs@gnats.NetBSD.org
Subject: misc/ttyrec gives "Out of pty's" error
X-Send-Pr-Version: 3.95

>Number:         43209
>Category:       pkg
>Synopsis:       misc/ttyrec gives "Out of pty's" error
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    leot
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 25 18:45:00 +0000 2010
>Closed-Date:    Tue May 31 08:18:22 +0000 2016
>Last-Modified:  Tue May 31 08:20:00 +0000 2016
>Originator:     jwodder@sdf.lonestar.org
>Release:        NetBSD 4.0.1_PATCH
>Organization:

>Environment:
 System: NetBSD sverige 4.0.1_PATCH NetBSD 4.0.1_PATCH (SDF.amd64) #0: Fri Apr 16 05:47:16 UTC 2010 root@mx:/var/src/sys/arch/amd64/compile/SDF.amd64 amd64
 Architecture: x86_64
 Machine: amd64
>Description:
     Due (I believe) to the change in naming conventions for ptys on NetBSD 4.0,
     ttyrec 1.0.8 no longer runs properly (giving an "Out of pty's" error) when
     built from the developer's source without modification, and the version in
     pkgsrc does not appear to address this problem.  I've made a patch that
     should allow it to build & run properly on NetBSD 4.0 using the openpty(3)
     function.
>How-To-Repeat:
 	Compile misc/ttyrec from source and run "ttyrec"
>Fix:

 diff -Naur ttyrec-1.0.8/Makefile ttyrec-1.0.8-sdf/Makefile
 --- ttyrec-1.0.8/Makefile	2006-06-11 15:52:50.000000000 +0000
 +++ ttyrec-1.0.8-sdf/Makefile	2010-01-09 17:22:26.000000000 +0000
 @@ -1,5 +1,5 @@
  CC = gcc
 -CFLAGS = -O2
 +CFLAGS = -O2 -DHAVE_openpty
  VERSION = 1.0.8

  TARGET = ttyrec ttyplay ttytime
 @@ -10,7 +10,7 @@
  all: $(TARGET)

  ttyrec: ttyrec.o io.o
 -	$(CC) $(CFLAGS) -o ttyrec ttyrec.o io.o
 +	$(CC) $(CFLAGS) -o ttyrec ttyrec.o io.o -lutil

  ttyplay: ttyplay.o io.o
  	$(CC) $(CFLAGS) -o ttyplay ttyplay.o io.o
 diff -Naur ttyrec-1.0.8/ttyrec.c ttyrec-1.0.8-sdf/ttyrec.c
 --- ttyrec-1.0.8/ttyrec.c	2006-06-11 15:52:50.000000000 +0000
 +++ ttyrec-1.0.8-sdf/ttyrec.c	2010-01-09 17:21:38.000000000 +0000
 @@ -71,7 +71,7 @@
  #define _(FOO) FOO

  #ifdef HAVE_openpty
 -#include <libutil.h>
 +#include <util.h>
  #endif

  #if defined(SVR4) && !defined(CDEL)

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: gnats-admin->pkg-manager
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Tue, 27 Apr 2010 20:05:33 +0000
Responsible-Changed-Why:
Patch up mangled PR.


Responsible-Changed-From-To: pkg-manager->leot
Responsible-Changed-By: leot@NetBSD.org
Responsible-Changed-When: Tue, 31 May 2016 08:18:22 +0000
Responsible-Changed-Why:
Take.


State-Changed-From-To: open->closed
State-Changed-By: leot@NetBSD.org
State-Changed-When: Tue, 31 May 2016 08:18:22 +0000
State-Changed-Why:
I've fixed it reworking your patches a bit.

Thank you jwodder for the PR (and the patience)!


From: "Leonardo Taccari" <leot@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/43209 CVS commit: pkgsrc/misc/ttyrec
Date: Tue, 31 May 2016 08:13:46 +0000

 Module Name:	pkgsrc
 Committed By:	leot
 Date:		Tue May 31 08:13:46 UTC 2016

 Modified Files:
 	pkgsrc/misc/ttyrec: Makefile distinfo
 	pkgsrc/misc/ttyrec/patches: patch-aa patch-ttyrec.c
 Added Files:
 	pkgsrc/misc/ttyrec/patches: patch-io.h

 Log Message:
 Fix ttyrec "Out of pty's" error.

 Reported by jwodder via PR pkg/43209 (patch similar in spirit but it's a bit
 less intrusive).


 To generate a diff of this commit:
 cvs rdiff -u -r1.14 -r1.15 pkgsrc/misc/ttyrec/Makefile
 cvs rdiff -u -r1.6 -r1.7 pkgsrc/misc/ttyrec/distinfo
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/misc/ttyrec/patches/patch-aa
 cvs rdiff -u -r0 -r1.1 pkgsrc/misc/ttyrec/patches/patch-io.h
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/misc/ttyrec/patches/patch-ttyrec.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search