NetBSD Problem Report #43259

From www@NetBSD.org  Wed May  5 14:35:55 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id D9E3763C53A
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  5 May 2010 14:35:54 +0000 (UTC)
Message-Id: <20100505143554.6D17763B8FE@www.NetBSD.org>
Date: Wed,  5 May 2010 14:35:54 +0000 (UTC)
From: xtraeme@gmail.com
Reply-To: xtraeme@gmail.com
To: gnats-bugs@NetBSD.org
Subject: security/netpgp: libnetpgp.3 doesn't match the sources
X-Send-Pr-Version: www-1.0

>Number:         43259
>Category:       lib
>Synopsis:       security/netpgp: libnetpgp.3 doesn't match the sources
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    agc
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed May 05 14:40:05 +0000 2010
>Closed-Date:    Fri May 07 16:30:18 +0000 2010
>Last-Modified:  Fri May 07 16:35:01 +0000 2010
>Originator:     Juan RP
>Release:        NULL
>Organization:
>Environment:
>Description:
libnetpgp.3 shows a wrong prototype and description for netpgp_init().

It would be nice to explain which options can be set via netpgp_setvar(), or received via netpgp_getvar() as well.
>How-To-Repeat:

>Fix:
--- src/lib/libnetpgp.3.orig	2010-05-05 16:20:23.884817816 +0200
+++ src/lib/libnetpgp.3	2010-05-05 16:24:13.922823314 +0200
@@ -27,7 +27,7 @@
 .\" ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 .\" POSSIBILITY OF SUCH DAMAGE.
 .\"
-.Dd March 13, 2010
+.Dd May 5, 2010
 .Dt LIBNETPGP 3
 .Os
 .Sh NAME
@@ -41,7 +41,7 @@
 The following functions relate to initialisations and finalisations:
 .Ft int
 .Fo netpgp_init
-.Fa "netpgp_t *netpgp" "char *userid" "char *pubringfile" "char *secringfile"
+.Fa "netpgp_t *netpgp"
 .Fc
 .Ft int
 .Fo netpgp_end
@@ -175,12 +175,14 @@ process be initialised using the
 function, which will set up the public and private keyrings, and set the
 user identity to the
 .Ar userid
-argument passed to the function.
-If no public key ring file is provided, initial values will be taken from those
+argument passed in via the
+.Fn netpgp_setvar
+function.
+If no public key ring file is set, initial values will be taken from those
 in the
 .Pa .gnupg/pubring.gpg
 file in the user's home directory.
-Similarily, if no secret key ring file is provided,
+Similarily, if no secret key ring file is set,
 initial values will be taken from those
 in the
 .Pa .gnupg/secring.gpg

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: lib-bug-people->agc
Responsible-Changed-By: agc@NetBSD.org
Responsible-Changed-When: Fri, 07 May 2010 16:30:18 +0000
Responsible-Changed-Why:
netpgp is my responsibility


State-Changed-From-To: open->closed
State-Changed-By: agc@NetBSD.org
State-Changed-When: Fri, 07 May 2010 16:30:18 +0000
State-Changed-Why:
applied the patch in the PR - thanks for that!


From: "Alistair G. Crooks" <agc@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/43259 CVS commit: src/crypto/external/bsd/netpgp/dist/src/lib
Date: Fri, 7 May 2010 16:29:09 +0000

 Module Name:	src
 Committed By:	agc
 Date:		Fri May  7 16:29:09 UTC 2010

 Modified Files:
 	src/crypto/external/bsd/netpgp/dist/src/lib: libnetpgp.3

 Log Message:
 Sync with reality using patch provided by Juan RP in PR 43259. Thanks!


 To generate a diff of this commit:
 cvs rdiff -u -r1.12 -r1.13 \
     src/crypto/external/bsd/netpgp/dist/src/lib/libnetpgp.3

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search