NetBSD Problem Report #43376

From Wolfgang.Stukenbrock@nagler-company.com  Fri May 28 12:37:36 2010
Return-Path: <Wolfgang.Stukenbrock@nagler-company.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id CAD2063B873
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 28 May 2010 12:37:35 +0000 (UTC)
Message-Id: <20100528123730.5D1961E80CE@test-s0.nagler-company.com>
Date: Fri, 28 May 2010 14:37:30 +0200 (CEST)
From: Wolfgang.Stukenbrock@nagler-company.com
Reply-To: Wolfgang.Stukenbrock@nagler-company.com
To: gnats-bugs@gnats.NetBSD.org
Subject: linux32-compat failed to compile in kernel without SYSVSEM and SYSCSHM
X-Send-Pr-Version: 3.95

>Number:         43376
>Category:       kern
>Synopsis:       linux32-compat failed to compile in kernel without SYSVSEM and SYSCSHM
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    dholland
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 28 12:40:00 +0000 2010
>Closed-Date:    Sat Dec 19 02:29:01 +0000 2015
>Last-Modified:  Sat Dec 19 02:29:01 +0000 2015
>Originator:     Dr. Wolfgang Stukenbrock
>Release:        NetBSD 5.0.2
>Organization:
Dr. Nagler & Company GmbH

>Environment:


System: NetBSD test-s0 4.0 NetBSD 4.0 (NSW-WS) #2: Fri Nov 6 11:14:49 CET 2009 wgstuken@s012:/export/NetBSD-4.0/N+C-build/.OBJDIR_amd64/export/NetBSD-4.0/src/sys/arch/amd64/compile/NSW-WS amd64
Architecture: x86_64
Machine: amd64
>Description:
	The kernel compilation fails with "bsd_to_linux32_ipc_perm() defined but not used" message,
	if linux32-compat is configured but no SYSV-SHM and SYSV-SEM.
	The problems is located in the file /usrsrc/sys/compat/linux32/common/linux32_ipccall.c.
>How-To-Repeat:
	Setup a kernel configuration without SYSV-IPC but linux32-compat and try to compile it.
>Fix:
	The following patch solves the problem:

--- linux32_ipccall.c	2010/05/18 13:01:21	1.1
+++ linux32_ipccall.c	2010/05/18 15:52:46
@@ -136,6 +136,7 @@

 }

+#if defined(SYSVSEM) || defined(SYSVSHM)
 static void
 bsd_to_linux32_ipc_perm(struct ipc_perm *bpp, struct linux32_ipc_perm *lpp)
 {
@@ -183,6 +184,7 @@
 	bpp->mode = lpp->l_mode;
 	bpp->_seq = lpp->l_seq;
 }
+#endif

 #ifdef SYSVSEM
 static void

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/43376 CVS commit: src/sys/compat/linux32/common
Date: Sat, 29 May 2010 18:55:35 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Sat May 29 18:55:35 UTC 2010

 Modified Files:
 	src/sys/compat/linux32/common: linux32_ipccall.c

 Log Message:
 Fix build without sysvipc configured, from Wolfgang Stukenbrock in PR 43376,
 adjusted for current.


 To generate a diff of this commit:
 cvs rdiff -u -r1.10 -r1.11 src/sys/compat/linux32/common/linux32_ipccall.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 30 May 2010 01:25:03 +0000
State-Changed-Why:
Fixed in HEAD; do you want it on the -5 branch? It won't go into 5.0.x
(that's security fixes only) and it's almost certainly too late to make
5.1 too...


From: Wolfgang Stukenbrock <Wolfgang.Stukenbrock@nagler-company.com>
To: gnats-bugs@NetBSD.org
Cc: Wolfgang.Stukenbrock@nagler-company.com, dholland@NetBSD.org
Subject: Re: kern/43376: linux32-compat failed to compile in kernel without SYSVSEM and SYSCSHM
Date: Mon, 14 Jun 2010 15:07:21 +0200

 Hi - sorry for the delay ..

 For me it is fine if the patcht gets into the distribution even when it 
 is 5.2 or 6 ...
 I've a "local" patch Database here with the changes required to the 
 NetBSD sources to make it working for us. And that one is in there ...
 So I've no problem with that.

 If there is a 5.2 planned, it would be nice to have the fix there, if it 
 doesn't make too much work.

 PS. I've lost the last mail from the bug-tracking system - so I reusesed 
 the initial reply after posting the report.

 W. Stukenbrock

 gnats-admin@NetBSD.org wrote:

 > Thank you very much for your problem report.
 > It has the internal identification `kern/43376'.
 > The individual assigned to look at your
 > report is: kern-bug-people. 
 > 
 > 
 >>Category:       kern
 >>Responsible:    kern-bug-people
 >>Synopsis:       linux32-compat failed to compile in kernel without SYSVSEM and SYSCSHM
 >>Arrival-Date:   Fri May 28 12:40:00 +0000 2010
 >>
 > 


Responsible-Changed-From-To: kern-bug-people->dholland
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Tue, 15 Jun 2010 04:39:31 +0000
Responsible-Changed-Why:
I merged the patch


State-Changed-From-To: feedback->analyzed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Tue, 15 Jun 2010 04:39:31 +0000
State-Changed-Why:
I will file a -5 pullup at some point when I get to it.
(It requires a different patch from HEAD so it isn't completely trivial)


State-Changed-From-To: analyzed->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 19 Dec 2015 02:29:01 +0000
State-Changed-Why:
never got to it, and -5 is now EOL


>Unformatted:

Home	PR Database Search