NetBSD Problem Report #43401

From jukka+moray@salmi.ch  Tue Jun  1 16:12:14 2010
Return-Path: <jukka+moray@salmi.ch>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 7860263B8CF
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  1 Jun 2010 16:12:14 +0000 (UTC)
Message-Id: <20100601161211.353B952DD@moray.salmi.ch>
Date: Tue,  1 Jun 2010 18:12:11 +0200 (CEST)
From: Jukka Salmi <j+nbsd@salmi.ch>
Reply-To: Jukka Salmi <j+nbsd@salmi.ch>
To: gnats-bugs@gnats.NetBSD.org
Subject: typo in sdpd rc.d script
X-Send-Pr-Version: 3.95

>Number:         43401
>Category:       misc
>Synopsis:       typo in sdpd rc.d script
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jun 01 16:15:00 +0000 2010
>Closed-Date:    Tue Jun 01 21:09:39 +0000 2010
>Last-Modified:  Tue Jun 01 21:10:04 +0000 2010
>Originator:     Jukka Salmi
>Release:        NetBSD-current and earlier ;-)
>Organization:
>Environment:
System: NetBSD moray.salmi.ch 5.0_STABLE NetBSD 5.0_STABLE (MORAY) #0: Mon Feb 1 20:39:41 CET 2010 root@moray.salmi.ch:/b/build/nbsd/5/i386/sys/arch/i386/compile/MORAY i386
Architecture: i386
Machine: i386
>Description:
Typo in etc/rc.d/sdpd: $_rc_subr_loaded is missing its leading underscore.
This causes rc.subr to be sourced unconditionally.
>How-To-Repeat:
n/a
>Fix:
The following patch is also available from
http://salmi.ch/~jukka/patches/NetBSD/src/HEAD/etc/rc.d/sdpd.patch

Index: etc/rc.d/sdpd
===================================================================
RCS file: /cvsroot/src/etc/rc.d/sdpd,v
retrieving revision 1.2
diff -u -p -r1.2 sdpd
--- etc/rc.d/sdpd	18 Mar 2007 15:53:54 -0000	1.2
+++ etc/rc.d/sdpd	1 Jun 2010 16:02:26 -0000
@@ -7,7 +7,7 @@
 # REQUIRE: bluetooth
 # BEFORE: LOGIN

-$rc_subr_loaded . /etc/rc.subr
+$_rc_subr_loaded . /etc/rc.subr

 name="sdpd"
 rcvar=$name

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Tue, 01 Jun 2010 21:09:39 +0000
State-Changed-Why:
Fixed, thanks.
(When replying to gnats, make sure to use (only) gnats-bugs@NetBSD.org.)


From: Thomas Klausner <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/43401 CVS commit: src/etc/rc.d
Date: Tue, 1 Jun 2010 21:08:13 +0000

 Module Name:	src
 Committed By:	wiz
 Date:		Tue Jun  1 21:08:13 UTC 2010

 Modified Files:
 	src/etc/rc.d: bthcid sdpd

 Log Message:
 Fix typo in sdpd, reported by Jukka Salmi in PR 43401.
 This also affected bthcid, so I also fixed it there.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/etc/rc.d/bthcid
 cvs rdiff -u -r1.2 -r1.3 src/etc/rc.d/sdpd

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search