NetBSD Problem Report #43466

From www@NetBSD.org  Sun Jun 13 12:29:49 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 1BD3A63B93E
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 13 Jun 2010 12:29:49 +0000 (UTC)
Message-Id: <20100613122948.E048363B91E@www.NetBSD.org>
Date: Sun, 13 Jun 2010 12:29:48 +0000 (UTC)
From: arun.thomas@gmail.com
Reply-To: arun.thomas@gmail.com
To: gnats-bugs@NetBSD.org
Subject: make(1): Makefile.boot is missing a source file (Patch included)
X-Send-Pr-Version: www-1.0

>Number:         43466
>Category:       bin
>Synopsis:       make(1): Makefile.boot is missing a source file (Patch included)
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jun 13 12:30:00 +0000 2010
>Closed-Date:    Sat Mar 26 21:49:30 +0000 2011
>Last-Modified:  Sat Mar 26 21:49:30 +0000 2011
>Originator:     Arun Thomas
>Release:        5.0
>Organization:
>Environment:
Linux, Minix
>Description:
When attempting to build NetBSD's make(1) on non-NetBSD platforms, the build will fail. Cause: The bootstrap Makefile for non-NetBSD platforms (Makefile.boot) is missing a source file in its SRCS variable. When you add lst.lib/lstPrev.c, make(1) builds correctly.

I have included a patch that fixes the problem.
>How-To-Repeat:
Run 'make -f Makefile.boot' in src/usr.bin/make on a non-NetBSD platform.
>Fix:
Add lst.lib/lstPrev.c to SRCS in src/usr.bin/make/Makefile.boot.

Patch below:


diff -urN src.orig/usr.bin/make/Makefile.boot src/usr.bin/make/Makefile.boot
--- src.orig/usr.bin/make/Makefile.boot	2010-06-13 01:44:54.000000000 +0200
+++ src/usr.bin/make/Makefile.boot	2010-06-13 01:53:40.000000000 +0200
@@ -32,7 +32,7 @@
 	lst.lib/lstInit.o lst.lib/lstInsert.o lst.lib/lstIsAtEnd.o \
 	lst.lib/lstIsEmpty.o lst.lib/lstLast.o lst.lib/lstMember.o \
 	lst.lib/lstNext.o lst.lib/lstOpen.o lst.lib/lstRemove.o \
-	lst.lib/lstReplace.o lst.lib/lstSucc.o
+	lst.lib/lstReplace.o lst.lib/lstSucc.o lst.lib/lstPrev.c

 bmake: ${OBJ} ${LIBOBJ}
 #	@echo 'make of make and make.0 started.'

>Release-Note:

>Audit-Trail:
From: Arun Thomas <arun.thomas@gmail.com>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: bin/43466: make(1): Makefile.boot is missing a source file (Patch
 included)
Date: Sun, 13 Jun 2010 14:40:42 +0200

 This is a multi-part message in MIME format.
 --------------040200010302070207090406
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit

 I'm sending the patch as an attachment in case that works better. The 
 patch should apply cleanly to CVS HEAD (Makefile.boot r1.19)

 Best,
 Arun

 --------------040200010302070207090406
 Content-Type: text/x-patch;
  name="make.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="make.diff"

 Index: usr.bin/make/Makefile.boot
 ===================================================================
 RCS file: /cvsroot/src/usr.bin/make/Makefile.boot,v
 retrieving revision 1.19
 diff -u -r1.19 Makefile.boot
 --- usr.bin/make/Makefile.boot	24 Jan 2009 11:59:39 -0000	1.19
 +++ usr.bin/make/Makefile.boot	13 Jun 2010 00:01:56 -0000
 @@ -32,7 +32,7 @@
  	lst.lib/lstInit.o lst.lib/lstInsert.o lst.lib/lstIsAtEnd.o \
  	lst.lib/lstIsEmpty.o lst.lib/lstLast.o lst.lib/lstMember.o \
  	lst.lib/lstNext.o lst.lib/lstOpen.o lst.lib/lstRemove.o \
 -	lst.lib/lstReplace.o lst.lib/lstSucc.o
 +	lst.lib/lstReplace.o lst.lib/lstSucc.o lst.lib/lstPrev.c

  bmake: ${OBJ} ${LIBOBJ}
  #	@echo 'make of make and make.0 started.'

 --------------040200010302070207090406--

From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/43466 CVS commit: src/usr.bin/make
Date: Sat, 26 Mar 2011 21:42:12 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Sat Mar 26 21:42:12 UTC 2011

 Modified Files:
 	src/usr.bin/make: Makefile.boot

 Log Message:
 Catch up to Makefile rev 1.40 (from 2006): add lstPrev.o. Closes PR 43466.


 To generate a diff of this commit:
 cvs rdiff -u -r1.19 -r1.20 src/usr.bin/make/Makefile.boot

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 26 Mar 2011 21:49:30 +0000
State-Changed-Why:
Fixed, thanks.


>Unformatted:

Home	PR Database Search