NetBSD Problem Report #43520

From tsutsui@ceres.dti.ne.jp  Fri Jun 25 16:34:27 2010
Return-Path: <tsutsui@ceres.dti.ne.jp>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id F38BF63BA62
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 25 Jun 2010 16:34:26 +0000 (UTC)
Message-Id: <201006251634.o5PGYOIE026014@mirage.ceres.dti.ne.jp>
Date: Sat, 26 Jun 2010 01:34:24 +0900 (JST)
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
Reply-To: tsutsui@ceres.dti.ne.jp
To: gnats-bugs@gnats.NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: ral(4) at usb(4) doesn't compile on ports without pci(4)
X-Send-Pr-Version: 3.95

>Number:         43520
>Category:       kern
>Synopsis:       ral(4) at usb(4) doesn't compile on ports without pci(4)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 25 16:35:00 +0000 2010
>Closed-Date:    Fri Jan 04 01:12:13 +0000 2013
>Last-Modified:  Fri Jan 04 01:12:13 +0000 2013
>Originator:     Izumi Tsutsui
>Release:        NetBSD 5.99.30
>Organization:
>Environment:
System: NetBSD mirage 5.99.30 hpcarm on W-ZERO3 WS003SH
Architecture: arm
Machine: hpcarm, but probably affects more ports
>Description:
ral(4) requires MI src/sys/dev/rt2661.c, but it includes <dev/pci/pcidevs.h>
to refer PCI device IDs for ral(4) at pci(4).
The pcidevs.h includes <machine/pci_machpdep.h> which is not provided
on ports that don't have PCI, so ral(4) at usb(4) doesn't compile
on such ports.

>How-To-Repeat:
Configure ral(4) at usb(4) on hpcarm (or other PXA27x based ports
without PCI) and build a kernel.

>Fix:
 - move PCI dependent code from MI source to a bus dependent hook function?
 - define and use ral(4) own IDs instead of IDs from pcidevs.h?

---
Izumi Tsutsui

>Release-Note:

>Audit-Trail:
From: "Jonathan A. Kollasch" <jakllsch@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/43520 CVS commit: src/sys
Date: Sat, 1 Sep 2012 18:17:52 +0000

 Module Name:	src
 Committed By:	jakllsch
 Date:		Sat Sep  1 18:17:51 UTC 2012

 Modified Files:
 	src/sys/arch/amd64/conf: GENERIC XEN3_DOM0
 	src/sys/arch/evbarm/conf: HDL_G HPT5325 MMNET_GENERIC MPCSA_GENERIC
 	    NSLU2 OPENBLOCKS_A6 SHEEVAPLUG
 	src/sys/arch/evbppc/conf: OPENBLOCKS266_OPT
 	src/sys/arch/hp700/conf: GENERIC
 	src/sys/arch/hpcarm/conf: WZERO3
 	src/sys/arch/i386/conf: ALL GENERIC XEN3_DOM0
 	src/sys/arch/iyonix/conf: GENERIC
 	src/sys/arch/landisk/conf: GENERIC
 	src/sys/arch/macppc/conf: GENERIC
 	src/sys/arch/ofppc/conf: GENERIC
 	src/sys/arch/sparc64/conf: GENERIC
 	src/sys/dev/usb: files.usb usbdevices.config

 Log Message:
 Rename RT2500USB driver to ural(4) as it was originally in OpenBSD,
 as ural(4) and ral(4) do not actually share any code.

 Enable ural(4) in hpcarm WZERO3 kernel too, as it will now build.

 Fixes PR#43520.


 To generate a diff of this commit:
 cvs rdiff -u -r1.362 -r1.363 src/sys/arch/amd64/conf/GENERIC
 cvs rdiff -u -r1.85 -r1.86 src/sys/arch/amd64/conf/XEN3_DOM0
 cvs rdiff -u -r1.29 -r1.30 src/sys/arch/evbarm/conf/HDL_G \
     src/sys/arch/evbarm/conf/MPCSA_GENERIC
 cvs rdiff -u -r1.4 -r1.5 src/sys/arch/evbarm/conf/HPT5325 \
     src/sys/arch/evbarm/conf/OPENBLOCKS_A6
 cvs rdiff -u -r1.6 -r1.7 src/sys/arch/evbarm/conf/MMNET_GENERIC
 cvs rdiff -u -r1.25 -r1.26 src/sys/arch/evbarm/conf/NSLU2
 cvs rdiff -u -r1.18 -r1.19 src/sys/arch/evbarm/conf/SHEEVAPLUG
 cvs rdiff -u -r1.16 -r1.17 src/sys/arch/evbppc/conf/OPENBLOCKS266_OPT
 cvs rdiff -u -r1.115 -r1.116 src/sys/arch/hp700/conf/GENERIC
 cvs rdiff -u -r1.26 -r1.27 src/sys/arch/hpcarm/conf/WZERO3
 cvs rdiff -u -r1.342 -r1.343 src/sys/arch/i386/conf/ALL
 cvs rdiff -u -r1.1078 -r1.1079 src/sys/arch/i386/conf/GENERIC
 cvs rdiff -u -r1.67 -r1.68 src/sys/arch/i386/conf/XEN3_DOM0
 cvs rdiff -u -r1.71 -r1.72 src/sys/arch/iyonix/conf/GENERIC
 cvs rdiff -u -r1.31 -r1.32 src/sys/arch/landisk/conf/GENERIC
 cvs rdiff -u -r1.302 -r1.303 src/sys/arch/macppc/conf/GENERIC
 cvs rdiff -u -r1.142 -r1.143 src/sys/arch/ofppc/conf/GENERIC
 cvs rdiff -u -r1.151 -r1.152 src/sys/arch/sparc64/conf/GENERIC
 cvs rdiff -u -r1.124 -r1.125 src/sys/dev/usb/files.usb
 cvs rdiff -u -r1.15 -r1.16 src/sys/dev/usb/usbdevices.config

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Fri, 04 Jan 2013 01:12:13 +0000
State-Changed-Why:
Fixed in September.


>Unformatted:

Home	PR Database Search