NetBSD Problem Report #43644

From www@NetBSD.org  Tue Jul 20 15:15:12 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 145E663BB0A
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 20 Jul 2010 15:15:12 +0000 (UTC)
Message-Id: <20100720151511.DBD2E63BADB@www.NetBSD.org>
Date: Tue, 20 Jul 2010 15:15:11 +0000 (UTC)
From: pooka@iki.fi
Reply-To: pooka@iki.fi
To: gnats-bugs@NetBSD.org
Subject: TESTS_SUBDIR/atf-run interaction is too fragile
X-Send-Pr-Version: www-1.0

>Number:         43644
>Category:       misc
>Synopsis:       TESTS_SUBDIR/atf-run interaction is too fragile
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    misc-bug-people
>State:          analyzed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 20 15:20:00 +0000 2010
>Closed-Date:    
>Last-Modified:  Thu Jul 24 15:03:23 +0000 2014
>Originator:     Antti Kantee
>Release:        
>Organization:
>Environment:
>Description:
Using TESTS_SUBDIR for a subdirectory which contains only supporting
routines and no tests causes atf-run to fail completely.
>How-To-Repeat:
Add new subdir to TESTS_SUBDIR without thinking, observe things break.
>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: misc-bug-people->jmmv
Responsible-Changed-By: pooka@NetBSD.org
Responsible-Changed-When: Tue, 20 Jul 2010 18:23:31 +0300
Responsible-Changed-Why:
go jmmv go! ;)


State-Changed-From-To: open->suspended
State-Changed-By: jmmv@NetBSD.org
State-Changed-When: Tue, 20 Jul 2010 16:44:49 +0000
State-Changed-Why:
This is actually an ATF bug.  Filed ticket #55 upstream.


From: Antti Kantee <pooka@iki.fi>
To: gnats-bugs@NetBSD.org
Cc: jmmv@NetBSD.org
Subject: Re: misc/43644 (TESTS_SUBDIR/atf-run interaction is too fragile)
Date: Wed, 21 Jul 2010 09:46:37 +0300

 On Tue Jul 20 2010 at 16:44:50 +0000, jmmv@NetBSD.org wrote:
 > Synopsis: TESTS_SUBDIR/atf-run interaction is too fragile
 > 
 > State-Changed-From-To: open->suspended
 > State-Changed-By: jmmv@NetBSD.org
 > State-Changed-When: Tue, 20 Jul 2010 16:44:49 +0000
 > State-Changed-Why:
 > This is actually an ATF bug.  Filed ticket #55 upstream.

 TESTS_SUBDIR is NetBSD-only, which is why I filed this here.

 Having TESTS_SUBDIR behave like SUBDIR for non-test subdirs would be
 nice to avoid confusion/bugs.  If that is fixable just by modifying
 atf-run, ok.

From: Julio Merino <jmmv@NetBSD.org>
To: Antti Kantee <pooka@iki.fi>
Cc: gnats-bugs@netbsd.org
Subject: Re: misc/43644 (TESTS_SUBDIR/atf-run interaction is too fragile)
Date: Wed, 21 Jul 2010 10:38:32 +0100

 On Wed, Jul 21, 2010 at 7:46 AM, Antti Kantee <pooka@iki.fi> wrote:
 > On Tue Jul 20 2010 at 16:44:50 +0000, jmmv@NetBSD.org wrote:
 >> Synopsis: TESTS_SUBDIR/atf-run interaction is too fragile
 >>
 >> State-Changed-From-To: open->suspended
 >> State-Changed-By: jmmv@NetBSD.org
 >> State-Changed-When: Tue, 20 Jul 2010 16:44:49 +0000
 >> State-Changed-Why:
 >> This is actually an ATF bug. =A0Filed ticket #55 upstream.
 >
 > TESTS_SUBDIR is NetBSD-only, which is why I filed this here.

 But the atf-run breakage is not.  atf-run should be more resilent to
 missing test programs/directories.  If that was the case, then you
 would have noticed that the "common" test failed, and would have
 corrected the issue later in the Makefile.

 > Having TESTS_SUBDIR behave like SUBDIR for non-test subdirs would be
 > nice to avoid confusion/bugs. =A0If that is fixable just by modifying
 > atf-run, ok.

 That'd be nice.  Or rather, not have TESTS_SUBDIR *at all* and let
 SUBDIR DTRT in all cases.  But how do you figure it out, from a parent
 Makefile, that a particular subdirectory will have tests?  If we can
 *ensure* that the parent directory gets processed *after* its children
 (which I don't know), then we could easily inspect and see if any of
 the subdirectories processed by the parent makefile have an Atffile
 and, in those cases, register them into the parent Atffile.  Sounds
 fragile though...

 --=20
 Julio Merino

State-Changed-From-To: suspended->analyzed
State-Changed-By: jmmv@NetBSD.org
State-Changed-When: Wed, 21 Jul 2010 09:42:11 +0000
State-Changed-Why:
We may be able to do something in NetBSD land.


Responsible-Changed-From-To: jmmv->misc-bug-people
Responsible-Changed-By: jmmv@NetBSD.org
Responsible-Changed-When: Thu, 24 Jul 2014 15:03:23 +0000
Responsible-Changed-Why:


>Unformatted:

Home	PR Database Search