NetBSD Problem Report #43646

From kre@munnari.OZ.AU  Tue Jul 20 18:42:55 2010
Return-Path: <kre@munnari.OZ.AU>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id E6C7A63BADB
	for <gnats-bugs@gnats.NetBSD.org>; Tue, 20 Jul 2010 18:42:54 +0000 (UTC)
Message-Id: <201007201842.o6KIgkqP020472@jade.coe.psu.ac.th>
Date: Wed, 21 Jul 2010 01:42:46 +0700 (ICT)
From: kre@munnari.OZ.AU
To: gnats-bugs@gnats.NetBSD.org
Subject: radeondrm needs firmload (+PATCH)
X-Send-Pr-Version: 3.95

>Number:         43646
>Category:       kern
>Synopsis:       radeondrm needs firmload (+PATCH)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jul 20 18:45:00 +0000 2010
>Closed-Date:    Wed Jul 21 06:12:48 +0000 2010
>Last-Modified:  Wed Jul 21 06:12:48 +0000 2010
>Originator:     Robert Elz
>Release:        NetBSD 5.99.36 (2010-07-20)
>Organization:
	Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 5.1_RC3 NetBSD 5.1_RC3 (JADE-1.12-20100614) #2: Mon Jun 14 08:35:26 ICT 2010 kre@jade.coe.psu.ac.th:/usr/obj/5.1/kernels/JADE i386
Architecture: i386
Machine: i386
>Description:
	The DRM driver for ATI radeon needs the firmload system,
	but the kernel conf files don't cause it to be included.

>How-To-Repeat:
	Build a current kernel using a config where the only driver
	included that needs loadable firmware is the radeon drm, it
	will fail to link with the firmload functions missing, but
	references from radeon_drv.c

>Fix:
	The patch below corrects this for me.

Index: drm/conf/files.drm
===================================================================
RCS file: /cvsroot/NetBSD/src/sys/external/bsd/drm/conf/files.drm,v
retrieving revision 1.4
diff -u -r1.4 files.drm
--- drm/conf/files.drm	6 Jul 2010 16:33:31 -0000	1.4
+++ drm/conf/files.drm	20 Jul 2010 18:20:11 -0000
@@ -87,7 +87,7 @@
 file	external/bsd/drm/dist/shared-core/r128_irq.c		r128drm
 file	external/bsd/drm/dist/shared-core/r128_state.c		r128drm

-device	radeondrm: drmbase, drmpci
+device	radeondrm: drmbase, drmpci, firmload
 attach	radeondrm at drm
 file	external/bsd/drm/dist/bsd-core/radeon_drv.c		radeondrm
 file	external/bsd/drm/dist/shared-core/r300_cmdbuf.c		radeondrm

>Release-Note:

>Audit-Trail:
From: matthew green <mrg@eterna.com.au>
To: kre@munnari.OZ.AU, gnats-bugs@NetBSD.org
Cc: kern-bug-people@netbsd.org, gnats-admin@netbsd.org,
    netbsd-bugs@netbsd.org
Subject: re: kern/43646: radeondrm needs firmload (+PATCH)
Date: Wed, 21 Jul 2010 05:32:40 +1000

 > >Synopsis:       radeondrm needs firmload (+PATCH)

 i'm fairly sure this is already fixed:

 revision 1.4
 date: 2010/07/06 16:33:31;  author: mrg;  state: Exp;  lines: +2 -2
 radeondrm depends upon firmload now; noted by rjs.


 can you confirm your files.drm is updated?  thanks.


 .mrg.

From: Robert Elz <kre@munnari.OZ.AU>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: re: kern/43646: radeondrm needs firmload (+PATCH)
Date: Wed, 21 Jul 2010 02:46:47 +0700 (ICT)

 You mean this diff ...

 diff -r1.3 -r1.4
 1c1
 < #     $NetBSD: files.drm,v 1.2 2009/06/23 04:42:58 mrg Exp $
 ---
 > #     $NetBSD: files.drm,v 1.3 2010/05/24 01:57:06 mrg Exp $
 82c82
 < device        r128drm: drmbase, drmpci
 ---
 > device        r128drm: drmbase, drmpci, firmload

 doesn't look like it fixes the right one to me - that's a similar
 problem for a different driver.

 kre

From: matthew green <mrg@eterna.com.au>
To: gnats-bugs@NetBSD.org
Cc: kern-bug-people@netbsd.org, gnats-admin@netbsd.org,
    netbsd-bugs@netbsd.org, kre@munnari.OZ.AU
Subject: re: kern/43646: radeondrm needs firmload (+PATCH)
Date: Wed, 21 Jul 2010 08:12:36 +1000

 > The following reply was made to PR kern/43646; it has been noted by GNATS.
 > 
 > From: Robert Elz <kre@munnari.OZ.AU>
 > To: gnats-bugs@NetBSD.org
 > Cc: 
 > Subject: re: kern/43646: radeondrm needs firmload (+PATCH)
 > Date: Wed, 21 Jul 2010 02:46:47 +0700 (ICT)
 > 
 >  You mean this diff ...
 >  
 >  diff -r1.3 -r1.4
 >  1c1
 >  < #     $NetBSD: files.drm,v 1.2 2009/06/23 04:42:58 mrg Exp $
 >  ---
 >  > #     $NetBSD: files.drm,v 1.3 2010/05/24 01:57:06 mrg Exp $
 >  82c82
 >  < device        r128drm: drmbase, drmpci
 >  ---
 >  > device        r128drm: drmbase, drmpci, firmload
 >  
 >  doesn't look like it fixes the right one to me - that's a similar
 >  problem for a different driver.


 oh right... i see, sorry.  i'll commit your fix!


 .mrg.

State-Changed-From-To: open->closed
State-Changed-By: mrg@NetBSD.org
State-Changed-When: Wed, 21 Jul 2010 06:12:48 +0000
State-Changed-Why:
i commited the fix; thanks!


>Unformatted:

Home	PR Database Search