NetBSD Problem Report #43687

From ryo_on@yk.rim.or.jp  Fri Jul 30 20:46:20 2010
Return-Path: <ryo_on@yk.rim.or.jp>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 2950463BB39
	for <gnats-bugs@gnats.netbsd.org>; Fri, 30 Jul 2010 20:46:20 +0000 (UTC)
Message-Id: <20100730204619.CCEF263B101@mail.netbsd.org>
Date: Fri, 30 Jul 2010 20:46:19 +0000 (UTC)
From: ryo_on@yk.rim.or.jp
Reply-To: ryo_on@yk.rim.or.jp
To: gnats-bugs@gnats.NetBSD.org
Subject: make package in devel/ruby-readline needs root privilege
X-Send-Pr-Version: 3.95

>Number:         43687
>Category:       pkg
>Synopsis:       make package in devel/ruby-readline needs root privilege
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    taca
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jul 30 20:50:00 +0000 2010
>Closed-Date:    Sun Sep 05 14:15:26 +0000 2010
>Last-Modified:  Sun Sep 05 14:15:26 +0000 2010
>Originator:     Ryo ONODERA
>Release:        NetBSD 5.99.38
>Organization:

>Environment:


System: NetBSD hydrogen.elements.tetera.org 5.99.38 NetBSD 5.99.38 (LEAFGIRL0) #1: Fri Jul 30 15:22:41 JST 2010 root@hydrogen.elements.tetera.org:/usr/obj/sys/arch/i386/compile/LEAFGIRL0 i386
Architecture: i386
Machine: i386
>Description:
make package in devel/ruby-readline needs root privilege.
In ext/readline/Makefile, install has "-o root -g wheel" options.

>How-To-Repeat:
% cd /usr/pkgsrc/devel/ruby-readline
% make package

>Fix:

The following patch fix this problem.
But I does not know build process of ruby module, there may be better solution.

diff -x CVS -upNr /usr/pkgsrc/devel/ruby-readline/Makefile ruby-readline/Makefile
--- /usr/pkgsrc/devel/ruby-readline/Makefile	2009-09-13 10:51:05.000000000 +0900
+++ ruby-readline/Makefile	2010-07-31 05:32:56.000000000 +0900
@@ -22,6 +22,14 @@ WRKSRC=			${RUBY_WRKSRC}/ext/readline
 RUBY_DOCS=		README README.ja
 INSTALLATION_DIRS=	${RUBY_DOC}/readline

+SUBST_CLASSES+=			fix-install
+SUBST_STAGE.fix-install=	pre-build
+SUBST_MESSAGE.fix-install=	Fix install command options 
+SUBST_FILES.fix-install=	Makefile
+SUBST_SED.fix-install=		-e 's,^INSTALL =.*,INSTALL=${INSTALL},'
+SUBST_SED.fix-install+=		-e 's,^INSTALL_PROG =.*,INSTALL_PROG = ${INSTALL_PROGRAM},'
+SUBST_SED.fix-install+=		-e 's,^INSTALL_DATA =.*,INSTALL_DATA = ${INSTALL_DATA},'
+
 post-install:
 .for f in ${RUBY_DOCS}
 	${INSTALL_DATA} ${WRKSRC}/${f} ${DESTDIR}${PREFIX}/${RUBY_DOC}/readline


>Release-Note:

>Audit-Trail:
From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/43687: make package in devel/ruby-readline needs root
 privilege
Date: Sat, 31 Jul 2010 10:03:34 +0900

 On Sat, 31 Jul 2010 05:50:01 +0900, <ryo_on@yk.rim.or.jp> wrote:

 >> Description:
 > make package in devel/ruby-readline needs root privilege.
 > In ext/readline/Makefile, install has "-o root -g wheel" options.

 I feel this issue is not only for this package.
 See PR#39333 and PR#43684.

Responsible-Changed-From-To: pkg-manager->taca
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Sat, 31 Jul 2010 13:24:33 +0000
Responsible-Changed-Why:
Over to maintainer.


From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/43687: make package in devel/ruby-readline needs root
 privilege
Date: Sat, 31 Jul 2010 22:25:35 +0900

 On Sat, 31 Jul 2010 10:05:03 +0900, OBATA Akio <obache@netbsd.org> wrote:

 >  On Sat, 31 Jul 2010 05:50:01 +0900, <ryo_on@yk.rim.or.jp> wrote:
 > >> Description:
 >  > make package in devel/ruby-readline needs root privilege.
 >  > In ext/readline/Makefile, install has "-o root -g wheel" options.
 > I feel this issue is not only for this package.
 >  See PR#39333 and PR#43684.

 For extconf packages in pkgsrc, following patch should avoid the issue.

 Index: modules.mk
 ===================================================================
 RCS file: /cvsroot/pkgsrc/lang/ruby/modules.mk,v
 retrieving revision 1.27
 diff -u -r1.27 modules.mk
 --- modules.mk	14 Jun 2009 22:58:03 -0000	1.27
 +++ modules.mk	31 Jul 2010 13:18:31 -0000
 @@ -32,6 +32,9 @@
   RUBY_EXTCONF_ARGS?=	--with-opt-dir=${PREFIX:Q} --vendor
   RUBY_EXTCONF_CHECK?=	yes
   RUBY_EXTCONF_MAKEFILE?=	Makefile
 +INSTALL_MAKE_FLAGS+=	INSTALL=${INSTALL:Q}\ -c\ -o\ ${BINOWN:Q}\ -g\ ${BINGRP:Q}
 +INSTALL_MAKE_FLAGS+=	INSTALL_PROG=${INSTALL_PROGRAM:Q}
 +INSTALL_MAKE_FLAGS+=	INSTALL_DATA=${INSTALL_DATA:Q}

   do-configure:	ruby-extconf-configure

 @@ -63,7 +66,7 @@
   ruby-extconf-install:
   .for d in ${RUBY_EXTCONF_SUBDIRS}
   	@${ECHO_MSG} "===>  Installing ${d}"
 -	${RUN}cd ${WRKSRC}/${d}; ${SETENV} ${INSTALL_ENV} ${MAKE_ENV} ${MAKE} ${INSTALL_TARGET}
 +	${RUN}cd ${WRKSRC}/${d}; ${SETENV} ${INSTALL_ENV} ${MAKE_ENV} ${MAKE} ${INSTALL_TARGET} ${INSTALL_MAKE_FLAGS}
   .endfor
   .endif



From: Takahiro Kambe <taca@back-street.net>
To: gnats-bugs@NetBSD.org, ryo_on@yk.rim.or.jp
Cc: 
Subject: Re: pkg/43687: make package in devel/ruby-readline needs root
 privilege
Date: Tue, 31 Aug 2010 02:31:42 +0900 (JST)

 Hi,

 Please try this patch under /usr/pkgsrc/lang:

 Index: ruby/Makefile.common
 ===================================================================
 RCS file: /cvsroot/pkgsrc/lang/ruby/Makefile.common,v
 retrieving revision 1.19
 diff -u -r1.19 Makefile.common
 --- ruby/Makefile.common	10 Jun 2009 13:38:55 -0000	1.19
 +++ ruby/Makefile.common	30 Aug 2010 17:06:53 -0000
 @@ -46,6 +46,18 @@
  STRIP?=			strip

  #
 +# Avoid to use -o and -g options with install.
 +#
 +INSTALL_PROGRAM=	${INSTALL} ${COPY} -m ${BINMODE}
 +INSTALL_SCRIPT=		${INSTALL} ${COPY} -m ${BINMODE}
 +INSTALL_LIB=		${INSTALL} ${COPY} -m ${BINMODE}
 +INSTALL_DATA=		${INSTALL} ${COPY} -m ${SHAREMODE}
 +INSTALL_MAN=		${INSTALL} ${COPY} -m ${MANMODE}
 +INSTALL_PROGRAM_DIR=	${INSTALL} -d -m ${PKGDIRMODE}
 +INSTALL_DATA_DIR= 	${INSTALL} -d -m ${PKGDIRMODE}
 +INSTALL_MAN_DIR= 	${INSTALL} -d -m ${PKGDIRMODE}
 +
 +#
  # PLIST substitution
  #
  PLIST_SUBST+=		RUBY_SHLIBVER=${RUBY_SHLIBVER:Q} \
 Index: ruby18-base/Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/lang/ruby18-base/Makefile,v
 retrieving revision 1.56
 diff -u -r1.56 Makefile
 --- ruby18-base/Makefile	16 Aug 2010 07:08:12 -0000	1.56
 +++ ruby18-base/Makefile	30 Aug 2010 17:06:53 -0000
 @@ -5,7 +5,7 @@
  PKGNAME=	${RUBY_PKGPREFIX}-base-${RUBY_VERSION_SUFFIX}
  CATEGORIES=	lang ruby
  MASTER_SITES=	${MASTER_SITE_RUBY}
 -PKGREVISION=	6
 +PKGREVISION=	7

  MAINTAINER=	taca@NetBSD.org
  HOMEPAGE=	${RUBY_HOMEPAGE}

 -- 
 Takahiro Kambe <taca@back-street.net>

State-Changed-From-To: open->analyzed
State-Changed-By: taca@NetBSD.org
State-Changed-When: Mon, 30 Aug 2010 17:39:18 +0000
State-Changed-Why:
I checked what was going on...


From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/43687: make package in devel/ruby-readline needs root
 privilege
Date: Mon, 30 Aug 2010 19:53:50 +0200

 On Mon, Aug 30, 2010 at 05:35:02PM +0000, Takahiro Kambe wrote:
 >  Index: ruby/Makefile.common

 [snip]

 Does this get embedded into the resulting package? Can it be easily
 overwritten at runtime?

 If yes and yes: use BSD_INSTALL_PROGRAM etc. at runtime instead.

 Joerg

From: Ryo ONODERA <ryo_on@yk.rim.or.jp>
To: gnats-bugs@NetBSD.org, taca@back-street.net
Cc: taca@NetBSD.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/43687: make package in devel/ruby-readline needs root
 privilege
Date: Tue, 31 Aug 2010 05:42:27 +0900 (JST)

 I installed as root, /usr/pkg/lib/ruby/1.8/i486-netbsdelf/rbconfig.rb has
   CONFIG["INSTALL"] = '/usr/bin/install -c -o root -g wheel'
 line.

 as me (ryo_on), it has
   CONFIG["INSTALL"] = '/usr/bin/install -c -o ryo_on -g elements'

 We still have -o and -g options.
 Problem is not solved.

 Thank you.


From: Takahiro Kambe <taca@back-street.net>
To: gnats-bugs@NetBSD.org, joerg@britannica.bec.de
Cc: ryo_on@yk.rim.or.jp
Subject: Re: pkg/43687: make package in devel/ruby-readline needs root
 privilege
Date: Tue, 31 Aug 2010 10:09:14 +0900 (JST)

 In message <20100830175501.E690763B89A@www.NetBSD.org>
 	on Mon, 30 Aug 2010 17:55:01 +0000 (UTC),
 	Joerg Sonnenberger <joerg@britannica.bec.de> wrote:
 >  Does this get embedded into the resulting package? Can it be easily
 >  overwritten at runtime?
 >  
 >  If yes and yes: use BSD_INSTALL_PROGRAM etc. at runtime instead.
 Yes and no.  INSTALL and its friends will embedded to constant CONFIG
 in Ruby's RbConfig module.  Its purpose is a dictonary various
 parameters when Ruby was built.

 AFAIK, there is no easy way to override these parameters from out side
 of scripts, such as environ(7).

 -- 
 Takahiro Kambe <taca@back-street.net>

From: Takahiro Kambe <taca@back-street.net>
To: ryo_on@yk.rim.or.jp
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/43687: make package in devel/ruby-readline needs root
 privilege
Date: Tue, 31 Aug 2010 10:11:17 +0900 (JST)

 In message <20100831.054227.85227512.ryo_on@yk.rim.or.jp>
 	on Tue, 31 Aug 2010 05:42:27 +0900 (JST),
 	Ryo ONODERA <ryo_on@yk.rim.or.jp> wrote:
 > I installed as root, /usr/pkg/lib/ruby/1.8/i486-netbsdelf/rbconfig.rb has
 >   CONFIG["INSTALL"] = '/usr/bin/install -c -o root -g wheel'
 > line.
 > 
 > as me (ryo_on), it has
 >   CONFIG["INSTALL"] = '/usr/bin/install -c -o ryo_on -g elements'
 > 
 > We still have -o and -g options.
 > Problem is not solved.
 Oops, I forgot to one more patch.  Please apply below one, too.
 Best regards.

 Index: ruby18-base/Makefile
 ===================================================================
 RCS file: /cvsroot/pkgsrc/lang/ruby18-base/Makefile,v
 retrieving revision 1.56
 diff -u -r1.56 Makefile
 --- ruby18-base/Makefile	16 Aug 2010 07:08:12 -0000	1.56
 +++ ruby18-base/Makefile	31 Aug 2010 00:57:34 -0000
 @@ -28,7 +28,7 @@
  CONFIGURE_ARGS+= --enable-shared \
  		--with-ssl-include="${BUILDLINK_PREFIX.openssl}/include" \
  		--with-ssl-lib="${BUILDLINK_PREFIX.openssl}/lib"
 -CONFIGURE_ENV+=		PREFIX=${PREFIX}
 +CONFIGURE_ENV+=	INSTALL="${INSTALL} ${COPY}"
  WRKSRC=		${RUBY_WRKSRC}

  .include "../../mk/compiler.mk"

 -- 
 Takahiro Kambe <taca@back-street.net>

From: Ryo ONODERA <ryo_on@yk.rim.or.jp>
To: taca@back-street.net
Cc: gnats-bugs@NetBSD.org
Subject: Re: pkg/43687: make package in devel/ruby-readline needs root
 privilege
Date: Tue, 31 Aug 2010 19:17:30 +0900 (JST)

 From: Takahiro Kambe <taca@back-street.net>
 Subject: Re: pkg/43687: make package in devel/ruby-readline needs root privilege
 Date: Tue, 31 Aug 2010 10:11:17 +0900 (JST)

 > In message <20100831.054227.85227512.ryo_on@yk.rim.or.jp>
 > 	on Tue, 31 Aug 2010 05:42:27 +0900 (JST),
 > 	Ryo ONODERA <ryo_on@yk.rim.or.jp> wrote:
 >> I installed as root, /usr/pkg/lib/ruby/1.8/i486-netbsdelf/rbconfig.rb has
 >>   CONFIG["INSTALL"] = '/usr/bin/install -c -o root -g wheel'
 >> line.
 >> 
 >> as me (ryo_on), it has
 >>   CONFIG["INSTALL"] = '/usr/bin/install -c -o ryo_on -g elements'
 >> 
 >> We still have -o and -g options.
 >> Problem is not solved.
 > Oops, I forgot to one more patch.  Please apply below one, too.
 > Best regards.

 It works fine for me.
 Thank you.

 --
 Ryo ONODERA // ryo_on@yk.rim.or.jp
 PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3


State-Changed-From-To: analyzed->feedback
State-Changed-By: taca@NetBSD.org
State-Changed-When: Tue, 31 Aug 2010 16:33:23 +0000
State-Changed-Why:
Slightly different fix has commit.  I believe it has no difference.


From: Ryo ONODERA <ryo_on@yk.rim.or.jp>
To: gnats-bugs@NetBSD.org, taca@NetBSD.org
Cc: 
Subject: Re: pkg/43687 (make package in devel/ruby-readline needs root
 privilege)
Date: Thu, 02 Sep 2010 04:27:20 +0900 (JST)

 It works fine.
 Thank you.

 Please close this PR.

 From: taca@NetBSD.org
 Subject: Re: pkg/43687 (make package in devel/ruby-readline needs root privilege)
 Date: Tue, 31 Aug 2010 16:33:24 +0000 (UTC)

 > Synopsis: make package in devel/ruby-readline needs root privilege
 > 
 > State-Changed-From-To: analyzed->feedback
 > State-Changed-By: taca@NetBSD.org
 > State-Changed-When: Tue, 31 Aug 2010 16:33:23 +0000
 > State-Changed-Why:
 > Slightly different fix has commit.  I believe it has no difference.
 > 
 > 
 > 
 > 
 > 


State-Changed-From-To: feedback->closed
State-Changed-By: taca@NetBSD.org
State-Changed-When: Sun, 05 Sep 2010 14:15:26 +0000
State-Changed-Why:
Submitter confirmed that problem has fixed.
Thanks for your problem report.


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.