NetBSD Problem Report #43887

From www@NetBSD.org  Fri Sep 17 07:29:06 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 13B7663B970
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 17 Sep 2010 07:29:06 +0000 (UTC)
Message-Id: <20100917072905.A595763B96E@www.NetBSD.org>
Date: Fri, 17 Sep 2010 07:29:05 +0000 (UTC)
From: ks@ub.uni-mainz.de
Reply-To: ks@ub.uni-mainz.de
To: gnats-bugs@NetBSD.org
Subject: building php-mysqli fails due to missing file my_compiler.h
X-Send-Pr-Version: www-1.0

>Number:         43887
>Category:       pkg
>Synopsis:       building php-mysqli fails due to missing file my_compiler.h
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    taca
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Sep 17 07:30:00 +0000 2010
>Closed-Date:    Fri Sep 24 23:10:50 +0000 2010
>Last-Modified:  Fri Nov 09 20:15:02 +0000 2012
>Originator:     Kurt Schreiner
>Release:        NetBSD 5.99.39, i.e. -current
>Organization:
Uni Mainz
>Environment:
NetBSD hmv-nbi386 5.99.39 NetBSD 5.99.39 (VMwNB99) #25: Thu Sep 16 08:29:43 CEST 2010  ks@hmv-nbi386:/u/NetBSD/arch/i386/obj/sys/arch/i386/compile/VMwNB99 i386

>Description:
With pkgsrc as of 17 September 2010, 7:00 GMT tying to build php-mysqli fails due to "my_compiler.h" missing.
>How-To-Repeat:
cd .../pkgsrc/databases/php-mysqli
make
>Fix:
Apply the following patch in  pkgsrc/databases/mysql51-client:

>-1044: cvs diff -u
cvs diff: Diffing .
Index: PLIST
===================================================================
RCS file: /cvsroot/pkgsrc/databases/mysql51-client/PLIST,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 PLIST
--- PLIST	4 Mar 2010 16:27:18 -0000	1.1.1.1
+++ PLIST	17 Sep 2010 07:24:29 -0000
@@ -28,6 +28,7 @@
 include/mysql/m_string.h
 include/mysql/my_alloc.h
 include/mysql/my_attribute.h
+include/mysql/my_compiler.h
 include/mysql/my_config.h
 include/mysql/my_dbug.h
 include/mysql/my_dir.h
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/databases/mysql51-client/distinfo,v
retrieving revision 1.7
diff -u -r1.7 distinfo
--- distinfo	8 Sep 2010 16:24:57 -0000	1.7
+++ distinfo	17 Sep 2010 07:24:29 -0000
@@ -13,7 +13,7 @@
 SHA1 (patch-ah) = 5fd4db0e04a97289f38a5467bbae5041f4082b51
 SHA1 (patch-ai) = 722364e59070ab2d3377a694698f32bf25427bf2
 SHA1 (patch-aj) = 476384877154dd8d2465c6c9a0e411c220d405e4
-SHA1 (patch-ak) = 5dd0982e9c9b2d0199a3a148a12a4dd219533e9d
+SHA1 (patch-ak) = b9621ebda305fe659fa90a8972f759fb3e55d09d
 SHA1 (patch-al) = 93ba34d66fd054fbcf9e1eb3a042770d4d6820ec
 SHA1 (patch-am) = 7cced70246776a64e782e0c7d335d5948a2189f1
 SHA1 (patch-an) = a608060cee7aadaf8bcde84016a73131a75dea32
cvs diff: Diffing patches
Index: patches/patch-ak
===================================================================
RCS file: /cvsroot/pkgsrc/databases/mysql51-client/patches/patch-ak,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 patch-ak
--- patches/patch-ak	4 Mar 2010 16:27:18 -0000	1.1.1.1
+++ patches/patch-ak	17 Sep 2010 07:24:29 -0000
@@ -1,8 +1,6 @@
-$NetBSD: patch-ak,v 1.1.1.1 2010/03/04 16:27:18 taca Exp $
-
---- include/Makefile.in.orig	2010-02-04 11:46:18.000000000 +0000
-+++ include/Makefile.in
-@@ -393,6 +393,7 @@ BUILT_SOURCES = $(HEADERS_GEN_MAKE) link
+--- include/Makefile.in.orig	2010-08-03 19:28:49.000000000 +0200
++++ include/Makefile.in	2010-09-17 08:53:29.000000000 +0200
+@@ -397,6 +397,7 @@
  HEADERS_GEN_CONFIGURE = mysql_version.h
  HEADERS_GEN_MAKE = my_config.h
  HEADERS_ABI = mysql.h mysql_com.h mysql_time.h \
@@ -10,3 +8,21 @@
  			my_list.h my_alloc.h typelib.h mysql/plugin.h

  pkginclude_HEADERS = $(HEADERS_ABI) my_dbug.h m_string.h my_sys.h \
+@@ -404,6 +405,7 @@
+ 		  	my_pthread.h my_no_pthread.h \
+ 			decimal.h errmsg.h my_global.h my_net.h \
+ 			my_getopt.h sslopt-longopts.h my_dir.h \
++			my_compiler.h \
+ 			sslopt-vars.h sslopt-case.h sql_common.h keycache.h \
+ 			m_ctype.h my_attribute.h $(HEADERS_GEN_CONFIGURE) \
+ 			$(HEADERS_GEN_MAKE)
+@@ -416,7 +418,8 @@
+ 			my_aes.h my_tree.h my_trie.h hash.h thr_alarm.h \
+ 			thr_lock.h t_ctype.h violite.h my_md5.h base64.h \
+ 			my_handler.h my_time.h my_vle.h my_user.h \
+-			my_libwrap.h my_stacktrace.h my_compiler.h
++			my_libwrap.h my_stacktrace.h
++# my_compiler.h
+ 
+ EXTRA_DIST = mysql.h.pp mysql/plugin.h.pp
+ 

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/43887: building php-mysqli fails due to missing file
 my_compiler.h
Date: Fri, 17 Sep 2010 09:41:40 +0200

 On Fri, Sep 17, 2010 at 07:30:00AM +0000, ks@ub.uni-mainz.de wrote:
 > With pkgsrc as of 17 September 2010, 7:00 GMT tying to build php-mysqli fails due to "my_compiler.h" missing.

 Builds fine for me on 5.99.39/amd64.
 Please give more information on the build failure for php-mysqli.
  Thomas

From: Kurt Schreiner <ks@ub.uni-mainz.de>
To: gnats-bugs@netbsd.org
Cc: pkg-manager@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/43887: building php-mysqli fails due to missing file
 my_compiler.h
Date: Fri, 17 Sep 2010 10:02:28 +0200

 On Fri, Sep 17, 2010 at 07:45:01AM +0000, Thomas Klausner wrote:
 > The following reply was made to PR pkg/43887; it has been noted by GNATS.
 > 
 > From: Thomas Klausner <wiz@NetBSD.org>
 > To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
 > Cc: 
 > Subject: Re: pkg/43887: building php-mysqli fails due to missing file
 >  my_compiler.h
 > Date: Fri, 17 Sep 2010 09:41:40 +0200
 > 
 >  On Fri, Sep 17, 2010 at 07:30:00AM +0000, ks@ub.uni-mainz.de wrote:
 >  > With pkgsrc as of 17 September 2010, 7:00 GMT tying to build php-mysqli fails due to "my_compiler.h" missing.
 >  
 >  Builds fine for me on 5.99.39/amd64.
 Which version of mysql-client is installed on your (test) system?
 mysql-client 5.1.49 (updated to ..50 on Sept. 08) doesn't have this
 problem.

 >  Please give more information on the build failure for php-mysqli.
 The problem arises with the newest mysql-client 5.1.50 as there is
 a new dependency on my_compiler.h in my_config.h.

 From the mysql-5.1.50 Changelog:

     ------------------------------------------------------------
     revno: 3457.1.27
     committer: Davi Arnaut <Davi.Arnaut@Sun.COM>
     branch nick: mysql-5.1-bugteam
     timestamp: Wed 2010-07-14 16:39:40 -0300
     message:
       Bug#42733: Type-punning warnings when compiling MySQL --
                  strict aliasing violations.

       Post-merge fix: include my_compiler.h before my_attribute.h
       as the latter will undef __attribute__ if the compiler is not
       GCC. Based on the compiler version, in my_compiler.h we know
       for sure whether the aligned attribute is supported. Furthermore,
       undefining attribute might cause bugs if some system header
       uses it.
     ------------------------------------------------------------


 Building php-mysqli w/o my patches applied fails with:

 ...
 In file included from /u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli/mysqli_nonapi.c:24:
 /u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli/config.h:68:1: warning: this is the location of the previous definition
 In file included from /u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli/php_mysqli_structs.h:57,
 --- mysqli_prop.lo ---
 /u/NetBSD/pkgobj/databases/php-mysqli/work/.buildlink/include/mysql/my_global.h:626:25: error: my_compiler.h: No such file or directory
 --- mysqli_nonapi.lo ---
                  from /u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli/mysqli_nonapi.c:32:
 /u/NetBSD/pkgobj/databases/php-mysqli/work/.buildlink/include/mysql/my_global.h:626:25: error: my_compiler.h: No such file or directory
 --- mysqli_api.lo ---
 In file included from /u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli/php_mysqli_structs.h:57,
 --- mysqli_nonapi.lo ---
 *** [mysqli_nonapi.lo] Error code 1

 make: stopped in /u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli
 --- mysqli_api.lo ---
                  from /u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli/mysqli_api.c:33:
 /u/NetBSD/pkgobj/databases/php-mysqli/work/.buildlink/include/mysql/my_global.h:626:25: error: my_compiler.h: No such file or directory
 --- mysqli_prop.lo ---
 *** [mysqli_prop.lo] Error code 1

 make: stopped in /u/NetBSD/pkgobj/databases/php-mysqli/work/php-5.3.3/ext/mysqli
 ...

 Kurt

From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/43887: building php-mysqli fails due to missing file
 my_compiler.h
Date: Fri, 17 Sep 2010 11:10:54 +0200

 On Fri, Sep 17, 2010 at 10:02:28AM +0200, Kurt Schreiner wrote:
 > The problem arises with the newest mysql-client 5.1.50 as there is
 > a new dependency on my_compiler.h in my_config.h.

 I have 5.1.50.
 I'm using the default php version though, so I get php5-mysqli-5.2.14
 and this doesn't show the problem.

 When setting PHP_VERSION_DEFAULT=53 in /etc/mk.conf, I can reproduce
 the problem.
  Thomas

Responsible-Changed-From-To: pkg-manager->jdolecek
Responsible-Changed-By: hauke@NetBSD.org
Responsible-Changed-When: Sun, 19 Sep 2010 17:41:12 +0000
Responsible-Changed-Why:
Over to maintainer.


Responsible-Changed-From-To: jdolecek->taca
Responsible-Changed-By: taca@NetBSD.org
Responsible-Changed-When: Tue, 21 Sep 2010 09:31:11 +0000
Responsible-Changed-Why:
I'll take this  since it isn't a problem of php-mysqli but mysql51-client
and I just know what the problem is.


State-Changed-From-To: open->feedback
State-Changed-By: taca@NetBSD.org
State-Changed-When: Tue, 21 Sep 2010 15:59:48 +0000
State-Changed-Why:
mysql51-client has fixed almost the same as our patch.
Not php-mysqli should build properly.


State-Changed-From-To: feedback->closed
State-Changed-By: taca@NetBSD.org
State-Changed-When: Fri, 24 Sep 2010 23:10:50 +0000
State-Changed-Why:
Submitter reports the problem has gone.
Thanks for the problem report.


From: "Paul Goyette" <pgoyette@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/43887 CVS commit: src/tests/lib/libc/gen
Date: Fri, 9 Nov 2012 20:13:24 +0000

 Module Name:	src
 Committed By:	pgoyette
 Date:		Fri Nov  9 20:13:24 UTC 2012

 Modified Files:
 	src/tests/lib/libc/gen: t_sleep.c

 Log Message:
 More clean-up, and adjust timing of kevent test to avoid issues with
 PR kern/43887


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 src/tests/lib/libc/gen/t_sleep.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search