NetBSD Problem Report #43901

From jwise@NetBSD.org  Thu Sep 23 18:52:03 2010
Return-Path: <jwise@NetBSD.org>
Received: by www.NetBSD.org (Postfix, from userid 1160)
	id B1C9963B97A; Thu, 23 Sep 2010 18:52:03 +0000 (UTC)
Message-Id: <20100923185203.B1C9963B97A@www.NetBSD.org>
Date: Thu, 23 Sep 2010 18:52:03 +0000 (UTC)
From: jwise@NetBSD.org
Reply-To: jwise@NetBSD.org
To: gnats-bugs@NetBSD.org
Subject: graphics/jasper's jasper/jas_types.h should not include stdbool.h on Solaris
X-Send-Pr-Version: 3.95

>Number:         43901
>Category:       pkg
>Synopsis:       graphics/jasper's jasper/jas_types.h should not include stdbool.h on Solaris
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    solaris-pkg-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 23 18:55:00 +0000 2010
>Closed-Date:    Tue Jun 21 16:41:39 +0000 2011
>Last-Modified:  Tue Jun 21 16:41:39 +0000 2011
>Originator:     Jim Wise
>Release:        Solaris 10 x86_64
>Organization:
>Environment:
Solaris 10 x86_64
>Description:
	graphics/jasper is built with USE_LANGUAGES=c99, so it detects Solaris 10's <stdbool.h>
	as usable.  On Solaris, however, <stdbool.h> has:

	#if defined(_STDC_C99)
	[...]
	#else /* _STDC_C99 */
	#error "Use of <stdbool.h> is valid only in a c99 compilation environment."
	#endif /* _STDC_C99 */

	so this results in an install of jasper which can't be used from non-c99 programs.

	Setting HAVE_STDBOOL_H to 0 in the Solaris case results in a correct build, and a
	jasper install which works fine with, eg, netpbm.
>How-To-Repeat:
	Try to build graphics/netpbm on Solaris 10.
>Fix:
	Not sure -- spent a little time trying to patch this, but was loathe to patch configure
	directly, and the package currently has patches for configure, but not configure.in.

>Release-Note:

>Audit-Trail:
[20110327 shattered] edited Environment: field

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Fri, 12 Nov 2010 11:22:08 +0000
Responsible-Changed-Why:
Problem on Solaris.


From: Tim Zingelman <tez@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: obache@netbsd.org, solaris-pkg-people@netbsd.org, pkg-manager@netbsd.org, 
	pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org, jwise@netbsd.org
Subject: Re: pkg/43901 (graphics/jasper's jasper/jas_types.h should not
 include stdbool.h on Solaris)
Date: Tue, 5 Apr 2011 16:40:43 -0500

 This patch seems to fix it for me.  Does it solve the problem for you?

 diff -u -r1.32 Makefile
 --- Makefile    23 Dec 2010 11:44:40 -0000      1.32
 +++ Makefile    5 Apr 2011 21:28:52 -0000
 @@ -18,6 +18,11 @@
  GNU_CONFIGURE=         yes
  CONFIGURE_ARGS+=       --enable-shared --without-x --disable-opengl

 +# The solaris stdbool.h requires c99 which is fine for jasper, but
 +# not so good for things that depend upon jasper.  See PR#43901
 +OPSYSVARS+=            CONFIGURE_ENV
 +CONFIGURE_ENV.SunOS+=          ac_cv_header_stdbool_h=no
 +
  INSTALLATION_DIRS+=    share/doc/jasper

  post-install:


 For what it is worth, stdbool.h is excluded by configure when using
 the sunpro compiler due to other errors, so folks using that compiler
 might not see this problem.

State-Changed-From-To: open->feedback
State-Changed-By: tez@NetBSD.org
State-Changed-When: Wed, 06 Apr 2011 00:01:41 +0000
State-Changed-Why:
feedback requested


From: Jim Wise <jwise@draga.com>
To: Tim Zingelman <tez@netbsd.org>
Cc: gnats-bugs@netbsd.org, obache@netbsd.org, solaris-pkg-people@netbsd.org,
        pkg-manager@netbsd.org, pkgsrc-bugs@netbsd.org, gnats-admin@netbsd.org
Subject: Re: pkg/43901 (graphics/jasper's jasper/jas_types.h should not include stdbool.h on Solaris)
Date: Wed, 06 Apr 2011 11:28:25 -0400

 --=-=-=
 Content-Type: text/plain
 Content-Transfer-Encoding: quoted-printable

 Tim Zingelman <tez@netbsd.org> writes:

 > This patch seems to fix it for me.  Does it solve the problem for you?

 Yeah, thanks!

 =2D-=20
 				Jim Wise
 				jwise@draga.com

 --=-=-=
 Content-Type: application/pgp-signature

 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.9 (SunOS)

 iEYEARECAAYFAk2chpkACgkQHDchQepTnhRD3gCfdpnpOLjGz93FdOKb+/VtMnQ7
 T84AnA9KUdPatyMGxZxgcXNbdPMmo/F0
 =iZ0O
 -----END PGP SIGNATURE-----
 --=-=-=--

State-Changed-From-To: feedback->open
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 14 May 2011 18:38:22 +0000
State-Changed-Why:
feedback received a month ago; please commit the patch :-)


From: "Tim Zingelman" <tez@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/43901 CVS commit: pkgsrc/graphics/jasper
Date: Tue, 21 Jun 2011 16:20:52 +0000

 Module Name:	pkgsrc
 Committed By:	tez
 Date:		Tue Jun 21 16:20:52 UTC 2011

 Modified Files:
 	pkgsrc/graphics/jasper: Makefile

 Log Message:
 The solaris stdbool.h requires c99 which is fine for jasper, but
 not so good for things that depend upon jasper.  See PR#43901
 This stops jasper from using stdbool.h (on solaris only.)


 To generate a diff of this commit:
 cvs rdiff -u -r1.32 -r1.33 pkgsrc/graphics/jasper/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

The patch above has been edited in this PR to match what was committed and
what was originally intended... the original patch had:
 +CONFIGURE_ENV+=                ac_cv_header_stdbool_h=no
where we need
 +CONFIGURE_ENV.SunOS+=                ac_cv_header_stdbool_h=no
to limit the impact to Solaris.  I edited the patch in place above and noted
the change here instead to reduce possibility of confusion (I hope.)

State-Changed-From-To: open->closed
State-Changed-By: tez@NetBSD.org
State-Changed-When: Tue, 21 Jun 2011 16:41:39 +0000
State-Changed-Why:
fixed


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.