NetBSD Problem Report #43911

From www@NetBSD.org  Mon Sep 27 06:32:00 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 45E0363B8DE
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 27 Sep 2010 06:32:00 +0000 (UTC)
Message-Id: <20100927063200.10B2A63B8DB@www.NetBSD.org>
Date: Mon, 27 Sep 2010 06:32:00 +0000 (UTC)
From: clarkjc@runbox.com
Reply-To: clarkjc@runbox.com
To: gnats-bugs@NetBSD.org
Subject: plb_attach for PowerPC 4xx hangs checking local PLB devices against PVR
X-Send-Pr-Version: www-1.0

>Number:         43911
>Category:       port-powerpc
>Synopsis:       plb_attach for PowerPC 4xx hangs checking local PLB devices against PVR
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    port-powerpc-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Sep 27 06:35:00 +0000 2010
>Closed-Date:    Thu Dec 23 21:03:36 +0000 2010
>Last-Modified:  Thu Dec 23 21:03:36 +0000 2010
>Originator:     John Clark
>Release:        NetBSD-current
>Organization:
>Environment:
Can't run uname yet...
>Description:
plb_attach in src/sys/arch/powerpc/ibm4xx/dev/plb.c hangs checking local PLB devices against the processor version retrieved from the PVR register.  It looks like a copy/paste error: plb_dev[i] was used instead of local_plb_devs.  The problem was introduced in version 1.15 of src/sys/arch/powerpc/ibm4xx/dev/plb.c on Thu Mar 18 13:47:04 2010 UTC.
>How-To-Repeat:
Try to boot kernel on PPC4xx CPU when your configuration has local PLB devices.
>Fix:
Index: plb.c
===================================================================
RCS file: /cvsroot/src/sys/arch/powerpc/ibm4xx/dev/plb.c,v
retrieving revision 1.15
diff -u -r1.15 plb.c
--- plb.c	18 Mar 2010 13:47:04 -0000	1.15
+++ plb.c	27 Sep 2010 06:16:36 -0000
@@ -179,7 +179,7 @@
 	}

 	while (local_plb_devs && local_plb_devs->plb_name != NULL) {
-		if (plb_devs[i].plb_pvr != pvr)
+		if (local_plb_devs->plb_pvr != pvr)
 			continue;

 		paa.plb_name = local_plb_devs->plb_name;

>Release-Note:

>Audit-Trail:
From: "KIYOHARA Takashi" <kiyohara@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/43911 CVS commit: src/sys/arch/powerpc/ibm4xx/dev
Date: Mon, 13 Dec 2010 07:29:14 +0000

 Module Name:	src
 Committed By:	kiyohara
 Date:		Mon Dec 13 07:29:14 UTC 2010

 Modified Files:
 	src/sys/arch/powerpc/ibm4xx/dev: plb.c

 Log Message:
 Fix PR#43911.


 To generate a diff of this commit:
 cvs rdiff -u -r1.17 -r1.18 src/sys/arch/powerpc/ibm4xx/dev/plb.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Tue, 21 Dec 2010 05:59:45 +0000
State-Changed-Why:
Did that fix it?


State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Thu, 23 Dec 2010 21:03:36 +0000
State-Changed-Why:
confirmed fixed, thanks.


>Unformatted:

Home	PR Database Search