NetBSD Problem Report #44073

From www@NetBSD.org  Tue Nov  9 18:58:51 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 236FF63BA61
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  9 Nov 2010 18:58:51 +0000 (UTC)
Message-Id: <20101109185850.B897963BA50@www.NetBSD.org>
Date: Tue,  9 Nov 2010 18:58:50 +0000 (UTC)
From: roam@ringlet.net
Reply-To: roam@ringlet.net
To: gnats-bugs@NetBSD.org
Subject: libnetpgp: only export the netpgp_* symbols
X-Send-Pr-Version: www-1.0

>Number:         44073
>Category:       lib
>Synopsis:       libnetpgp: only export the netpgp_* symbols
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    agc
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 09 19:00:00 +0000 2010
>Last-Modified:  Sun Oct 02 18:57:52 +0000 2016
>Originator:     Peter Pentchev
>Release:        
>Organization:
>Environment:
>Description:
The libnetpgp.so.0 library exports all the internal functions,
which should never be used by library consumers.  This leads to
unnecessary symbols churn as the library's version goes up;
what do you think about the attached patch that instructs libtool
to only export the netpgp_* symbols?
>How-To-Repeat:
nm -aoD libnetpgp.so.0.0.0 | fgrep -w T | fgrep -ve netpgp_
>Fix:
Apply the patch found at:
http://devel.ringlet.net/security/netpgp/patches/09-libtool-export.patch

Thanks for maintaining netpgp, and keep up the good work!

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: lib/44073: libnetpgp: only export the netpgp_* symbols
Date: Sun, 2 Oct 2016 18:37:58 +0000

 On Tue, Nov 09, 2010 at 07:00:00PM +0000, roam@ringlet.net wrote:
  > Apply the patch found at:
  > http://devel.ringlet.net/security/netpgp/patches/09-libtool-export.patch

 here's a copy of that:

    ------

 Description: Only export the netpgp_* symbols from libnetpgp0.so
 Bug: http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=44073
 Author: Peter Pentchev <roam@ringlet.net>
 Last-Update: 2010-11-09

 Index: src/lib/Makefile.in
 ===================================================================
 RCS file: /cvsroot/src/crypto/external/bsd/netpgp/dist/src/lib/Makefile.in,v
 retrieving revision 1.14
 diff -u -r1.14 Makefile.in
 --- src/lib/Makefile.in	6 Nov 2010 03:42:59 -0000	1.14
 +++ src/lib/Makefile.in	9 Nov 2010 18:49:21 -0000
 @@ -225,7 +225,7 @@
  	validate.c \
  	writer.c

 -libnetpgp_la_LIBADD = ../libmj/libmj.la
 +libnetpgp_la_LIBADD = -export-symbols-regex '^netpgp_.*' ../libmj/libmj.la
  dist_man_MANS = libnetpgp.3
  all: config.h
  	$(MAKE) $(AM_MAKEFLAGS) all-am


 -- 
 David A. Holland
 dholland@netbsd.org

Responsible-Changed-From-To: lib-bug-people->agc
Responsible-Changed-By: dholland@NetBSD.org
Responsible-Changed-When: Sun, 02 Oct 2016 18:57:52 +0000
Responsible-Changed-Why:
over to author, who obviously never saw this


>Unformatted:

Home	PR Database Search