NetBSD Problem Report #44088

From eric@egsner.cirr.com  Fri Nov 12 18:51:04 2010
Return-Path: <eric@egsner.cirr.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id D301563BA61
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 12 Nov 2010 18:51:04 +0000 (UTC)
Message-Id: <201011121745.oACHj4mm026177@egsner.cirr.com>
Date: Fri, 12 Nov 2010 11:45:04 -0600 (CST)
From: eric@cirr.com
Reply-To: eric@cirr.com
To: gnats-bugs@gnats.NetBSD.org
Subject: [n]vi started defaulting to gtagsmode with NetBSD 5.0
X-Send-Pr-Version: 3.95

>Number:         44088
>Category:       bin
>Synopsis:       [n]vi began defaulting to gtagsmode with NetBSD 5.0
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    schnoebe
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Nov 12 18:55:00 +0000 2010
>Closed-Date:    Wed Dec 29 19:51:46 +0000 2010
>Last-Modified:  Wed Dec 29 19:51:46 +0000 2010
>Originator:     Eric Schnoebelen
>Release:        NetBSD 5.99.27
>Organization:
Eric Schnoebelen		eric@cirr.com		http://www.cirr.com
    Women who seek to be equal with men lack ambition.  --  Timothy Leary
>Environment:
System: NetBSD egsner.cirr.com 5.99.27 NetBSD 5.99.27 (XEN3_DOM0) #0: Tue Apr 13 00:12:10 CDT 2010 eric@bob-the-builder.cirr.com:/work/eric/NetBSD-current/obj/amd64/sys/arch/amd64/compile/XEN3_DOM0 amd64
Architecture: x86_64
Machine: amd64
>Description:
	With the release of NetBSD 5.0, (with nvi 1.81.6), [n]vi started
	defaulting to "gtagsmode" for tag searching.

	However, the "global" command needed to do the searches is not 
	included.

	The manual page implies that "gtagsmode" is disabled by default,
	but viewing ":set all" shows it is active.

>How-To-Repeat:
    $ ex
    :se all
    noaltwerase     exrc            matchtime=7     report=5        notildeop
    autoindent      noextended      mesg            noruler         timeout
    autoprint       filec=""        nomodeline      scroll=29       nottywerase
    noautowrite     flash           msgcat="./"     nosearchincr    noverbose
    backup=""       gtagsmode       noprint=""      nosecure        warn
    nobeautify      hardtabs=0      nonumber        shiftwidth=4    window=59
    cdpath=":"      noiclower       nooctal         noshowmatch     nowindowname
    cedit=""        noignorecase    open            noshowmode      wraplen=0
    columns=80      keytime=6       optimize        sidescroll=16   wrapmargin=8
    nocombined      noleftright     path=""         noslowopen      wrapscan
    nocomment       lines=60        print=""        nosourceany     nowriteany
    noedcompatible  nolisp          prompt          tabstop=8
    noerrorbells    nolist          noreadonly      taglength=0
    escapetime=1    lock            noredraw        tags="tags"
    noexpandtab     magic          
>Fix:
    unknown, the source seems to imply that gtagsmode should be
    off by default.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: bin-bug-people->schnoebe
Responsible-Changed-By: schnoebe@NetBSD.org
Responsible-Changed-When: Sun, 14 Nov 2010 20:30:17 +0000
Responsible-Changed-Why:
Schnoebe took possession of the bug to fix.


State-Changed-From-To: open->analyzed
State-Changed-By: schnoebe@NetBSD.org
State-Changed-When: Sun, 14 Nov 2010 20:30:17 +0000
State-Changed-Why:
schnoebe analyzed the bug, and has a fix pending


From: eric@cirr.com (Eric Schnoebelen)
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: Re: bin/44088: [n]vi started defaulting to gtagsmode with NetBSD 5.0
Date: Sun, 14 Nov 2010 14:48:52 -0600

 Analysis of the source indicates that gtagsmode is on by
 default, and should be off for least-astonishment reasons, if no
 other. (never mind it doesn't work without the "global"
 command.)

 The following change makes it behave as expected:

 Index: common/options.c
 ===================================================================
 RCS file: /cvsroot/src/dist/nvi/common/options.c,v
 retrieving revision 1.8
 diff -b -u -w -r1.8 options.c
 --- common/options.c	13 May 2010 17:52:11 -0000	1.8
 +++ common/options.c	14 Nov 2010 20:46:40 -0000
 @@ -98,7 +98,7 @@
  	{L("flash"),	NULL,		OPT_1BOOL,	0},
  #ifdef GTAGS
  /* O_GTAGSMODE	    FreeBSD/NetBSD */
 -	{L("gtagsmode"),NULL,		OPT_1BOOL,	0},
 +	{L("gtagsmode"),NULL,		OPT_0BOOL,	0},
  #endif
  /* O_HARDTABS	    4BSD */
  	{L("hardtabs"),	NULL,		OPT_NUM,	0},


 --
 Eric Schnoebelen		eric@cirr.com		http://www.cirr.com
     One person with a belief is equal to a force of ninety-nine who only 
 		have an interest. -- John Stuart Mill

From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/44088: [n]vi started defaulting to gtagsmode with NetBSD
 5.0
Date: Mon, 15 Nov 2010 05:01:13 +0000

 (the commit message needs to say "PR bin/44088" or "PR 44088" for it
 to get to gnats on its own)

    ------

 From: Eric Schnoebelen <schnoebe@netbsd.org>
 To: source-changes@NetBSD.org
 Subject: CVS commit: src/dist/nvi/common
 Date: Sun, 14 Nov 2010 20:53:54 +0000
 Mail-Followup-To: source-changes-d@NetBSD.org

 Module Name:	src
 Committed By:	schnoebe
 Date:		Sun Nov 14 20:53:54 UTC 2010

 Modified Files:
 	src/dist/nvi/common: options.c

 Log Message:
 bin/44088

 Change the initialization state of gtagsmode to 0, (unset).

 This brings about least astonishment for users, permittings tags
 functionality to work as expected.


 To generate a diff of this commit:
 cvs rdiff -u -r1.8 -r1.9 src/dist/nvi/common/options.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: analyzed->closed
State-Changed-By: schnoebe@NetBSD.org
State-Changed-When: Wed, 29 Dec 2010 19:51:46 +0000
State-Changed-Why:
The fix applied and worked successfully.


>Unformatted:

Home	PR Database Search