NetBSD Problem Report #44151

From www@NetBSD.org  Fri Nov 26 07:38:54 2010
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 7D0E763BAE5
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 26 Nov 2010 07:38:54 +0000 (UTC)
Message-Id: <20101126073854.2AC7A63B95F@www.NetBSD.org>
Date: Fri, 26 Nov 2010 07:38:54 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Change from logical and to binary and.
X-Send-Pr-Version: www-1.0

>Number:         44151
>Category:       kern
>Synopsis:       Change from logical and to binary and.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Nov 26 07:40:00 +0000 2010
>Closed-Date:    Fri Nov 26 22:05:59 +0000 2010
>Last-Modified:  Fri Nov 26 22:05:59 +0000 2010
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Change from logical and to binary and.
>How-To-Repeat:

>Fix:
diff -u -r1.33 if_bnx.c
--- sys/dev/pci/if_bnx.c	5 Apr 2010 07:20:25 -0000	1.33
+++ sys/dev/pci/if_bnx.c	25 Nov 2010 13:04:03 -0000
@@ -1996,7 +1996,7 @@
 	} else if (BNX_CHIP_BOND_ID(sc) & BNX_CHIP_BOND_ID_SERDES_BIT)
 		sc->bnx_phy_flags |= BNX_PHY_SERDES_FLAG;

-	if (sc->bnx_phy_flags && BNX_PHY_SERDES_FLAG) {
+	if (sc->bnx_phy_flags & BNX_PHY_SERDES_FLAG) {
 		u_int32_t val;

 		sc->bnx_flags |= BNX_NO_WOL_FLAG;

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44151 CVS commit: src/sys/dev/pci
Date: Fri, 26 Nov 2010 21:59:50 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Fri Nov 26 21:59:49 UTC 2010

 Modified Files:
 	src/sys/dev/pci: if_bnx.c

 Log Message:
 Don't test flags with &&. From Henning Petersen in PR 44151.


 To generate a diff of this commit:
 cvs rdiff -u -r1.33 -r1.34 src/sys/dev/pci/if_bnx.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Fri, 26 Nov 2010 22:05:59 +0000
State-Changed-Why:
fixed, thanks


>Unformatted:

Home	PR Database Search