NetBSD Problem Report #44178

From kre@munnari.OZ.AU  Wed Dec  1 06:31:12 2010
Return-Path: <kre@munnari.OZ.AU>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id ECCF463B95F
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  1 Dec 2010 06:31:11 +0000 (UTC)
Message-Id: <201012010630.oB16Us8M005745@jade.coe.psu.ac.th>
Date: Wed, 1 Dec 2010 13:30:54 +0700 (ICT)
From: kre@munnari.OZ.AU
To: gnats-bugs@gnats.NetBSD.org
Subject: misc/openoffice2 missing graphics/gdk-pixbuf2-xlib dependency (NetBSD 5) (possible fix)
X-Send-Pr-Version: 3.95

>Number:         44178
>Category:       pkg
>Synopsis:       misc/openoffice2 missing graphics/gdk-pixbuf2-xlib dependency (NetBSD 5) (possible fix)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Dec 01 06:35:00 +0000 2010
>Closed-Date:    Tue Dec 07 02:55:56 +0000 2010
>Last-Modified:  Tue Dec 07 02:55:56 +0000 2010
>Originator:     Robert Elz
>Release:        NetBSD 5.0   (pkgsrc current 2010-12-01)
>Organization:
	Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 5.1 NetBSD 5.1 (JADE-1.12-20101117) #5: Wed Nov 17 05:30:55 ICT 2010 kre@jade.coe.psu.ac.th:/usr/obj/5.1/kernels/i386/JADE i386
Architecture: i386
Machine: i386
>Description:
	misc/openoffice2 configure script checks for the presence
	of gdk-pixbuf-xlib, but nothing in the dependency list
	causes that one to get installed, so configure fails.

>How-To-Repeat:
	I use pkg_comp with NetBSD 5.0 release sets installed, and
	libkver to simulate a fairly pure NetBSD 5.0 release environment.
	I doubt that any of that is relevant to this problem, except that
	I start each package build with an empty sandbox (just the release
	sets and the essential pkgsrc packages (like digest, x11-links,
	pkg_install ...) installed, after that, everything needed must
	be explicitly loaded as a dependency of something.

	In that environment (and after recent gnome/gtk updates) attempting
	to build miscopenoffice2 results in ...

[ much stuff...]

checking which polygon clipping code to use... internal
checking which VCLplugs shall be built... gtk
checking whether to enable GNOME VFS support... no
checking for gtk+-2.0 >= 2.4 gdk-pixbuf-xlib-2.0 >= 2.2 ... configure: error: requirements to build the gtk-plugin not met. Use --disable-gtk or install the missing packages
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/misc/openoffice2
*** Error code 1

Stop.

	And pkg_info shows that while graphics/gdk-pixbuf2 is installed,
	graphics/gdk-pixbuf2-xlib is not.

	I'm guessing that that once was added as a dependency of
	something else, but whatever that something else was, no
	lomger needs it, so it was dropped (which then wouldn't be
	noticed in a "normal" build environment where just about
	everything is installed all the time).

>Fix:
	Applying the following patch allows the openoffice2 build to
	commence (at least) - unless some other error occurs soon, it
	will be a long time (10-12 hrs?) before I know whether or not
	this actually completely fixes the problem (and the build succeeds).

	Note; I am not asserting that this is the correct fix (possibly
	some other dependent package needs to be altered instead),
	this (trivial) patch is just to show what seems to be working
	for me, so far anyway.

	If we were to operate under the assumption that packages should
	explicitly mention everything they use themselves, then there
	are probably a bunch more includes needed (eg: I see nothing
	that explicitly includes gtk2 yet openoffice2 clearly expects
	to use that one - it gets included anyway, but should it be
	explicit here?).

Index: Makefile
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/misc/openoffice2/Makefile,v
retrieving revision 1.81
diff -u -r1.81 Makefile
--- Makefile	15 Nov 2010 22:58:00 -0000	1.81
+++ Makefile	1 Dec 2010 06:02:03 -0000
@@ -190,6 +190,7 @@
 .include "../../graphics/MesaLib/buildlink3.mk"
 .include "../../graphics/cairo/buildlink3.mk"
 .include "../../graphics/freetype2/buildlink3.mk"
+.include "../../graphics/gdk-pixbuf2-xlib/buildlink3.mk"
 .include "../../graphics/hicolor-icon-theme/buildlink3.mk"
 .include "../../graphics/jpeg/buildlink3.mk"
 .include "../../lang/python/application.mk"

>Release-Note:

>Audit-Trail:
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/44178: misc/openoffice2 missing graphics/gdk-pixbuf2-xlib
 dependency (NetBSD 5) (possible fix)
Date: Thu, 2 Dec 2010 07:31:40 +0000

 On Wed, Dec 01, 2010 at 06:35:01AM +0000, kre@munnari.OZ.AU wrote:
  > 	If we were to operate under the assumption that packages should
  > 	explicitly mention everything they use themselves, then there
  > 	are probably a bunch more includes needed (eg: I see nothing
  > 	that explicitly includes gtk2 yet openoffice2 clearly expects
  > 	to use that one - it gets included anyway, but should it be
  > 	explicit here?).

 As I understand the rules, if package X directly uses (explicitly
 links to, includes headers from, whatever) package Y, then package X
 should include Y's bl3.mk. Relying on the files being available
 because some other package Z also uses Y is wrong -- not only because
 as you've noticed it causes the build to break silently, but also
 because needed revbumps after shared library changes won't get done
 properly.

 So when you spot such cases, send them along...

 -- 
 David A. Holland
 dholland@netbsd.org

From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44178 CVS commit: pkgsrc/misc/openoffice2
Date: Thu, 2 Dec 2010 07:35:06 +0000

 Module Name:	pkgsrc
 Committed By:	dholland
 Date:		Thu Dec  2 07:35:05 UTC 2010

 Modified Files:
 	pkgsrc/misc/openoffice2: options.mk

 Log Message:
 Requires gdk-pixbuf2-xlib for gtk plugin. From PR 44178.


 To generate a diff of this commit:
 cvs rdiff -u -r1.27 -r1.28 pkgsrc/misc/openoffice2/options.mk

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/44178: misc/openoffice2 missing graphics/gdk-pixbuf2-xlib
 dependency (NetBSD 5) (possible fix)
Date: Thu, 2 Dec 2010 07:37:56 +0000

 On Wed, Dec 01, 2010 at 06:35:01AM +0000, kre@munnari.OZ.AU wrote:
  > 	And pkg_info shows that while graphics/gdk-pixbuf2 is installed,
  > 	graphics/gdk-pixbuf2-xlib is not.
  > 
  > 	I'm guessing that that once was added as a dependency of
  > 	something else, but whatever that something else was, no
  > 	lomger needs it, so it was dropped (which then wouldn't be
  > 	noticed in a "normal" build environment where just about
  > 	everything is installed all the time).

 However, what happened AFAIK is that gdk-pixbuf2 was split out of gtk2
 in the latest GNOME. I'm not clear on the exact role of
 gdk-pixbuf2-xlib, but I think it was part of gtk2 in the past also.

  > 	If we were to operate under the assumption that packages should
  > 	explicitly mention everything they use themselves, then there
  > 	are probably a bunch more includes needed (eg: I see nothing
  > 	that explicitly includes gtk2 yet openoffice2 clearly expects
  > 	to use that one - it gets included anyway, but should it be
  > 	explicit here?).

 ...however, in this case it's in options.mk.

 -- 
 David A. Holland
 dholland@netbsd.org

From: "Jeremy C. Reed" <reed@reedmedia.net>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/44178
Date: Mon, 6 Dec 2010 19:03:03 -0600 (CST)

 Is the  misc/openoffice2 missing graphics/gdk-pixbuf2-xlib dependency 
 fixed?

 http://gnats.netbsd.org/44178

From: Robert Elz <kre@munnari.OZ.AU>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/44178
Date: Tue, 07 Dec 2010 09:13:27 +0700

     Date:        Tue,  7 Dec 2010 01:05:03 +0000 (UTC)
     From:        "Jeremy C. Reed" <reed@reedmedia.net>
     Message-ID:  <20101207010503.6720A63B95F@www.NetBSD.org>

   |  Is the  misc/openoffice2 missing graphics/gdk-pixbuf2-xlib dependency 
   |  fixed?
   |  
   |  http://gnats.netbsd.org/44178

 I am fairly sure it is, the fix looks correct to me, but I don't really want
 to get into a 12 hour recompile just to verify that one if it is not
 essential...   So, go ahead and close the PR, if the unlikely event that
 there's a problem, either I or someone else can open another PR later
 (or have this one reopened.)

 Thanks,

 kre

State-Changed-From-To: open->closed
State-Changed-By: reed@NetBSD.org
State-Changed-When: Tue, 07 Dec 2010 02:55:56 +0000
State-Changed-Why:
Probably fixed.
Thanks for the report.


>Unformatted:

Home	PR Database Search