NetBSD Problem Report #44305

From jmmv@netbsd.org  Sat Jan  1 17:16:21 2011
Return-Path: <jmmv@netbsd.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 8369763B87A
	for <gnats-bugs@gnats.NetBSD.org>; Sat,  1 Jan 2011 17:16:21 +0000 (UTC)
Message-Id: <20110101171621.7381319CE28@mail.netbsd.org>
Date: Sat,  1 Jan 2011 17:16:21 +0000 (UTC)
From: jmmv@netbsd.org
Reply-To: jmmv@netbsd.org
To: gnats-bugs@gnats.NetBSD.org
Subject: Values of atf_arch and atf_machines are reversed
X-Send-Pr-Version: 3.95

>Number:         44305
>Category:       bin
>Synopsis:       Values of atf_arch and atf_machines are reversed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jmmv
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 01 17:20:00 +0000 2011
>Closed-Date:    Mon Sep 19 14:10:05 +0000 2011
>Last-Modified:  Mon Sep 19 14:10:05 +0000 2011
>Originator:     Julio Merino
>Release:        atf 0.12 (and head)
>Organization:
Julio Merino
>Environment:


System: NetBSD homeworld.netbsd.org 5.1_STABLE NetBSD 5.1_STABLE (NBMAIL_DOMU) #1: Sat Dec 25 13:12:37 UTC 2010 root@franklin.NetBSD.org:/home/netbsd/5/amd64/kern-compile/NBMAIL_DOMU amd64
Architecture: x86_64
Machine: amd64
>Description:
	The values of atf_arch and atf_machine do not match common sense.

	arch should refer to the CPU architecture whereas machine should
	refer to the machine type.  (I.e. there can be multiple machines
	with the same arch.)

	Unfortunately, for some weird historical reasons, this is not the
	case and the values of atf_arch and atf_machine are reversed.
	Kyua already does the right thing but we need to make ATF do this
	early so that we can correctly propagate the changes everywhere.
>How-To-Repeat:

>Fix:
	Reverse the definitions of atf_arch and atf_machine and adjust all
	existing test cases to reverse the definitions of these properties.

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: bin-bug-people->jmmv
Responsible-Changed-By: jmmv@NetBSD.org
Responsible-Changed-When: Sat, 01 Jan 2011 17:21:53 +0000
Responsible-Changed-Why:
My stuff; gotta fix this in the next atf release.


State-Changed-From-To: open->pending-pullups
State-Changed-By: jmmv@NetBSD.org
State-Changed-When: Sun, 20 Feb 2011 20:59:18 +0000
State-Changed-Why:
This should be now fixed.  Need to request a pullup, but I am waiting
for a test build to complete.


From: "Julio Merino" <jmmv@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44305 CVS commit: src/external/bsd/atf
Date: Sun, 20 Feb 2011 20:56:34 +0000

 Module Name:	src
 Committed By:	jmmv
 Date:		Sun Feb 20 20:56:34 UTC 2011

 Modified Files:
 	src/external/bsd/atf/dist/atf-config: integration_test.sh
 	src/external/bsd/atf/lib/libatf-c: Makefile

 Log Message:
 Fix the values of atf_arch and atf_machine: the former is supposed to be
 the cpu name and the latter the port name.  They had been reversed until
 now due to some "smart" stupidity^Wlogic in the upstream configure script,
 which is now gone.

 This is a pullup of revision f9329ca68da7e8557e0803b5747a12f8c10b1258
 plus the corresponding reachover build changes.

 Addresses PR bin/44305.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1.1.3 -r1.2 \
     src/external/bsd/atf/dist/atf-config/integration_test.sh
 cvs rdiff -u -r1.8 -r1.9 src/external/bsd/atf/lib/libatf-c/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Julio Merino" <jmmv@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44305 CVS commit: src/tests/lib/libc
Date: Sun, 20 Feb 2011 20:57:47 +0000

 Module Name:	src
 Committed By:	jmmv
 Date:		Sun Feb 20 20:57:46 UTC 2011

 Modified Files:
 	src/tests/lib/libc/gen: t_ldexp.c
 	src/tests/lib/libc/ieeefp: t_nan_inf.c

 Log Message:
 Adjust tests now that the values of atf_arch and atf_machine have been
 reversed to carry their real intended meanings.

 This is part of PR bin/44305.


 To generate a diff of this commit:
 cvs rdiff -u -r1.3 -r1.4 src/tests/lib/libc/gen/t_ldexp.c
 cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libc/ieeefp/t_nan_inf.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Jeff Rizzo" <riz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44305 CVS commit: [netbsd-5] src
Date: Tue, 8 Mar 2011 17:17:54 +0000

 Module Name:	src
 Committed By:	riz
 Date:		Tue Mar  8 17:17:54 UTC 2011

 Modified Files:
 	src/dist/atf/tests/atf/tools [netbsd-5]: t_atf_config.sh
 	src/lib/libatf-c [netbsd-5]: Makefile

 Log Message:
 Pull up following revision(s) (requested by jmmv in ticket #1563):
 	dist/atf/tests/atf/tools/t_atf_config.sh        patch
 	lib/libatf-c/Makefile                           patch

 Fix the values of atf_arch and atf_machine: the former is supposed to be
 the cpu name and the latter the port name.  They had been reversed until
 now due to some "smart" stupidity^Wlogic in the upstream configure script,
 which is now gone.
 This is a pullup of revision f9329ca68da7e8557e0803b5747a12f8c10b1258
 plus the corresponding reachover build changes.
 Addresses PR bin/44305.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1.1.3 -r1.1.1.3.6.1 \
     src/dist/atf/tests/atf/tools/t_atf_config.sh
 cvs rdiff -u -r1.2 -r1.2.4.1 src/lib/libatf-c/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: pending-pullups->closed
State-Changed-By: jmmv@NetBSD.org
State-Changed-When: Mon, 19 Sep 2011 14:10:05 +0000
State-Changed-Why:
I had missed that the pullups already happened.


>Unformatted:

Home	PR Database Search