NetBSD Problem Report #44395

From www@NetBSD.org  Sat Jan 15 15:44:21 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 5473863B966
	for <gnats-bugs@gnats.NetBSD.org>; Sat, 15 Jan 2011 15:44:21 +0000 (UTC)
Message-Id: <20110115154420.9ACE163B883@www.NetBSD.org>
Date: Sat, 15 Jan 2011 15:44:20 +0000 (UTC)
From: kanaoka@ann.hi-ho.ne.jp
Reply-To: kanaoka@ann.hi-ho.ne.jp
To: gnats-bugs@NetBSD.org
Subject: Request a bit patch for ale(4) driver.
X-Send-Pr-Version: www-1.0

>Number:         44395
>Category:       kern
>Synopsis:       Request a bit patch for ale(4) driver.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 15 15:45:00 +0000 2011
>Closed-Date:    Sat Jan 22 18:27:33 +0000 2011
>Last-Modified:  Sat Jan 22 18:30:02 +0000 2011
>Originator:     Masanori Kanaoka
>Release:        NetBSD 5.99.43/i386
>Organization:
>Environment:
NetBSD white.k.vnop.net 5.99.43 NetBSD 5.99.43 (GENERIC) #3: Sun Jan 16 00:01:17 JST 2011  root@white.k.vnop.net:/usr/obj/sys/arch/i386/compile/GENERIC i386

>Description:
Would you please apply a bit patch for ale(4) driver.

a bit patch include below:
 - Fix register address in ale_phy_reset(). from linux
 - Fix ale_flags(s/FASTETHER/JUMBO/) for L2E Rev. A. from linux
 - Fix mask value in ale_stop_mac().
 - Fix multicast handling. from openbsd


>How-To-Repeat:

>Fix:
Index: sys/dev/pci/if_ale.c
===================================================================
RCS file: /ftp/cvs/src/sys/dev/pci/if_ale.c,v
retrieving revision 1.12
diff -u -r1.12 if_ale.c
--- sys/dev/pci/if_ale.c        20 Jul 2010 09:17:24 -0000      1.12
+++ sys/dev/pci/if_ale.c        15 Jan 2011 14:49:48 -0000
@@ -367,12 +367,12 @@
        ale_miibus_writereg(sc->sc_dev, sc->ale_phyaddr,
            ATPHY_DBG_ADDR, 0x04);
        ale_miibus_writereg(sc->sc_dev, sc->ale_phyaddr,
-           ATPHY_DBG_ADDR, 0x8BBB);
+           ATPHY_DBG_DATA, 0x8BBB);
        /* 10BT center tap voltage. */
        ale_miibus_writereg(sc->sc_dev, sc->ale_phyaddr,
            ATPHY_DBG_ADDR, 0x05);
        ale_miibus_writereg(sc->sc_dev, sc->ale_phyaddr,
-           ATPHY_DBG_ADDR, 0x2C46);
+           ATPHY_DBG_DATA, 0x2C46);

 #undef ATPHY_DBG_ADDR
 #undef ATPHY_DBG_DATA
@@ -461,7 +461,7 @@
                        chipname = "AR8121 (L1E)";
                } else {
                        /* L2E Rev. A. AR8113 */
-                       sc->ale_flags |= ALE_FLAG_FASTETHER;
+                       sc->ale_flags |= ALE_FLAG_JUMBO;
                        chipname = "AR8113 (L2E RevA)";
                }
        }

@@ -1910,7 +1910,7 @@

        reg = CSR_READ_4(sc, ALE_MAC_CFG);
        if ((reg & (MAC_CFG_TX_ENB | MAC_CFG_RX_ENB)) != 0) {
-               reg &= ~MAC_CFG_TX_ENB | MAC_CFG_RX_ENB;
+               reg &= ~(MAC_CFG_TX_ENB | MAC_CFG_RX_ENB);
                CSR_WRITE_4(sc, ALE_MAC_CFG, reg);
        }
 @@ -2015,7 +2015,7 @@

                ETHER_FIRST_MULTI(step, ec, enm);
                while (enm != NULL) {
-                       crc = ether_crc32_le(enm->enm_addrlo, ETHER_ADDR_LEN)
+                       crc = ether_crc32_be(enm->enm_addrlo, ETHER_ADDR_LEN)
                        mchash[crc >> 31] |= 1 << ((crc >> 26) & 0x1f);
                        ETHER_NEXT_MULTI(step, enm);
                }


>Release-Note:

>Audit-Trail:
From: Masanori Kanaoka <kanaoka@ann.hi-ho.ne.jp>
To: gnats-bugs@NetBSD.org, gnats-admin@netbsd.org
Cc: 
Subject: Re: kern/44395: Request a bit patch for ale(4) driver.
Date: Thu, 20 Jan 2011 00:23:17 +0900 (JST)

 Hi

 I update a patch for ale(4) and atphy(4).
 Would you please apply it.

 ---
  Masanori Kanaoka        kanaoka AT ann.hi-ho.ne.jp


 Index: sys/dev/mii/atphy.c
 ===================================================================
 RCS file: /ftp/cvs/src/sys/dev/mii/atphy.c,v
 retrieving revision 1.7
 diff -u -r1.7 atphy.c
 --- sys/dev/mii/atphy.c	11 Dec 2010 18:10:16 -0000	1.7
 +++ sys/dev/mii/atphy.c	19 Jan 2011 14:58:21 -0000
 @@ -118,6 +118,7 @@
  	struct mii_attach_args *ma = aux;
  	struct mii_data *mii = ma->mii_data;
  	const struct mii_phydesc *mpd;
 +	uint16_t bmsr;

  	mpd = mii_phy_match(ma, etphys);
  	aprint_naive(": Media interface\n");
 @@ -135,7 +136,8 @@

  	PHY_RESET(sc);

 -	sc->mii_capabilities = PHY_READ(sc, MII_BMSR) & ma->mii_capmask;
 +	bmsr = PHY_READ(sc, MII_BMSR) | PHY_READ(sc, MII_BMSR);
 +	sc->mii_capabilities = bmsr & ma->mii_capmask;
  	if (sc->mii_capabilities & BMSR_EXTSTAT)
  		sc->mii_extcapabilities = PHY_READ(sc, MII_EXTSR);

 @@ -220,8 +222,7 @@
  		/*
  		 * Reset the PHY so all changes take effect.
  		 */
 -		PHY_WRITE(sc, MII_BMCR, bmcr | BMCR_RESET | BMCR_AUTOEN |
 -		    BMCR_STARTNEG);
 +		PHY_WRITE(sc, MII_BMCR, bmcr |  BMCR_AUTOEN | BMCR_STARTNEG);
  done:
  		break;

 @@ -364,9 +365,13 @@
  	reg |= ATPHY_SCR_POLARITY_REVERSAL;
  	PHY_WRITE(sc, ATPHY_SCR, reg);

 -	/* Workaround F1 bug to reset phy. */
  	atphy_mii_phy_auto(sc);

 +	/* Workaround F1 bug to reset phy. */
 +	reg = PHY_READ(sc, MII_BMCR);
 +	reg |= BMCR_RESET;
 +	PHY_WRITE(sc, MII_BMCR, reg);
 +
  	for (i = 0; i < 1000; i++) {
  		DELAY(1);
  		if ((PHY_READ(sc, MII_BMCR) & BMCR_RESET) == 0)
 @@ -386,7 +391,7 @@
  	if (sc->mii_extcapabilities & (EXTSR_1000TFDX | EXTSR_1000THDX))
  		PHY_WRITE(sc, MII_100T2CR, GTCR_ADV_1000TFDX |
  		    GTCR_ADV_1000THDX);
 -	PHY_WRITE(sc, MII_BMCR, BMCR_RESET | BMCR_AUTOEN | BMCR_STARTNEG);
 +	PHY_WRITE(sc, MII_BMCR, BMCR_AUTOEN | BMCR_STARTNEG);

  	return EJUSTRETURN;
  }
 Index: sys/dev/pci/if_ale.c
 ===================================================================
 RCS file: /ftp/cvs/src/sys/dev/pci/if_ale.c,v
 retrieving revision 1.12
 diff -u -r1.12 if_ale.c
 --- sys/dev/pci/if_ale.c	20 Jul 2010 09:17:24 -0000	1.12
 +++ sys/dev/pci/if_ale.c	19 Jan 2011 15:00:13 -0000
 @@ -367,12 +367,12 @@
  	ale_miibus_writereg(sc->sc_dev, sc->ale_phyaddr,
  	    ATPHY_DBG_ADDR, 0x04);
  	ale_miibus_writereg(sc->sc_dev, sc->ale_phyaddr,
 -	    ATPHY_DBG_ADDR, 0x8BBB);
 +	    ATPHY_DBG_DATA, 0x8BBB);
  	/* 10BT center tap voltage. */
  	ale_miibus_writereg(sc->sc_dev, sc->ale_phyaddr,
  	    ATPHY_DBG_ADDR, 0x05);
  	ale_miibus_writereg(sc->sc_dev, sc->ale_phyaddr,
 -	    ATPHY_DBG_ADDR, 0x2C46);
 +	    ATPHY_DBG_DATA, 0x2C46);

  #undef	ATPHY_DBG_ADDR
  #undef	ATPHY_DBG_DATA
 @@ -1910,7 +1910,7 @@

  	reg = CSR_READ_4(sc, ALE_MAC_CFG);
  	if ((reg & (MAC_CFG_TX_ENB | MAC_CFG_RX_ENB)) != 0) {
 -		reg &= ~MAC_CFG_TX_ENB | MAC_CFG_RX_ENB;
 +		reg &= ~(MAC_CFG_TX_ENB | MAC_CFG_RX_ENB);
  		CSR_WRITE_4(sc, ALE_MAC_CFG, reg);
  	}

 @@ -2015,7 +2015,7 @@

  		ETHER_FIRST_MULTI(step, ec, enm);
  		while (enm != NULL) {
 -			crc = ether_crc32_le(enm->enm_addrlo, ETHER_ADDR_LEN);
 +			crc = ether_crc32_be(enm->enm_addrlo, ETHER_ADDR_LEN);
  			mchash[crc >> 31] |= 1 << ((crc >> 26) & 0x1f);
  			ETHER_NEXT_MULTI(step, enm);
  		}


From: "Christoph Egger" <cegger@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44395 CVS commit: src/sys/dev
Date: Sat, 22 Jan 2011 08:13:48 +0000

 Module Name:	src
 Committed By:	cegger
 Date:		Sat Jan 22 08:13:47 UTC 2011

 Modified Files:
 	src/sys/dev/mii: atphy.c
 	src/sys/dev/pci: if_ale.c

 Log Message:
 Fixes from PR kern/44395 Masanori Kanaoka:
 - Fix register address in ale_phy_reset(). from linux
 - Fix mask value in ale_stop_mac().
 - Fix multicast handling. from openbsd
 - Fix phy reset handling.


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 src/sys/dev/mii/atphy.c
 cvs rdiff -u -r1.12 -r1.13 src/sys/dev/pci/if_ale.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: cegger@NetBSD.org
State-Changed-When: Sat, 22 Jan 2011 08:27:03 +0000
State-Changed-Why:
Patch applied. Does the driver work for you?


From: Masanori Kanaoka <kanaoka@ann.hi-ho.ne.jp>
To: gnats-bugs@NetBSD.org, cegger@NetBSD.org
Cc: kern-bug-people@netbsd.org, netbsd-bugs@netbsd.org, gnats-admin@netbsd.org
Subject: Re: kern/44395 (Request a bit patch for ale(4) driver.)
Date: Sun, 23 Jan 2011 01:05:37 +0900 (JST)

 Hi,

 Thank you for your efforts!

        From: cegger@NetBSD.org
     Subject: Re: kern/44395 (Request a bit patch for ale(4) driver.)
       Date : Sat, 22 Jan 2011 08:27:03 +0000 (UTC)
  Message-ID: <20110122082703.E875663B873@www.NetBSD.org>

 $ Synopsis: Request a bit patch for ale(4) driver.
 $ 
 $ State-Changed-From-To: open->feedback
 $ State-Changed-By: cegger@NetBSD.org
 $ State-Changed-When: Sat, 22 Jan 2011 08:27:03 +0000
 $ State-Changed-Why:
 $ Patch applied. Does the driver work for you?

 Yes.
 The driver works fne for me.

 I think that it may need next patch for comment.

 Best Regards!
 ---
  Masanori Kanaoka        kanaoka AT ann.hi-ho.ne.jp


 --- atphy.c.orig        2011-01-23 00:18:56.000000000 +0900
 +++ atphy.c     2011-01-23 00:21:24.000000000 +0900
 @@ -220,7 +220,7 @@
                 PHY_WRITE(sc, MII_ANAR, anar);

                 /*
 -                * Reset the PHY so all changes take effect.
 +                * Start autonegotiation.
                  */
                 PHY_WRITE(sc, MII_BMCR, bmcr | BMCR_AUTOEN | BMCR_STARTNEG);

State-Changed-From-To: feedback->closed
State-Changed-By: cegger@NetBSD.org
State-Changed-When: Sat, 22 Jan 2011 18:27:33 +0000
State-Changed-Why:
patches applied. thanks.


From: "Christoph Egger" <cegger@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44395 CVS commit: src/sys/dev/mii
Date: Sat, 22 Jan 2011 18:26:12 +0000

 Module Name:	src
 Committed By:	cegger
 Date:		Sat Jan 22 18:26:12 UTC 2011

 Modified Files:
 	src/sys/dev/mii: atphy.c

 Log Message:
 fix comment. from PR kern/44395


 To generate a diff of this commit:
 cvs rdiff -u -r1.8 -r1.9 src/sys/dev/mii/atphy.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.