NetBSD Problem Report #44423

From Wolfgang.Stukenbrock@nagler-company.com  Thu Jan 20 09:34:24 2011
Return-Path: <Wolfgang.Stukenbrock@nagler-company.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 9BB7263B883
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 20 Jan 2011 09:34:24 +0000 (UTC)
Message-Id: <20110120093415.B34B61E80CE@test-s0.nagler-company.com>
Date: Thu, 20 Jan 2011 10:34:15 +0100 (CET)
From: Wolfgang.Stukenbrock@nagler-company.com
Reply-To: Wolfgang.Stukenbrock@nagler-company.com
To: gnats-bugs@gnats.NetBSD.org
Subject: ALTQ uses own option for IPSEC - should use IPSEC and/or FAST_IPSEC
X-Send-Pr-Version: 3.95

>Number:         44423
>Category:       kern
>Synopsis:       ALTQ uses own option for IPSEC - should use IPSEC and/or FAST_IPSEC
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 20 09:35:00 +0000 2011
>Originator:     Dr. W. Stukenbrock
>Release:        NetBSD 5.1
>Organization:
Dr. Nagler & Company GmbH
>Environment:


System: NetBSD test-s0 4.0 NetBSD 4.0 (NSW-WS) #0: Tue Aug 17 17:28:09 CEST 2010 wgstuken@test-s0:/usr/src/sys/arch/amd64/compile/NSW-WS amd64
Architecture: x86_64
Machine: amd64
>Description:
	When useing ALTQ and IPSEC or FAST_IPSEC together, the additional option ALTQ_IPSEC must be defined.
	Due to the fact that this option is not present in any kernel config file, nobody normaly knows
	that this one has to be defined too.
	It would be better to have only on set of options IPSEC/FAST_IPSEC that needs to be turned on
	in order to have IPSEC-support in all parts of the kernel.
>How-To-Repeat:
	Found be a look into the sources.
>Fix:
	remove ALTQ_IPSEC option and replace it with IPSEC and/or FAST_IPSEC

	in /usr/src/sys/altq/altq_subr.c
	line 912 and line 936
	-- #ifdef ALTQ_IPSEC
	++ #if defined(IPSEC) || defined(FAST_IPSEC)
	in /usr/src/sys/altq/files.altq
	line 6
	--                                ALTQ_IPSEC ALTQ_LOCALQ ALTQ_RED ALTQ_RIO
	++                                ALTQ_LOCALQ ALTQ_RED ALTQ_RIO

	This should eleminate ALTQ_IPSEC option. I assume (and I think I'm right) that "make depend" detects the
	dependency of altq_subr.c to IPSEC and FAST_IPSEC correctly.
	This description assumes that ALTQ needs the IPSEC-support for both, IPSEC and FAST_IPSEC

>Unformatted:

Home	PR Database Search