NetBSD Problem Report #44469

From www@NetBSD.org  Wed Jan 26 15:47:47 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 7E48E63B883
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 26 Jan 2011 15:47:47 +0000 (UTC)
Message-Id: <20110126154746.A82A863B873@www.NetBSD.org>
Date: Wed, 26 Jan 2011 15:47:46 +0000 (UTC)
From: james_r-netbsdpr@jump.org.uk
Reply-To: james_r-netbsdpr@jump.org.uk
To: gnats-bugs@NetBSD.org
Subject: djbdns package ipv6 patch uses deprecated ip6.int rather than ip6.arpa
X-Send-Pr-Version: www-1.0

>Number:         44469
>Category:       pkg
>Synopsis:       djbdns package ipv6 patch uses deprecated ip6.int rather than ip6.arpa
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    schmonz
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Jan 26 15:50:00 +0000 2011
>Closed-Date:    Thu Jun 09 00:57:40 +0000 2011
>Last-Modified:  Thu Jun 09 01:00:03 +0000 2011
>Originator:     James A. T. Rice
>Release:        
>Organization:
>Environment:
>Description:
The djbdns package uses the following ipv6 patch:
http://ftp.netbsd.org/pub/NetBSD/packages/distfiles/djbdns-1.05-ipv6.diff.bz2

which appears to be the authors first version of said patch, at:
http://www.fefe.de/dns/djbdns-1.05-ipv6.diff.bz2

the latest version, as of 2011-01-26 is from 2005-09-08, at:
http://www.fefe.de/dns/djbdns-1.05-test23.diff.bz2

This incorporates changes such as IPv6 reverse DNS being in
ip6.arpa rather than ip6.int (which was deprecated in 2006).



Another change incorporated is between
http://www.fefe.de/dns/djbdns-1.05-test7.diff.bz2
http://www.fefe.de/dns/djbdns-1.05-test8.diff.bz2

which had the following changes:

djbdns-1.05/dns.h
< +#define DNS_NAME6_DOMAIN (4*16+15)
---
> +#define DNS_NAME6_DOMAIN (4*16+10)

djbdns-1.05/dns_nd6.c
< +  byte_copy(name + 4*16,14,"\3ip6\3int\0");
< +  return 4*16+14;
---
> +  byte_copy(name + 4*16,9,"\3ip6\3int\0");
> +  return 4*16+9;

which seems to fix reading past the end of the constant string,
I have no idea if this also has security implications.


>How-To-Repeat:

>Fix:
Consider incorporating changes which are present in
http://www.fefe.de/dns/djbdns-1.05-test23.diff.bz2

Thanks
James

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->schmonz
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Tue, 01 Feb 2011 08:53:47 +0000
Responsible-Changed-Why:
Over to maintainer.


State-Changed-From-To: open->closed
State-Changed-By: schmonz@NetBSD.org
State-Changed-When: Thu, 09 Jun 2011 00:57:40 +0000
State-Changed-Why:
Updated the patch as suggested. Happy IPV6 Day, and thanks for the PR!


From: "Amitai Schlair" <schmonz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44469 CVS commit: pkgsrc/net/djbdns
Date: Thu, 9 Jun 2011 00:55:41 +0000

 Module Name:	pkgsrc
 Committed By:	schmonz
 Date:		Thu Jun  9 00:55:41 UTC 2011

 Modified Files:
 	pkgsrc/net/djbdns: Makefile PLIST.inet6 distinfo options.mk
 	pkgsrc/net/djbdns/patches: patch-aa patch-ab patch-ac patch-ad

 Log Message:
 Update ipv6 patch. Closes PR pkg/44469 by James A. T. Rice. While
 here, fix indentation broken in previous and quell pkglint.


 To generate a diff of this commit:
 cvs rdiff -u -r1.60 -r1.61 pkgsrc/net/djbdns/Makefile
 cvs rdiff -u -r1.1 -r1.2 pkgsrc/net/djbdns/PLIST.inet6
 cvs rdiff -u -r1.18 -r1.19 pkgsrc/net/djbdns/distinfo
 cvs rdiff -u -r1.14 -r1.15 pkgsrc/net/djbdns/options.mk
 cvs rdiff -u -r1.2 -r1.3 pkgsrc/net/djbdns/patches/patch-aa \
     pkgsrc/net/djbdns/patches/patch-ab
 cvs rdiff -u -r1.5 -r1.6 pkgsrc/net/djbdns/patches/patch-ac
 cvs rdiff -u -r1.3 -r1.4 pkgsrc/net/djbdns/patches/patch-ad

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search