NetBSD Problem Report #44485

From ryo_on@yk.rim.or.jp  Sat Jan 29 17:12:15 2011
Return-Path: <ryo_on@yk.rim.or.jp>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 3AF3963B873
	for <gnats-bugs@gnats.netbsd.org>; Sat, 29 Jan 2011 17:12:15 +0000 (UTC)
Message-Id: <20110129171215.3AF3963B873@www.NetBSD.org>
Date: Sat, 29 Jan 2011 17:12:15 +0000 (UTC)
From: ryoon@NetBSD.org
Reply-To: ryoon@NetBSD.org
To: gnats-bugs@gnats.NetBSD.org
Subject: EMACSLOADPATH is not valid for editores/emacs21
X-Send-Pr-Version: 3.95

>Number:         44485
>Category:       pkg
>Synopsis:       EMACSLOADPATH is not valid for editores/emacs21
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jan 29 17:15:00 +0000 2011
>Closed-Date:    Wed Feb 09 13:33:16 +0000 2011
>Last-Modified:  Wed Feb 09 13:33:16 +0000 2011
>Originator:     Ryo ONODERA
>Release:        NetBSD 5.99.44
>Organization:

>Environment:


System: NetBSD hydrogen.elements.tetera.org 5.99.44 NetBSD 5.99.44 (LEAFGIRL2) #0: Sat Jan 29 21:02:08 JST 2011 root@hydrogen.elements.tetera.org:/usr/obj/sys/arch/i386/compile/LEAFGIRL2 i386
Architecture: i386
Machine: i386
>Description:
editors/emacs/modules.mk has
EMACSLOADPATH=${_EMACS_DIR}/${_EMACS_VERSION_DIR}/lisp:${_EMACS_DIR}/site-lisp .
For editors/emacs21, _EMACS_VERSION_DIR is 21.4a.
But EMACSLOADPATH should be 21.4 instead of 21.4a.

Probably some elisp package will fail to build.

My upcoming package, inputmethod/skk 14.2, fails to build.

>How-To-Repeat:

>Fix:

Index: modules.mk
===================================================================
RCS file: /cvsroot/pkgsrc/editors/emacs/modules.mk,v
retrieving revision 1.13
diff -u -r1.13 modules.mk
--- modules.mk	25 Oct 2010 00:03:03 -0000	1.13
+++ modules.mk	29 Jan 2011 17:11:49 -0000
@@ -348,7 +348,7 @@
 	${SED} -e 's/emacs-//' |					\
 	${SED} -e 's/\.[0-9]\{8,\}//' |					\
 	${SED} -e 's/nb.*//'
-ALL_ENV+=	EMACSLOADPATH=${_EMACS_DIR}/${_EMACS_VERSION_DIR}/lisp:${_EMACS_DIR}/site-lisp
+ALL_ENV+=	EMACSLOADPATH=${_EMACS_DIR}/${_EMACS_VERSION_MAJOR}.${_EMACS_VERSION_MINOR}/lisp:${_EMACS_DIR}/site-lisp
 .include	"${_EMACS_PKGDIR}/buildlink3.mk"
 .endif



>Release-Note:

>Audit-Trail:
From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/44485: EMACSLOADPATH is not valid for editores/emacs21
Date: Mon, 31 Jan 2011 06:42:28 +0000

 On Sat, Jan 29, 2011 at 05:15:00PM +0000, ryoon@NetBSD.org wrote:
  > Index: modules.mk
  > ===================================================================
  > RCS file: /cvsroot/pkgsrc/editors/emacs/modules.mk,v
  > retrieving revision 1.13
  > diff -u -r1.13 modules.mk
  > --- modules.mk	25 Oct 2010 00:03:03 -0000	1.13
  > +++ modules.mk	29 Jan 2011 17:11:49 -0000
  > @@ -348,7 +348,7 @@
  >  	${SED} -e 's/emacs-//' |					\
  >  	${SED} -e 's/\.[0-9]\{8,\}//' |					\
  >  	${SED} -e 's/nb.*//'
  > -ALL_ENV+=	EMACSLOADPATH=${_EMACS_DIR}/${_EMACS_VERSION_DIR}/lisp:${_EMACS_DIR}/site-lisp
  > +ALL_ENV+=	EMACSLOADPATH=${_EMACS_DIR}/${_EMACS_VERSION_MAJOR}.${_EMACS_VERSION_MINOR}/lisp:${_EMACS_DIR}/site-lisp
  >  .include	"${_EMACS_PKGDIR}/buildlink3.mk"
  >  .endif

 Looks ok to me...

 -- 
 David A. Holland
 dholland@netbsd.org

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/44485: EMACSLOADPATH is not valid for editores/emacs21
Date: Tue, 01 Feb 2011 17:46:45 +0900

 On Mon, 31 Jan 2011 15:45:02 +0900, David Holland <dholland-pbugs@netbsd.org> wrote:

 > The following reply was made to PR pkg/44485; it has been noted by GNATS.
 >
 > From: David Holland <dholland-pbugs@netbsd.org>
 > To: gnats-bugs@NetBSD.org
 > Cc:
 > Subject: Re: pkg/44485: EMACSLOADPATH is not valid for editores/emacs21
 > Date: Mon, 31 Jan 2011 06:42:28 +0000
 >
 >  On Sat, Jan 29, 2011 at 05:15:00PM +0000, ryoon@NetBSD.org wrote:
 >   > Index: modules.mk
 >   > ===================================================================
 >   > RCS file: /cvsroot/pkgsrc/editors/emacs/modules.mk,v
 >   > retrieving revision 1.13
 >   > diff -u -r1.13 modules.mk
 >   > --- modules.mk	25 Oct 2010 00:03:03 -0000	1.13
 >   > +++ modules.mk	29 Jan 2011 17:11:49 -0000
 >   > @@ -348,7 +348,7 @@
 >   >  	${SED} -e 's/emacs-//' |					\
 >   >  	${SED} -e 's/\.[0-9]\{8,\}//' |					\
 >   >  	${SED} -e 's/nb.*//'
 >   > -ALL_ENV+=	EMACSLOADPATH=${_EMACS_DIR}/${_EMACS_VERSION_DIR}/lisp:${_EMACS_DIR}/site-lisp
 >   > +ALL_ENV+=	EMACSLOADPATH=${_EMACS_DIR}/${_EMACS_VERSION_MAJOR}.${_EMACS_VERSION_MINOR}/lisp:${_EMACS_DIR}/site-lisp
 >   >  .include	"${_EMACS_PKGDIR}/buildlink3.mk"
 >   >  .endif
 > Looks ok to me...

 If so, _EMACS_VERSION_DIR will no need to be defined dynamically,
 then, it should be gone away, or defined statically instead.
 If not, SED patterns for _EMACS_VERSION_DIR should be added to
 strip the tail of 'a' for emacs21.

 -- 
 OBATA Akio / obache@NetBSD.org

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/44485: EMACSLOADPATH is not valid for editores/emacs21
Date: Tue, 01 Feb 2011 21:12:21 +0900

 On Tue, 01 Feb 2011 17:50:04 +0900, OBATA Akio <obache@netbsd.org> wrote:

 >  If so, _EMACS_VERSION_DIR will no need to be defined dynamically,
 >  then, it should be gone away, or defined statically instead.
 >  If not, SED patterns for _EMACS_VERSION_DIR should be added to
 >  strip the tail of 'a' for emacs21.

 Ah, It is required to retrieve emacs version from installed on.
 maybe, current, newest emacs version may not be installed.
 for examples,
 _EMACS_REQD= emacs>=21<22
 in editors/emacs21.
 so, if installed emacs21 is emacs-21.3, ${_EMACS_VERSION_DIR} should be 21.3,
 not ${_EMACS_VERSION_MAJOR}.${_EMACS_VERSION_MINOR}, i.e. 21.4

 -- 
 OBATA Akio / obache@NetBSD.org

From: Ryo ONODERA <ryo_on@yk.rim.or.jp>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/44485: EMACSLOADPATH is not valid for editores/emacs21
Date: Wed, 02 Feb 2011 07:09:45 +0900 (JST)

 Hi,

 uebayashi@'s patch in tech-pkg-jp@jp.NetBSD.org looks good for me.

 http://www.jp.netbsd.org/ja/JP/ml/tech-pkg-ja/201102/msg00003.html

 Thank you.

 --
 Ryo ONODERA // ryo_on@yk.rim.or.jp
 PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3


From: HIRAMATSU Yoshifumi <hiramatu@boreas.dti.ne.jp>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/44485
Date: Tue, 08 Feb 2011 22:39:23 +0900

 I commited fix for this PR.

 http://mail-index.netbsd.org/pkgsrc-changes/2011/02/08/msg051772.html

 Can i close this PR?

From: Ryo ONODERA <ryo_on@yk.rim.or.jp>
To: gnats-bugs@NetBSD.org, hiramatu@boreas.dti.ne.jp
Cc: 
Subject: Re: pkg/44485
Date: Wed, 09 Feb 2011 21:40:44 +0900 (JST)

 Hi,

 PR pkg/44485 is fixed.
 Please close this PR.
 Thank you.


State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 09 Feb 2011 13:33:16 +0000
State-Changed-Why:
Confirmed fixed, thanks.


>Unformatted:

Home	PR Database Search