NetBSD Problem Report #44665

From www@NetBSD.org  Wed Mar  2 12:46:35 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 0CC6B63B8E0
	for <gnats-bugs@gnats.NetBSD.org>; Wed,  2 Mar 2011 12:46:35 +0000 (UTC)
Message-Id: <20110302124634.1B41D63B8CE@www.NetBSD.org>
Date: Wed,  2 Mar 2011 12:46:34 +0000 (UTC)
From: jasper@pointless.net
Reply-To: jasper@pointless.net
To: gnats-bugs@NetBSD.org
Subject: spdmem debug output is a bit mangled
X-Send-Pr-Version: www-1.0

>Number:         44665
>Category:       kern
>Synopsis:       spdmem debug output is a bit mangled
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Mar 02 12:50:00 +0000 2011
>Closed-Date:    Wed Jul 31 15:01:04 +0000 2013
>Last-Modified:  Wed Jul 31 15:01:04 +0000 2013
>Originator:     Jasper Wallace
>Release:        -current
>Organization:
Pointless.net
>Environment:
NetBSD monstrosity 5.99.45 NetBSD 5.99.45 (MONSTROSITY) #19: Wed Mar  2 12:42:56 GMT 2011  jasper@limpit:/home/jasper/develop/netbsd/netbsd-src-and-build/tree/l.64/obj/sys/arch/amd64/compile/MONSTROSITY amd64
>Description:
The debug output of spdmem calculates the length of hex to print wrong so it prints too much repeatedly.

>How-To-Repeat:
compile a kernel with spdmem at iic and DEBUG and look at the spdmem dmesg output.

>Fix:
Index: spdmem.c
===================================================================
RCS file: /cvsroot/src/sys/dev/ic/spdmem.c,v
retrieving revision 1.2
diff -u -u -r1.2 spdmem.c
--- spdmem.c    29 Jun 2010 04:42:30 -0000      1.2
+++ spdmem.c    2 Mar 2011 10:09:20 -0000
@@ -265,7 +265,7 @@
                int j, k;
                aprint_debug("\n");
                aprint_debug_dev(self, "0x%02x:", i);
-               k = (spd_len > i + 16) ? spd_len : i + 16;
+               k = (spd_len > (i + 16)) ? i + 16 : spd_len;
                for (j = i; j < k; j++)
                        aprint_debug(" %02x", ((uint8_t *)s)[j]);
        }

>Release-Note:

>Audit-Trail:
From: "Soren S. Jorvang" <soren@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44665 CVS commit: src/sys/dev/ic
Date: Fri, 19 Jul 2013 01:02:49 +0000

 Module Name:	src
 Committed By:	soren
 Date:		Fri Jul 19 01:02:49 UTC 2013

 Modified Files:
 	src/sys/dev/ic: spdmem.c spdmemvar.h

 Log Message:
 Print the part number for DDR3 modules.

 Also closes PR kern/44665.


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 src/sys/dev/ic/spdmem.c
 cvs rdiff -u -r1.2 -r1.3 src/sys/dev/ic/spdmemvar.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: soren@NetBSD.org
State-Changed-When: Wed, 31 Jul 2013 15:01:04 +0000
State-Changed-Why:


>Unformatted:

Home	PR Database Search