NetBSD Problem Report #44720

From www@NetBSD.org  Mon Mar 14 02:17:12 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 1A65863B92A
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 14 Mar 2011 02:17:12 +0000 (UTC)
Message-Id: <20110314021711.6F10C63B874@www.NetBSD.org>
Date: Mon, 14 Mar 2011 02:17:11 +0000 (UTC)
From: aran@100acres.us
Reply-To: aran@100acres.us
To: gnats-bugs@NetBSD.org
Subject: Build error in x86/x86/mpacpi.c
X-Send-Pr-Version: www-1.0

>Number:         44720
>Category:       port-i386
>Synopsis:       Build error in x86/x86/mpacpi.c
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    port-i386-maintainer
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 14 02:20:00 +0000 2011
>Closed-Date:    Wed Mar 16 06:06:32 +0000 2011
>Last-Modified:  Wed Mar 16 06:06:32 +0000 2011
>Originator:     Aran Clauson
>Release:        5.99.47
>Organization:
>Environment:
NetBSD piglet 5.99.47 NetBSD 5.99.47 (PIGLET) #0: Sun Mar 13 03:33:50 PDT 2011  root@piglet:/home/NetBSD/obj/sys/arch/i386/compile/PIGLET i386
>Description:
When building a minimally configured kernel I get warnings, which are treated as errors, in x86/x86/mpacpi.c:mpacpi_get_bbn.  The local variables  class, dvid, and tag are unused.
>How-To-Repeat:
I am unsure of the configuration options that sets NPCHB equal to zero, but configure the kernel thus and compile.
>Fix:
Index: sys/arch/x86/x86/mpacpi.c
===================================================================
RCS file: /cvsroot/src/sys/arch/x86/x86/mpacpi.c,v
retrieving revision 1.89
diff -u -r1.89 mpacpi.c
--- sys/arch/x86/x86/mpacpi.c   7 Aug 2010 09:41:19 -0000       1.89
+++ sys/arch/x86/x86/mpacpi.c   14 Mar 2011 02:16:46 -0000
@@ -524,9 +524,10 @@
 {
        ACPI_STATUS rv;
        ACPI_INTEGER val;
+#if NPCHB > 0
        pcireg_t class, dvid;
        pcitag_t tag;
-
+#endif
        rv = acpi_eval_integer(handle, METHOD_NAME__BBN, &val);
        if (ACPI_SUCCESS(rv))
                *bus = ACPI_LOWORD(val);

>Release-Note:

>Audit-Trail:
From: "David A. Holland" <dholland@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44720 CVS commit: src/sys/arch/x86/x86
Date: Wed, 16 Mar 2011 06:02:37 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Wed Mar 16 06:02:37 UTC 2011

 Modified Files:
 	src/sys/arch/x86/x86: mpacpi.c

 Log Message:
 Fix build with no pchb. From Aran Clauson in PR 44720.


 To generate a diff of this commit:
 cvs rdiff -u -r1.89 -r1.90 src/sys/arch/x86/x86/mpacpi.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Wed, 16 Mar 2011 06:06:32 +0000
State-Changed-Why:
fixed, thanks.


>Unformatted:

Home	PR Database Search