NetBSD Problem Report #44776

From www@NetBSD.org  Sun Mar 27 18:53:58 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 9A92263BFE0
	for <gnats-bugs@gnats.NetBSD.org>; Sun, 27 Mar 2011 18:53:58 +0000 (UTC)
Message-Id: <20110327185357.B0BD163BFDC@www.NetBSD.org>
Date: Sun, 27 Mar 2011 18:53:57 +0000 (UTC)
From: kiers@original.xs4all.nl
Reply-To: kiers@original.xs4all.nl
To: gnats-bugs@NetBSD.org
Subject: dual fiber i82546GB (wm) worked in NetBSD-4, not in -5, nor in -current
X-Send-Pr-Version: www-1.0

>Number:         44776
>Category:       kern
>Synopsis:       dual fiber i82546GB (wm) worked in NetBSD-4, not in -5, nor in -current
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    msaitoh
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 27 18:55:00 +0000 2011
>Closed-Date:    Sun Apr 05 20:10:39 +0000 2015
>Last-Modified:  Thu Apr 30 20:05:01 +0000 2015
>Originator:     Bert Kiers
>Release:        5.1 GENERIC i386
>Organization:
XS4ALL
>Environment:
NetBSD mammalou.boppelans.net 5.1 NetBSD 5.1 (GENERIC) #0: Sun Nov  7 14:39:56 UTC 2010  builds@b6.netbsd.org:/home/builds/ab/netbsd-5-1-RELEASE/i386/201011061943Z-obj/home/builds/ab/netbsd-5-1-RELEASE/src/sys/arch/i386/compile/GENERIC i386
>Description:
dual fiber i82546GB (wm(4), Intel PRO/1000 MF Server Adapter) worked in NetBSD-4.0.2, but not in NetBSD-5.0.2, nor in -current

Hardware is a Soekris 5501, switch is HP 1800-24G

Card is probed in NetBSD-4 as:
wm1 at pci0 dev 14 function 1: Intel i82546GB 1000BASE-X Ethernet, rev. 3
wm1: interrupting at irq 15
wm1: Ethernet address 00:04:23:ae:2a:d5
wm1: 1000baseSX, 1000baseSX-FDX, auto

and in NetBSD-5.1 as:
wm1 at pci0 dev 14 function 1: Intel i82546GB 1000BASE-X Ethernet, rev. 3
wm1: interrupting at irq 15
wm1: 32-bit 33MHz PCI bus
wm1: 256 word (8 address bits) MicroWire EEPROM
wm1: Ethernet address 00:04:23:ae:2a:d5
wm1: 1000baseSX, 1000baseSX-FDX, auto

as soon as ifconfig or dhclient touches it, the link on the switch goes down and then (ofcourse) no traffic. After a reboot, there is link again.

now link, then
mammalou# ifconfig wm1
wm1: flags=8802<BROADCAST,SIMPLEX,MULTICAST> mtu 1500
        capabilities=2bf80<TSO4,IP4CSUM_Rx,IP4CSUM_Tx,TCP4CSUM_Rx,TCP4CSUM_Tx,UDP4CSUM_Rx,UDP4CSUM_Tx,TCP6CSUM_Tx,UDP6CSUM_Tx>
        enabled=0
        address: 00:04:23:ae:2a:d5
        media: Ethernet autoselect (1000baseSX full-duplex)
        status: active
still link
mammalou# ifconfig wm1 up
(or # dhclient wm1)
now, no more link
mammalou# ifconfig wm1
wm1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
        capabilities=2bf80<TSO4,IP4CSUM_Rx,IP4CSUM_Tx,TCP4CSUM_Rx,TCP4CSUM_Tx,UDP4CSUM_Rx,UDP4CSUM_Tx,TCP6CSUM_Tx,UDP6CSUM_Tx>
        enabled=0
        address: 00:04:23:ae:2a:d5
        media: Ethernet autoselect (none)
        status: no carrier
        inet6 fe80::204:23ff:feae:2ad5%wm1 prefixlen 64 scopeid 0x6

mammalou# ifconfig wm1 media 1000base-SX
mammalou# ifconfig wm1
wm1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
        capabilities=2bf80<TSO4,IP4CSUM_Rx,IP4CSUM_Tx,TCP4CSUM_Rx,TCP4CSUM_Tx,UDP4CSUM_Rx,UDP4CSUM_Tx,TCP6CSUM_Tx,UDP6CSUM_Tx>
        enabled=0
        address: 00:04:23:ae:2a:d5
        media: Ethernet 1000baseSX (1000baseSX full-duplex)
        status: active
        inet6 fe80::204:23ff:feae:2ad5%wm1 prefixlen 64 scopeid 0x6

at this moment, NetBSD sees link, but switch does not

mediaopt fdx does not change things

>How-To-Repeat:
# ifconfig wm1 up
ethernet link link goes down

>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: kern-bug-people->msaitoh
Responsible-Changed-By: msaitoh@NetBSD.org
Responsible-Changed-When: Fri, 14 Jun 2013 07:22:05 +0000
Responsible-Changed-Why:
mine


From: Masanobu SAITOH <msaitoh@execsw.org>
To: gnats-bugs@NetBSD.org
Cc: kiers@original.xs4all.nl, kern-bug-people@netbsd.org, 
 gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, msaitoh@execsw.org
Subject: Re: kern/44776: dual fiber i82546GB (wm) worked in NetBSD-4, not
 in -5, nor in -current
Date: Tue, 18 Jun 2013 16:28:54 +0900

 (2011/03/28 3:55), kiers@original.xs4all.nl wrote:
 >> Number:         44776
 >> Category:       kern
 >> Synopsis:       dual fiber i82546GB (wm) worked in NetBSD-4, not in -5, nor in -current
 >> Confidential:   no
 >> Severity:       serious
 >> Priority:       medium
 >> Responsible:    kern-bug-people
 >> State:          open
 >> Class:          sw-bug
 >> Submitter-Id:   net
 >> Arrival-Date:   Sun Mar 27 18:55:00 +0000 2011
 >> Originator:     Bert Kiers
 >> Release:        5.1 GENERIC i386
 >> Organization:
 > XS4ALL
 >> Environment:
 > NetBSD mammalou.boppelans.net 5.1 NetBSD 5.1 (GENERIC) #0: Sun Nov  7 14:39:56 UTC 2010  builds@b6.netbsd.org:/home/builds/ab/netbsd-5-1-RELEASE/i386/201011061943Z-obj/home/builds/ab/netbsd-5-1-RELEASE/src/sys/arch/i386/compile/GENERIC i386
 >> Description:
 > dual fiber i82546GB (wm(4), Intel PRO/1000 MF Server Adapter) worked in NetBSD-4.0.2, but not in NetBSD-5.0.2, nor in -current
 > 
 > Hardware is a Soekris 5501, switch is HP 1800-24G
 > 
 > Card is probed in NetBSD-4 as:
 > wm1 at pci0 dev 14 function 1: Intel i82546GB 1000BASE-X Ethernet, rev. 3
 > wm1: interrupting at irq 15
 > wm1: Ethernet address 00:04:23:ae:2a:d5
 > wm1: 1000baseSX, 1000baseSX-FDX, auto
 > 
 > and in NetBSD-5.1 as:
 > wm1 at pci0 dev 14 function 1: Intel i82546GB 1000BASE-X Ethernet, rev. 3
 > wm1: interrupting at irq 15
 > wm1: 32-bit 33MHz PCI bus
 > wm1: 256 word (8 address bits) MicroWire EEPROM
 > wm1: Ethernet address 00:04:23:ae:2a:d5
 > wm1: 1000baseSX, 1000baseSX-FDX, auto
 > 
 > as soon as ifconfig or dhclient touches it, the link on the switch goes down and then (ofcourse) no traffic. After a reboot, there is link again.
 > 
 > now link, then
 > mammalou# ifconfig wm1
 > wm1: flags=8802<BROADCAST,SIMPLEX,MULTICAST> mtu 1500
 >          capabilities=2bf80<TSO4,IP4CSUM_Rx,IP4CSUM_Tx,TCP4CSUM_Rx,TCP4CSUM_Tx,UDP4CSUM_Rx,UDP4CSUM_Tx,TCP6CSUM_Tx,UDP6CSUM_Tx>
 >          enabled=0
 >          address: 00:04:23:ae:2a:d5
 >          media: Ethernet autoselect (1000baseSX full-duplex)
 >          status: active
 > still link
 > mammalou# ifconfig wm1 up
 > (or # dhclient wm1)
 > now, no more link
 > mammalou# ifconfig wm1
 > wm1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
 >          capabilities=2bf80<TSO4,IP4CSUM_Rx,IP4CSUM_Tx,TCP4CSUM_Rx,TCP4CSUM_Tx,UDP4CSUM_Rx,UDP4CSUM_Tx,TCP6CSUM_Tx,UDP6CSUM_Tx>
 >          enabled=0
 >          address: 00:04:23:ae:2a:d5
 >          media: Ethernet autoselect (none)
 >          status: no carrier
 >          inet6 fe80::204:23ff:feae:2ad5%wm1 prefixlen 64 scopeid 0x6
 > 
 > mammalou# ifconfig wm1 media 1000base-SX
 > mammalou# ifconfig wm1
 > wm1: flags=8843<UP,BROADCAST,RUNNING,SIMPLEX,MULTICAST> mtu 1500
 >          capabilities=2bf80<TSO4,IP4CSUM_Rx,IP4CSUM_Tx,TCP4CSUM_Rx,TCP4CSUM_Tx,UDP4CSUM_Rx,UDP4CSUM_Tx,TCP6CSUM_Tx,UDP6CSUM_Tx>
 >          enabled=0
 >          address: 00:04:23:ae:2a:d5
 >          media: Ethernet 1000baseSX (1000baseSX full-duplex)
 >          status: active
 >          inet6 fe80::204:23ff:feae:2ad5%wm1 prefixlen 64 scopeid 0x6
 > 
 > at this moment, NetBSD sees link, but switch does not
 > 
 > mediaopt fdx does not change things
 > 
 >> How-To-Repeat:
 > # ifconfig wm1 up
 > ethernet link link goes down
 > 
 >> Fix:

  Could you try the latest -current?
 A few days ago, my 83546GB card worked.


 -- 
 -----------------------------------------------
                 SAITOH Masanobu (msaitoh@execsw.org
                                  msaitoh@netbsd.org)

From: Bert Kiers <kiers@original.xs4all.nl>
To: Masanobu SAITOH <msaitoh@execsw.org>
Cc: gnats-bugs@NetBSD.org, kern-bug-people@NetBSD.org,
	gnats-admin@NetBSD.org, netbsd-bugs@NetBSD.org
Subject: Re: kern/44776: dual fiber i82546GB (wm) worked in NetBSD-4, not in -5, nor in -current
Date: Thu, 20 Jun 2013 20:38:44 +0200

 On Tue, Jun 18, 2013 at 04:28:54PM +0900, Masanobu SAITOH wrote:

 >  Could you try the latest -current?
 > A few days ago, my 83546GB card worked.

 Yes! Works, thanks!

 (But on other hardware than tested in 2011. That hardware
 panics the kernel, even with the patches from roy@)

 Dmesg from working system:
 http://netbsd.itsx.net/kern44776-loulou.txt

 Thanks!
 -- 
 B*E*R*T

From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: kern/44776: dual fiber i82546GB (wm) worked in NetBSD-4, not in
 -5, nor in -current
Date: Mon, 7 Oct 2013 05:02:50 +0000

 not sent to gnats (send all PR traffic to gnats-bugs; it's a remailer)
 (this happens by default, but with a number of mailers, replying to
 yourself causes the wrong thing to happen)

    ------

 From: Bert Kiers <kiers@original.xs4all.nl>
 To: msaitoh@NetBSD.org, gnats-admin@NetBSD.org, netbsd-bugs@NetBSD.org
 Subject: Re: kern/44776: dual fiber i82546GB (wm) worked in NetBSD-4, not in
 	-5, nor in -current
 Date: Tue, 25 Jun 2013 22:47:59 +0200

 On Thu, Jun 20, 2013 at 06:40:01PM +0000, Bert Kiers wrote:
 > The following reply was made to PR kern/44776; it has been noted by GNATS.
 > 
 > From: Bert Kiers <kiers@original.xs4all.nl>
 > To: Masanobu SAITOH <msaitoh@execsw.org>
 > Cc: gnats-bugs@NetBSD.org, kern-bug-people@NetBSD.org,
 > 	gnats-admin@NetBSD.org, netbsd-bugs@NetBSD.org
 > Subject: Re: kern/44776: dual fiber i82546GB (wm) worked in NetBSD-4, not in -5, nor in -current
 > Date: Thu, 20 Jun 2013 20:38:44 +0200
 > 
 >  On Tue, Jun 18, 2013 at 04:28:54PM +0900, Masanobu SAITOH wrote:
 >   
 >  >  Could you try the latest -current?
 >  > A few days ago, my 83546GB card worked.
 >  
 >  Yes! Works, thanks!

 Too soon.

 It works on Juniper EX3200 and Cisco 4948.

 It works reasonably on Cisco 3560. Once it works, it keeps working,
 but sometimes ifconfig down/up needed.

 It does not work with Cisco 2950 and other NetBSD box. Same as before:
 as soon as something touches the interface, link goes down and reboot
 needed.

 Sent details to msaitoh@

 Grtnx,
 -- 
 B*E*R*T

From: "SAITOH Masanobu" <msaitoh@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44776 CVS commit: src/sys/dev/pci
Date: Thu, 31 Jul 2014 03:50:09 +0000

 Module Name:	src
 Committed By:	msaitoh
 Date:		Thu Jul 31 03:50:09 UTC 2014

 Modified Files:
 	src/sys/dev/pci: if_wm.c if_wmreg.h

 Log Message:
  Fix fiber link problem (PR#44776 and PR#30880). Tested with 82543GC, 82544EI,
 82545EM, 82546GB 82571EB and 82572EI fiber cards.
 - Don't use the RXCFG interrupt. It's not required and the interrupt is very
   heavy (a lot of interrupts). Same as {Free,Open}BSD.
 - Modify wm_tbi_mediachange() to be close to em_setup_fiber_serdes_link()
   of {Free,Open}BSD. At least, don't forget to set duplex setting.
 - WM_T_82545 is not 1000base-SX but 1000base-LX. Same as FreeBSD. Tested with
   my own 82545EM card.


 To generate a diff of this commit:
 cvs rdiff -u -r1.284 -r1.285 src/sys/dev/pci/if_wm.c
 cvs rdiff -u -r1.59 -r1.60 src/sys/dev/pci/if_wmreg.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "Soren Jacobsen" <snj@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44776 CVS commit: [netbsd-6] src/sys/dev/pci
Date: Thu, 4 Dec 2014 06:04:07 +0000

 Module Name:	src
 Committed By:	snj
 Date:		Thu Dec  4 06:04:07 UTC 2014

 Modified Files:
 	src/sys/dev/pci [netbsd-6]: if_wm.c if_wmreg.h if_wmvar.h

 Log Message:
 Pull up following revision(s) (requested by msaitoh in ticket #1203):
 	sys/dev/pci/if_wm.c: revisions 1.271, 1.273-1.274, 1.277-1.278,
 				       1.280, 1.282, 1.284-1.285, 1.287,
 				       1.293-1.294, 1.297-1.298,
 				       1.300-1.301, 1.305-1.307 via patch
 	sys/dev/pci/if_wmreg.h: revisions 1.57-1.62, 1.64-1.65 via patch
 	sys/dev/pci/if_wmvar.h: revisions 1.19, 1.21 via patch
 - Acquire SW semaphore in wm_get_swsm_semaphore().
 - Fix some bugs realted to semaphore. This change fixes a problem which
   was exposed in if_wm.c rev. 1.271. Tested by riastradh@.
   - Clear the SMBI bit in SWSM register before accessing NVM and PHY in
     wm_attach(). Same as FreeBSD.
   - Fix a bug that 82573 doesn't put the hardware semaphore. Same as
     FreeBSD r256200.
 - Call wm_set_pcie_completion_timeout() on I350, I354, I210 and I211, too.
   Same as FreeBSD and OpenBSD.
 - Drop PHPM_GO_LINK_D bit in WMREG_PHPM on some chips. From FreeBSD.
 - Fix fiber link problem (PR#44776 and PR#30880). Tested with 82543GC, 82544EI,
   82545EM, 82546GB 82571EB and 82572EI fiber cards.
   - Don't use the RXCFG interrupt. It's not required and the interrupt is very
     heavy (a lot of interrupts). Same as {Free,Open}BSD.
   - Modify wm_tbi_mediachange() to be close to em_setup_fiber_serdes_link()
     of {Free,Open}BSD. At least, don't forget to set duplex setting.
   - WM_T_82545 is not 1000base-SX but 1000base-LX. Same as FreeBSD.
 - Don't check SWSM_SMBI bit if WM_F_LOCK_SWSM isn't set. Fix a problem when
   using vmware with e1000"e". With e1000e which is regarded as 82574L,
   wm_gmii_init() fails with "could not acquire SWSM SMBI" message without
   this change. This problem doesn't occur with real 82574L card.
 - Fix a bug that wm_get_swsm_semaphore() timed out when attaching device on
   some machines.
   - Calculate NVM word size correctly.
   - Determine timeout value based on the NVM word size.
 - It's not required to print "failed to detect NVM bank" message.
   Only print while debugging. Same as {Free,Open}BSD.
 - Add some new I218 devices.
 - Delete 82580ER related code. It was from FreeBSD and was removed in r203049.
 - Fix a bug that the offset of alt MAC address is wrongly calculated to 0
   when alt MAC address function is really used. This bug does not appear
   as real bug if the same MAC address is written in the default location
   and alt MAC address's location.
 - Move some NVM related macros from if_wm.c to if_wmreg.h.
 - Sort definitions in if_wmreg.h
   - move NVM related values to the bottom.
   - sort in register's address' order.
 - Simplify wm_read_mac_addr().
 - Fix debug message.
 - Add missing prototypes.
 - Rename some functions for consistency and clarify.
 - Rename some macros for consistency.
 - Remove a duplicated error message.
 - Fix typo in comment.
 - Cleanup comments.
 - KNF.


 To generate a diff of this commit:
 cvs rdiff -u -r1.227.2.13 -r1.227.2.14 src/sys/dev/pci/if_wm.c
 cvs rdiff -u -r1.46.2.6 -r1.46.2.7 src/sys/dev/pci/if_wmreg.h
 cvs rdiff -u -r1.12.10.4 -r1.12.10.5 src/sys/dev/pci/if_wmvar.h

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 07 Dec 2014 17:02:32 +0000
State-Changed-Why:
Should be fixed (in HEAD, -6, and -7); please test.
Also, if you need the change in -5, please let us know. Otherwise probably
it won't happen.


From: Bert Kiers <kiers@original.xs4all.nl>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: kern/44776 (dual fiber i82546GB (wm) worked in NetBSD-4, not in -5, nor in -current)
Date: Sun, 5 Apr 2015 13:58:00 +0200

 On Sun, Dec 07, 2014 at 05:02:32PM +0000, dholland@NetBSD.org wrote:
 > Synopsis: dual fiber i82546GB (wm) worked in NetBSD-4, not in -5, nor in -current
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: dholland@NetBSD.org
 > State-Changed-When: Sun, 07 Dec 2014 17:02:32 +0000
 > State-Changed-Why:
 > Should be fixed (in HEAD, -6, and -7); please test.
 > Also, if you need the change in -5, please let us know. Otherwise probably
 > it won't happen.

 Fixed!  Thanks.  I don't need it in -5.
 PR can be closed.


 -- 
 B*E*R*T

State-Changed-From-To: feedback->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Sun, 05 Apr 2015 20:10:39 +0000
State-Changed-Why:
msaitoh fixed this. Thanks!


From: "Soren Jacobsen" <snj@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44776 CVS commit: [netbsd-5] src/sys/dev/pci
Date: Thu, 30 Apr 2015 20:00:27 +0000

 Module Name:	src
 Committed By:	snj
 Date:		Thu Apr 30 20:00:27 UTC 2015

 Modified Files:
 	src/sys/dev/pci [netbsd-5]: if_wm.c if_wmreg.h if_wmvar.h pcidevs

 Log Message:
 Pull up following revision(s) (requested by msaitoh in ticket #1962):
 	sys/dev/pci/if_wm.c: revisions 1.259-1.266, 1.269, 1.271, 1.273-1.274, 1.277-1.278, 1.282, 1.284-1.285, 1.287, 1.290, 1.294, 1.297-1.298, 1.300-1.301, 1.304-1.307, 1.310, 1.312-1.314, 1.316 via patch
 	sys/dev/pci/if_wmreg.c: revisions 1.54-1.57, 1.59-1.60, 1.62, 1.64-1.66 via patch
 	sys/dev/pci/if_wmvar.c: revisions 1.17, 1.20-1.21 via patch
 	sys/dev/pci/pcidevs: revisions 1.1172, 1.1195, 1.1201 via patch
 - Fix "MDIC write error" bug for 82574 and 82583. For those chips, the
   semaphore must be released after chip reset. Found and tested by
   Mark Davies.
 - Fix BMC related bugs.
 - Fix yet another NVM bank detect problem in wm(4). Use bank 0 if the detect
   function failed. It's the same as FreeBSD. Observed and tested with
   Asus P8P67 Deluxe motherboard and tested by jnemeth.
 - Add support for I354 DH89xxCC and some new I218 devices.
 - Fix definition of CTRL_GIO_M_DIS bit.
 - Insert completion barrier between register write and delay().
 - Bump max TX DMA size to avoid pathological condition with TSO. From dyoung.
 - Fix semaphore related bugs.
 - Call wm_set_pcie_completion_timeout() on I350, I354, I210 and I211, too.
   Same as FreeBSD and OpenBSD.
 - Drop PHPM_GO_LINK_D bit in WMREG_PHPM on some chips. From FreeBSD.
 -  Fix fiber link problem (PR#44776 and PR#30880).
 - WM_T_82545 is not 1000base-SX but 1000base-LX. Same as FreeBSD.
 - Set the WM_F_ATTACHED flag if wm_attach() finished succesfully and check
   the flag in wm_detach(). It will avoid to panic in wm_detach().
   Fixes PR#49102.
 - It's not required to print "failed to detect NVM bank" with
   aprint_error_dev(). Use DPRINTF(). Same as {Free,Open}BSD.
 - Fix a bug that the offset of alt MAC address is wrongly calculated to 0
   when alt MAC address function is really used. This bug does not appear
   as real bug if the same MAC address is written in the default location
   and alt MAC address's location.
 - Initialize some hardware bits for 8257[1234], 82583, 80003, ICH* and PCH*.
   Some of them are workaround code. From other *BSDs, Linux and documents.
 - Fix a bug that wm_sgmii_writereg() function doesn't pass the "val" argument
   to the I2CCMD register. Reported by Bernard Merindol in PR#49789.
 - Delete 82580ER related code. It was from FreeBSD and was removed
   in r203049.
 - Remove extra debug message.
 - Remove unused variable.
 - Remove a duplicated error message.
 - Cleanup comments.
 - Fix debug message.


 To generate a diff of this commit:
 cvs rdiff -u -r1.162.4.20 -r1.162.4.21 src/sys/dev/pci/if_wm.c
 cvs rdiff -u -r1.24.20.8 -r1.24.20.9 src/sys/dev/pci/if_wmreg.h
 cvs rdiff -u -r1.2.46.6 -r1.2.46.7 src/sys/dev/pci/if_wmvar.h
 cvs rdiff -u -r1.962.4.19 -r1.962.4.20 src/sys/dev/pci/pcidevs

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search