NetBSD Problem Report #44818

From martin@duskware.de  Sat Apr  2 13:49:52 2011
Return-Path: <martin@duskware.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 0A91F63B8CE
	for <gnats-bugs@gnats.NetBSD.org>; Sat,  2 Apr 2011 13:49:52 +0000 (UTC)
Message-Id: <20110402134952.0A91F63B8CE@www.NetBSD.org>
Date: Sat,  2 Apr 2011 13:49:52 +0000 (UTC)
From: martin@NetBSD.org
Reply-To: martin
To: gnats-bugs@gnats.NetBSD.org
Subject: bogus libpthread test
X-Send-Pr-Version: 3.95

>Number:         44818
>Category:       lib
>Synopsis:       bogus libpthread test
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    lib-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Apr 02 13:50:00 +0000 2011
>Closed-Date:    Wed Apr 06 16:05:03 +0000 2011
>Last-Modified:  Wed Apr 06 16:20:02 +0000 2011
>Originator:     Martin Husemann
>Release:        NetBSD 5.99.48
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD krups.duskware.de 5.99.48 NetBSD 5.99.48 (MP3) #14: Fri Apr 1 22:22:17 CEST 2011 martin@night-porter.duskware.de:/usr/src/sys/arch/sparc/compile/MP3 sparc
Architecture: sparc
Machine: sparc
>Description:

The following test: /usr/tests/lib/libpthread/t_status fails on sparc.

The test case creates lots of threads in loops, each malloc()'ing some
random amount of memory upto 7 times the current stack size limit and
leaks that memory. The testcase (and code) is basically undocumented, and
I don't see why the leaking is important for the test case (or how the size
of the allocation matters, besides being kind of random). However, on small
memory systems, we just run out of memory most of the time, causing an overall
test failure.


>How-To-Repeat:
cd /usr/tests/lib/libpthread && ./t_status findthreads

>Fix:
Reduce amount of leaked memory? Or collect it and free it once malloc starts
to fail?

>Release-Note:

>Audit-Trail:
From: Jukka Ruohonen <jruohonen@iki.fi>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: lib/44818: bogus libpthread test
Date: Wed, 6 Apr 2011 13:12:43 +0300

 On Sat, Apr 02, 2011 at 01:50:00PM +0000, martin@NetBSD.org wrote:
 > The test case creates lots of threads in loops, each malloc()'ing some
 > random amount of memory upto 7 times the current stack size limit and
 > leaks that memory. The testcase (and code) is basically undocumented, and
 > I don't see why the leaking is important for the test case (or how the size
 > of the allocation matters, besides being kind of random). However, on small
 > memory systems, we just run out of memory most of the time, causing an overall
 > test failure.

 I concur. I don't understand the test either. When one can not analytically
 conclude even what is being tested, I propose alternatively that such a test
 should be removed.

State-Changed-From-To: open->closed
State-Changed-By: jruoho@NetBSD.org
State-Changed-When: Wed, 06 Apr 2011 16:05:03 +0000
State-Changed-Why:

Fixed, thanks.



From: "Jukka Ruohonen" <jruoho@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44818 CVS commit: src
Date: Wed, 6 Apr 2011 16:04:16 +0000

 Module Name:	src
 Committed By:	jruoho
 Date:		Wed Apr  6 16:04:16 UTC 2011

 Modified Files:
 	src/distrib/sets/lists/tests: mi
 	src/tests/lib/libpthread: Makefile
 Removed Files:
 	src/tests/lib/libpthread: t_status.c

 Log Message:
 As per PR lib/44818, remove 'lib/libpthread/t_status'. It takes two minutes
 to rewrite this properly if someone misses this.


 To generate a diff of this commit:
 cvs rdiff -u -r1.296 -r1.297 src/distrib/sets/lists/tests/mi
 cvs rdiff -u -r1.6 -r1.7 src/tests/lib/libpthread/Makefile
 cvs rdiff -u -r1.2 -r0 src/tests/lib/libpthread/t_status.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search