NetBSD Problem Report #44828

From www@NetBSD.org  Tue Apr  5 11:51:47 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id AD7B063C1AC
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  5 Apr 2011 11:51:46 +0000 (UTC)
Message-Id: <20110405115145.DB18663C1AB@www.NetBSD.org>
Date: Tue,  5 Apr 2011 11:51:45 +0000 (UTC)
From: joern.clausen@uni-bielefeld.de
Reply-To: joern.clausen@uni-bielefeld.de
To: gnats-bugs@NetBSD.org
Subject: databases/mysql51-client expects GNU diff
X-Send-Pr-Version: www-1.0

>Number:         44828
>Category:       pkg
>Synopsis:       databases/mysql51-client expects GNU diff
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    solaris-pkg-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Apr 05 11:55:00 +0000 2011
>Closed-Date:    Sat Mar 17 12:47:28 +0000 2012
>Last-Modified:  Sat Mar 17 12:47:28 +0000 2012
>Originator:     Jörn Clausen
>Release:        
>Organization:
University of Bielefeld
>Environment:
>Description:
Installing databases/mysql51-client on Solaris fails with

+ /bin/diff -I '#include' -w include/mysql/plugin.h.pp ./abi_check.out
/bin/diff: illegal option -- I
usage: diff [-bitw] [-c | -e | -f | -h | -n | -u] file1 file2
       diff [-bitw] [-C number | -U number] file1 file2
       diff [-bitw] [-D string] file1 file2
       diff [-bitw] [-c | -e | -f | -h | -n | -u] [-l] [-r] [-s] [-S name] directory1 directory2

-I seems to be a GNU diff feature. Neither adding "gdiff" nor "diff" to USE_TOOLS solved the problem (devel/diffutils is installed, using "g" prefix). See pkg/44145 for a similar problem.
>How-To-Repeat:

>Fix:

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->solaris-pkg-people
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Tue, 05 Apr 2011 12:36:37 +0000
Responsible-Changed-Why:
Solaris pkgsrc problem.


From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: gnats-bugs@NetBSD.org
Cc: wiz@NetBSD.org, solaris-pkg-people@NetBSD.org, pkg-manager@NetBSD.org,
 pkgsrc-bugs@NetBSD.org, gnats-admin@NetBSD.org
Subject: Re: pkg/44828 (databases/mysql51-client expects GNU diff)
Date: Thu, 07 Apr 2011 10:50:43 +0200

 I solved the problem for the moment by adding

 TOOLS_PATH.diff=/usr/pkgsrc/20110318/bin/gdiff

 to mk.conf. Of course this only works, if devel/diffutils is already 
 installed. So this is only a hack.

 -- 
   Jörn Clausen                             joern.clausen@uni-bielefeld.de
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld

From: Tim Zingelman <zingelman@gmail.com>
To: gnats-bugs@netbsd.org
Cc: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>, 
	solaris-pkg-people@netbsd.org, gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/44828 (databases/mysql51-client expects GNU diff)
Date: Thu, 7 Apr 2011 10:05:48 -0500

 Per http://www.netbsd.org/docs/pkgsrc/tools.html it seems that setting:
   USE_TOOLS+=diff:pkgsrc
 should do the trick.  Did you include the :pkgsrc to indicate that the
 pkgsrc version, not a native version should be used?

From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: zingelman@gmail.com
Cc: gnats-bugs@netbsd.org, solaris-pkg-people@netbsd.org,
 gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/44828 (databases/mysql51-client expects GNU diff)
Date: Thu, 07 Apr 2011 17:20:35 +0200

 No, I wasn't aware the pkgsrc guide had a chapter on this topic.

 Adding "diff:pkgsrc" to the TOOLS line in Makefile.common doesn't seem 
 to help. "bmake show-tools" still contains

 DIFF=/bin/diff

 When I define "TOOLS_PATH.diff" in mk.conf, "bmake show-tools" shows the 
 desired binary.

 -- 
   Jörn Clausen                             joern.clausen@uni-bielefeld.de
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld

From: "Filip Hajny" <filip@joyent.com>
To: <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/44828
Date: Wed, 4 Jan 2012 15:15:20 +0100

 Would this be a reasonable fix for this problem? Seems to be the only worki=
 ng approach.

 +.if ${OPSYS} =3D=3D "SunOS"
 +TOOLS_PLATFORM.diff=3D   # empty
 +.endif

 --
 Filip Hajny
 Joyent Inc.

From: =?ISO-8859-1?Q?J=F6rn_Clausen?= <joern.clausen@uni-bielefeld.de>
To: gnats-bugs@NetBSD.org
Cc: Filip Hajny <filip@joyent.com>, solaris-pkg-people@NetBSD.org,
 gnats-admin@NetBSD.org, pkgsrc-bugs@NetBSD.org
Subject: Re: pkg/44828
Date: Thu, 05 Jan 2012 10:13:48 +0100

 On 01/04/12 03:20 PM, Filip Hajny wrote:
 >   Would this be a reasonable fix for this problem? Seems to be the only worki=
 >   ng approach.
 >
 >   +.if ${OPSYS} =3D=3D "SunOS"
 >   +TOOLS_PLATFORM.diff=3D   # empty
 >   +.endif

 I can't comment on reasonable, but for me it works. But if 
 mk/tools/tools.SunOS.mk picks up /usr/bin/gdiff (on post-Solaris-10 
 systems), and devel/diffutils are not installed, it might break things 
 again. Unless configure finds and uses /usr/bin/gdiff anyway, which it 
 probably will.

 -- 
   Jörn Clausen                             joern.clausen@uni-bielefeld.de
   Hochschulrechenzentrum                 http://www.uni-bielefeld.de/hrz/
   Universität Bielefeld

From: "Filip Hajny" <fhajny@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44828 CVS commit: pkgsrc/databases/mysql51-client
Date: Fri, 9 Mar 2012 11:55:11 +0000

 Module Name:	pkgsrc
 Committed By:	fhajny
 Date:		Fri Mar  9 11:55:11 UTC 2012

 Modified Files:
 	pkgsrc/databases/mysql51-client: Makefile.common

 Log Message:
 Make sure GNU diff is available.

 Fixes PR pkg/44828.


 To generate a diff of this commit:
 cvs rdiff -u -r1.22 -r1.23 pkgsrc/databases/mysql51-client/Makefile.common

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 17 Mar 2012 12:47:28 +0000
State-Changed-Why:
Committed, thanks.


>Unformatted:

Home	PR Database Search