NetBSD Problem Report #44852

From cheusov@tut.by  Sun Apr 10 16:54:13 2011
Return-Path: <cheusov@tut.by>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 9384363C28E
	for <gnats-bugs@gnats.netbsd.org>; Sun, 10 Apr 2011 16:54:13 +0000 (UTC)
Message-Id: <87d3kum4i9.fsf@asrock.chizhovka.net>
Date: Sun, 10 Apr 2011 19:54:06 +0300
From: cheusov@tut.by
To: gnats-bugs@gnats.NetBSD.org
Subject: update for lang/mawk [patch, maintainer's request]
X-Send-Pr-Version: 3.95

>Number:         44852
>Category:       pkg
>Synopsis:       update for lang/mawk [patch, maintainer's request]
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    cheusov
>State:          closed
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Apr 10 16:55:00 +0000 2011
>Closed-Date:    Sat May 07 09:54:39 +0000 2011
>Last-Modified:  Sat May 07 09:54:39 +0000 2011
>Originator:     Aleksey Cheusov
>Release:        NetBSD 5.1
>Organization:
>Environment:
System: NetBSD asrock.chizhovka.net 5.1 NetBSD 5.1 (GENERIC) #0: Mon Jan 31 23:53:52 EET 2011 cheusov@asrock.chizhovka.net:/srv/obj/sys/arch/amd64/compile/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
Major changes in this release of mawk:

    20100625
        + correct translation of octal and hex escapes for system regular
          expression library.
        + modify configure script to support --program-suffix, etc.
        + add Debian package scripts, for "mawk-cur".
        + add RPM spec-file.
        + move release- and patch-level values from version.c to patchlev.h
          to simplify packaging scripts.

    20100618
        + correct translation of "^{" pattern for system regular expression
          library  (report by Elias Pipping).
        + fix sentence fragment in README (report by Elias Pipping).

    20100507
        + cleanup gcc warnings for 64-bit platform, e.g., use size_t rather
          than unsigned, etc.
        + fix warnings from clang --analyze
        + update/improve configure script
          + modify CF_GCC_VERSION to ignore stderr, e.g., from c89 alias
          + modify CF_GCC_WARNINGS, moving -W and -Wall into the list to check,
            since c89 alias for gcc complains about these options.
          + add --disable-leaks and related options, for testing.
          + add lint rule to makefile.
          + add configure-check for ctags to work with pkgsrc.
        + amend change of array.w, fixes a regression in "delete" (report by
          Heiner Marxen).

    20100419
        + modify split() to handle embedded nulls in the string to split, e.g.,
                BEGIN{s="a\0b"; print length(s); n = split(s,f,""); print n}
          (report by Morris Lee).

        + modify array.w to update table pointers in the special case where
          an array is known to have string-indices, but is later indexed via
          integers.  The problem occurs when the array grows large enough to
          rehash it, e.g.,
                BEGIN{a["n"];for(i=1;i<1000;++i)printf "%d\n", a[i]; }
          (report by Morris Lee).

        + increase size of reference-count for strings to unsigned.  It was an
          unsigned short, which prevented using arrays larger than 64k, e.g.,
                BEGIN{for(i = 1; i <= 65550; ++i){if(i >= 65534 && i<= 65537) print i; s[i] = "a"}; delete s;}
          (report by Morris Lee).

        + add special case for Solaris 10 (and up) to configure check
          CF_XOPEN_SOURCE

        + refactored configure check CF_REGEX

    20100224
        + add a configure check for large files (report by Sean Kumar).

        + modify check in collect_RE() to show the actual limit value, e.g.,
          MIN_SPRINTF-2 used for built-in regular expressions.

        + increase MIN_SPRINTF, used as limit on regular-expression size, to
          match the MAX_SPLIT value, i.e., slightly more than doubling the size
          (report by Markus Gnam).

        + further modify makefile to build outside the source-tree.

        + modify makefile and mawktest to use relative path again, since the
          existing script did not work with openSUSE's build (patch by Guido
          Berhoerster).

        + fix makefile's .c.i rule, which lacked CPP definition.

        + update mawktest.bat script to more/less correspond with mawktest,
          for Win32 console except where echo command does not handle the
          required quoting syntax.

        + add vs6.mak, for Visual Studio 6.

        + modify mawktest script to report results from all tests, rather than
          halting on the first failure.

        + add limit-check after processing match(test, "[^0-9A-Za-z]") to
          ensure the internal trailing null of the test-string is not mistaken
          for part of the string, i.e., RSTART, RLENGTH are computed correctly
          (report by Markus Gnam).

        + modify parsing of -W option to use comma-separated values, e.g.,
          "-Wi,e" for "-Winteractive" and "-Werror".

        + add timestamp to scancode.c, to help manage revisions.

        + improve configure macro CF_XOPEN_SOURCE, making it remove possibly
          conflicting definitions before adding new ones.

        + update config.guess and config.sub

        > patches by Jan Psota:

        + improve buffering for -Winteractive option.

        + allow multiple single-character flags after -W, e.g., "-Wie" for
          "-Winteractive" and "-Werror" to permit these to be passed on a
          "#"-line of a shell script, e.g.,
                #!/usr/bin/mawk -Wie

        > patches by Jonathan Nieder:

        + add new M_SAVE_POS and M_2JC operation codes (states) to the
          built-in regular expression engine.  Use these to reimplement
          m* (closure), to provide a way to avoid infinite looping on
          matches against empty strings.  This change requires reimplementing
          the workaround for gawk's noloop1 testcase from 20090726.

        + improve buffer-overflow check for string_buff.

        + fix collect_RE to treat "[^]]" as a character class (meaning "not a
          closing bracket") but "[^^]]" not as one.  This also requires
          initializing the local "start of character class" variable to NULL
          rather than the beginning of the string, to avoid an invalid array
          access when collecting expressions such as "^text".

        + within a character class and not followed by a :, ., or ~, a "[" is
          just like any other character.  This way, you can tell mawk to scan
          for a literal [ character with "mawk /[[]/", and you can scan for a [
          or ] with "mawk /[][]/".  Also clean up the relevant loop in
          do_class() to make it a bit more readable.

        + outside a character class, a "]" is just like any other character.

        + prevent do_class() from scanning past the end, e.g., if the
          terminating zero byte was escaped.

        + fix regular-expression parsing when a right parenthesis ")" is
          found without a preceding left parenthesis.

        + fix resetting of position stack when backtracking.

        + modify regular-expression engine to avoid exponential running time
          for some regular expression matches in which the first match mawk
          finds extends to the end of the string.  This is a new fix for the
          gawk noloop2 test, added here for regression testing.

>How-To-Repeat:

>Fix:
Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/lang/mawk/Makefile,v
retrieving revision 1.21
diff -u -r1.21 Makefile
--- Makefile	20 Apr 2010 19:23:14 -0000	1.21
+++ Makefile	10 Apr 2011 16:38:52 -0000
@@ -1,7 +1,7 @@
 # $NetBSD: Makefile,v 1.21 2010/04/20 19:23:14 zafer Exp $
 #

-DISTNAME=	mawk-1.3.4
+DISTNAME=	mawk-1.3.4-20100625
 PKGNAME=	${DISTNAME:S/-20/.20/}
 CATEGORIES=	lang
 MASTER_SITES=	ftp://invisible-island.net/mawk/
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/lang/mawk/distinfo,v
retrieving revision 1.12
diff -u -r1.12 distinfo
--- distinfo	20 Apr 2010 19:23:14 -0000	1.12
+++ distinfo	10 Apr 2011 16:38:52 -0000
@@ -1,5 +1,5 @@
 $NetBSD: distinfo,v 1.12 2010/04/20 19:23:14 zafer Exp $

-SHA1 (mawk-1.3.4.tgz) = 308f31e735bed959ee913a1d8b47bb5671a419e3
-RMD160 (mawk-1.3.4.tgz) = 150a94f72776d523bea1bae0c9cf1e2d9ca5b1f1
-Size (mawk-1.3.4.tgz) = 283167 bytes
+SHA1 (mawk-1.3.4-20100625.tgz) = 5ba79c2af60915ec3a3eb8d2bbd59e15b9c24a79
+RMD160 (mawk-1.3.4-20100625.tgz) = eba15ad8ed2d0acefe56b02a6db80ad3d9f87dfa
+Size (mawk-1.3.4-20100625.tgz) = 304970 bytes

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->cheusov
Responsible-Changed-By: cheusov@NetBSD.org
Responsible-Changed-When: Fri, 06 May 2011 21:11:03 +0000
Responsible-Changed-Why:
I'll work on my own PR


From: "Aleksey Cheusov" <cheusov@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44852 CVS commit: pkgsrc/lang/mawk
Date: Sat, 7 May 2011 09:43:05 +0000

 Module Name:	pkgsrc
 Committed By:	cheusov
 Date:		Sat May  7 09:43:05 UTC 2011

 Modified Files:
 	pkgsrc/lang/mawk: Makefile distinfo

 Log Message:
 Closes PR pkg/44852, oked by wiz@ and reed@
 Update mawk to 1.3.4.20100625
 Major changes in this release of mawk:
     20100625
         + correct translation of octal and hex escapes for system regular
           expression library.
         + modify configure script to support --program-suffix, etc.
         + add Debian package scripts, for "mawk-cur".
         + add RPM spec-file.
         + move release- and patch-level values from version.c to patchlev.h
           to simplify packaging scripts.

     20100618
         + correct translation of "^{" pattern for system regular expression
           library  (report by Elias Pipping).
         + fix sentence fragment in README (report by Elias Pipping).

     20100507
         + cleanup gcc warnings for 64-bit platform, e.g., use size_t rather
           than unsigned, etc.
         + fix warnings from clang --analyze
         + update/improve configure script
           + modify CF_GCC_VERSION to ignore stderr, e.g., from c89 alias
           + modify CF_GCC_WARNINGS, moving -W and -Wall into the list to check,
             since c89 alias for gcc complains about these options.
           + add --disable-leaks and related options, for testing.
           + add lint rule to makefile.
           + add configure-check for ctags to work with pkgsrc.
         + amend change of array.w, fixes a regression in "delete" (report by
           Heiner Marxen).

     20100419
         + modify split() to handle embedded nulls in the string to split, e.g.,
                 BEGIN{s="a\0b"; print length(s); n = split(s,f,""); print n}
           (report by Morris Lee).
         + modify array.w to update table pointers in the special case where
           an array is known to have string-indices, but is later indexed via
           integers.  The problem occurs when the array grows large enough to
           rehash it, e.g.,
                 BEGIN{a["n"];for(i=1;i<1000;++i)printf "%d\n", a[i]; }
           (report by Morris Lee).
         + increase size of reference-count for strings to unsigned.  It was an
           unsigned short, which prevented using arrays larger than 64k, e.g.,
                 BEGIN{for(i = 1; i <= 65550; ++i){if(i >= 65534 && i<=65537) print i; s[i] = "a"}; delete s;}
           (report by Morris Lee).
         + add special case for Solaris 10 (and up) to configure check
           CF_XOPEN_SOURCE
         + refactored configure check CF_REGEX

     20100224
         + add a configure check for large files (report by Sean Kumar).
         + modify check in collect_RE() to show the actual limit value, e.g.,
           MIN_SPRINTF-2 used for built-in regular expressions.
         + increase MIN_SPRINTF, used as limit on regular-expression size, to
           match the MAX_SPLIT value, i.e., slightly more than doubling the size
           (report by Markus Gnam).
         + further modify makefile to build outside the source-tree.
         + modify makefile and mawktest to use relative path again, since the
           existing script did not work with openSUSE's build (patch by Guido
           Berhoerster).
         + fix makefile's .c.i rule, which lacked CPP definition.
         + update mawktest.bat script to more/less correspond with mawktest,
           for Win32 console except where echo command does not handle the
           required quoting syntax.
         + add vs6.mak, for Visual Studio 6.
         + modify mawktest script to report results from all tests, rather than
           halting on the first failure.
         + add limit-check after processing match(test, "[^0-9A-Za-z]") to
           ensure the internal trailing null of the test-string is not mistaken
           for part of the string, i.e., RSTART, RLENGTH are computed correctly
           (report by Markus Gnam).
         + modify parsing of -W option to use comma-separated values, e.g.,
           "-Wi,e" for "-Winteractive" and "-Werror".
         + add timestamp to scancode.c, to help manage revisions.
         + improve configure macro CF_XOPEN_SOURCE, making it remove possibly
           conflicting definitions before adding new ones.
         + update config.guess and config.sub

         > patches by Jan Psota:

         + improve buffering for -Winteractive option.
         + allow multiple single-character flags after -W, e.g., "-Wie" for
           "-Winteractive" and "-Werror" to permit these to be passed on a
           "#"-line of a shell script, e.g.,
                 #!/usr/bin/mawk -Wie

         > patches by Jonathan Nieder:

         + add new M_SAVE_POS and M_2JC operation codes (states) to the
           built-in regular expression engine.  Use these to reimplement
           m* (closure), to provide a way to avoid infinite looping on
           matches against empty strings.  This change requires
           reimplementing
           the workaround for gawk's noloop1 testcase from 20090726.
         + improve buffer-overflow check for string_buff.
         + fix collect_RE to treat "[^]]" as a character class (meaning "not a
           closing bracket") but "[^^]]" not as one.  This also requires
           initializing the local "start of character class" variable to NULL
           rather than the beginning of the string, to avoid an invalid array
           access when collecting expressions such as "^text".
         + within a character class and not followed by a :, ., or ~, a "[" is
           just like any other character.  This way, you can tell mawk to scan
           for a literal [ character with "mawk /[[]/", and you can scan for a [
           or ] with "mawk /[][]/".  Also clean up the relevant loop in
           do_class() to make it a bit more readable.
         + outside a character class, a "]" is just like any other character.
         + prevent do_class() from scanning past the end, e.g., if the
           terminating zero byte was escaped.
         + fix regular-expression parsing when a right parenthesis ")" is
           found without a preceding left parenthesis.
         + fix resetting of position stack when backtracking.
         + modify regular-expression engine to avoid exponential running time
           for some regular expression matches in which the first match mawk
           finds extends to the end of the string.  This is a new fix for the
           gawk noloop2 test, added here for regression testing.


 To generate a diff of this commit:
 cvs rdiff -u -r1.21 -r1.22 pkgsrc/lang/mawk/Makefile
 cvs rdiff -u -r1.12 -r1.13 pkgsrc/lang/mawk/distinfo

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: cheusov@NetBSD.org
State-Changed-When: Sat, 07 May 2011 09:54:39 +0000
State-Changed-Why:
package has been updated


>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.