NetBSD Problem Report #44914

From kre@munnari.OZ.AU  Thu Apr 28 01:51:04 2011
Return-Path: <kre@munnari.OZ.AU>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 0F70463B9D1
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 28 Apr 2011 01:51:04 +0000 (UTC)
Message-Id: <201104280150.p3S1ohRU018211@jade.coe.psu.ac.th>
Date: Thu, 28 Apr 2011 08:50:43 +0700 (ICT)
From: kre@munnari.OZ.AU
To: gnats-bugs@gnats.NetBSD.org
Subject: comms/asterisk18 DIST_SUBDIR botch (+FIX)
X-Send-Pr-Version: 3.95

>Number:         44914
>Category:       pkg
>Synopsis:       comms/asterisk18 DIST_SUBDIR botch (+FIX)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    obache
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 28 01:55:00 +0000 2011
>Closed-Date:    Thu Apr 28 02:31:16 +0000 2011
>Last-Modified:  Thu Apr 28 02:35:01 +0000 2011
>Originator:     Robert Elz
>Release:        NetBSD 5.0   (pkgsrc current (HEAD) 2011-04-27)
>Organization:
	Prince of Songkla University
>Environment:
System: NetBSD jade.coe.psu.ac.th 5.1 NetBSD 5.1 (JADE-1.12-20101117) #5: Wed Nov 17 05:30:55 ICT 2010 kre@jade.coe.psu.ac.th:/usr/obj/5.1/kernels/i386/JADE i386
Architecture: i386
Machine: i386
>Description:
	When comms/asterisk18 was revbumbed from no rev to nb1, its DIST_SUBDIR
	was make PKGNAME instead of PKGNAME_NOREV so that the distfiles could
	be distinct between the two versions.   That was all fine.

	Then it was revbumped again, but no-one noticed that meant (the way
	things were defined) that the distinfo file would need updating as
	well, and everyone would needlessly be refetching distfiles.

	That means that as it is now, pkgsrc just complains that the distinfo
	file contains no checksums for the distfiles, and everything fails.

>How-To-Repeat:
	By inspection, or just "make checksum" in pkgsrc/comms/asterisk18

>Fix:
	Rather than updating the distinfo, which would mean a refetch of the
	distfiles, and then this same problem potentially occurring again
	the next time there's some need of a revbumo (which was potentially
	even an auto revbump caused by some dependency package being updated)
	I think it is better to just wire down the name of the DIST_SUBDIR.
	If a new set of distfiles are ever needed, this will be easy to fix.
	I'm not sure if there is a better way, but this works ...

Index: Makefile
===================================================================
RCS file: /cvsroot/NetBSD/pkgsrc/comms/asterisk18/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile	22 Apr 2011 13:43:09 -0000	1.7
+++ Makefile	28 Apr 2011 01:41:22 -0000
@@ -6,7 +6,7 @@
 DISTNAME=	asterisk-1.8.2.3
 #XXX change back with next revision
 #DIST_SUBDIR=	${PKGNAME_NOREV}
-DIST_SUBDIR=	${PKGNAME}
+DIST_SUBDIR=	${DISTNAME}nb1
 PKGREVISION=	2
 DISTFILES=	${DEFAULT_DISTFILES}
 EXTRACT_ONLY=	${DISTNAME}.tar.gz

>Release-Note:

>Audit-Trail:

Responsible-Changed-From-To: pkg-manager->obache
Responsible-Changed-By: obache@NetBSD.org
Responsible-Changed-When: Thu, 28 Apr 2011 02:23:50 +0000
Responsible-Changed-Why:
my revbump broke it.


State-Changed-From-To: open->closed
State-Changed-By: obache@NetBSD.org
State-Changed-When: Thu, 28 Apr 2011 02:31:16 +0000
State-Changed-Why:
Fixed.  Thanks you!


From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/44914 CVS commit: pkgsrc/comms/asterisk18
Date: Thu, 28 Apr 2011 02:30:12 +0000

 Module Name:	pkgsrc
 Committed By:	obache
 Date:		Thu Apr 28 02:30:12 UTC 2011

 Modified Files:
 	pkgsrc/comms/asterisk18: Makefile

 Log Message:
 Let not to change DIST_SUBDIR after bump PKGREVISION to 2.
 PR#44914.


 To generate a diff of this commit:
 cvs rdiff -u -r1.7 -r1.8 pkgsrc/comms/asterisk18/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.