NetBSD Problem Report #45156
From moritz@wzff.de Sun Jul 17 21:18:38 2011
Return-Path: <moritz@wzff.de>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by www.NetBSD.org (Postfix) with ESMTP id 9B55263CA68
for <gnats-bugs@gnats.NetBSD.org>; Sun, 17 Jul 2011 21:18:38 +0000 (UTC)
Message-Id: <E1QiYjQ-0001yC-1K@barfooze.de>
Date: Sun, 17 Jul 2011 23:18:32 +0200
From: Moritz Wilhelmy <moritz@wzff.de>
To: gnats-bugs@gnats.NetBSD.org
Subject: Patch to support XS Stick P14 USB 3G Modem and similar devices
X-Send-Pr-Version: 3.95
>Number: 45156
>Category: kern
>Synopsis: Patch to support XS Stick P14 USB 3G Modem and similar devices
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: kern-bug-people
>State: closed
>Class: change-request
>Submitter-Id: net
>Arrival-Date: Sun Jul 17 21:20:00 +0000 2011
>Closed-Date: Tue Jan 03 01:20:05 +0000 2012
>Last-Modified: Tue Jan 03 01:20:05 +0000 2012
>Originator: Moritz Wilhelmy
>Release: NetBSD 5.99.54
>Organization:
>Environment:
System: NetBSD fenrir 5.99.54 NetBSD 5.99.54 (GENERIC) #1: Sun Jul 17 20:57:07 CEST 2011 root@fenrir:/usr/obj/sys/arch/i386/compile/GENERIC i386
Architecture: i386
Machine: i386
>Description:
The XS Stick P14 is an USB modem that needs additional care. It appears as USB
mass storage device containing windows drivers by default. After sending a magic
string, it reinitialises as modem. Simply ejecting /dev/cd0d did not work,
because the device does not support it.
I was unable to obtain the actual vendor name for 0x1c9e and the correct product
names for 0xf000 and 0x9605, so I called them "UNKNOWN". Thanks to Joerg
Sonnenberger for pointing me to u3g and the usb_modeswitch project for
discovering the magic string.
According to usb_modeswitch, there are other devices initialising as 1c9e:f000,
which can be reinitialised with the same magic number, but I was unable to
verify if they work, so I left them out for now.
>How-To-Repeat:
Plug in the stick in vanilla NetBSD, it will show up as USB CD drive that does
not support being ejected. After applying the patch, it will auto-initialise as
ucom device taking up two slots. The first one (ttyU0 in my case) is not usable
and seemingly simply blocked by the manufacturer for no particular reason; the
second one (ttyU1) can be used to dial up.
>Fix:
Index: u3g.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/u3g.c,v
retrieving revision 1.17
diff -u -p -r1.17 u3g.c
--- u3g.c 10 Mar 2011 00:13:56 -0000 1.17
+++ u3g.c 17 Jul 2011 20:14:54 -0000
@@ -244,6 +244,9 @@ static const struct usb_devno u3g_devs[]
/* Toshiba */
{ USB_VENDOR_TOSHIBA, USB_PRODUCT_TOSHIBA_HSDPA_MODEM_EU870DT1 },
+
+ /* Unknown vendor */
+ { USB_VENDOR_UNKNOWN_1C9E, USB_PRODUCT_UNKNOWN_1C9E_M9605 },
};
static int
@@ -416,6 +419,36 @@ u3g_huawei_k3765_reinit(usbd_device_hand
}
static int
+u3g_unknown_1c9e_reinit(usbd_device_handle dev)
+{
+ unsigned char cmd[31];
+
+ /* magic string adapted from usb_modeswitch database */
+ memset(cmd, 0, sizeof(cmd));
+ cmd[0] = 0x55;
+ cmd[1] = 0x53;
+ cmd[2] = 0x42;
+ cmd[3] = 0x43;
+ cmd[4] = 0x12;
+ cmd[5] = 0x34;
+ cmd[6] = 0x56;
+ cmd[7] = 0x78;
+ cmd[8] = 0x80;
+
+ cmd[12]= 0x80;
+
+ cmd[14]= 0x06;
+ cmd[15]= 0x06;
+ cmd[16]= 0xf5;
+ cmd[17]= 0x04;
+ cmd[18]= 0x02;
+ cmd[19]= 0x52;
+ cmd[20]= 0x70;
+
+ return send_bulkmsg(dev, cmd, sizeof(cmd));
+}
+
+static int
u3g_sierra_reinit(usbd_device_handle dev)
{
/* Some Sierra devices presents themselves as a umass device with
@@ -486,6 +519,11 @@ u3ginit_match(device_t parent, cfdata_t
return u3g_novatel_reinit(uaa->device);
break;
+ case USB_VENDOR_UNKNOWN_1C9E:
+ if (uaa->product == USB_PRODUCT_UNKNOWN_1C9E_INSTALLER)
+ return u3g_unknown_1c9e_reinit(uaa->device);
+ break;
+
default:
break;
}
Index: usbdevs
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/usbdevs,v
retrieving revision 1.581
diff -u -p -r1.581 usbdevs
--- usbdevs 11 Jun 2011 13:50:06 -0000 1.581
+++ usbdevs 17 Jul 2011 20:14:19 -0000
@@ -510,6 +510,7 @@ vendor MEINBERG 0x1938 Meinberg Funkuhr
vendor QUALCOMMINC 0x19d2 Qualcomm, Incorporated
vendor QUANTA 0x1a32 Quanta
vendor WINCHIPHEAD2 0x1a86 QinHeng Electronics
+vendor UNKNOWN_1C9E 0x1c9e Unknown (0x1c9e)
vendor MPMAN 0x1cae MPMan
vendor PEGATRON 0x1d4d Pegatron
vendor AIRTIES 0x1eda AirTies
@@ -2731,6 +2732,10 @@ product UMEDIA ALL0298V2 0x3204 ALL0298
/* Universal Access products */
product UNIACCESS PANACHE 0x0101 Panache Surf USB ISDN Adapter
+/* Products by unknown vendor */
+product UNKNOWN_1C9E INSTALLER 0xf000 Uninitialized USB Modem
+product UNKNOWN_1C9E M9605 0x9605 USB Modem 1c9e:9605
+
/* U.S. Robotics products */
product USR USR1120 0x00eb USR1120 WLAN
product USR USR5422 0x0118 USR5422 WLAN
>Release-Note:
>Audit-Trail:
From: David Holland <dholland-gnats@netbsd.org>
To: gnats-bugs@netbsd.org
Cc:
Subject: Re: kern/45156: Patch to support XS Stick P14 USB 3G Modem and
similar devices
Date: Sun, 17 Jul 2011 23:56:34 +0000
not sent to gnats (gnats mail should be sent to gnats-bugs@netbsd.org;
it resends to the list from there)
------
From: Moritz Wilhelmy <moritz@wzff.de>
To: kern-bug-people@netbsd.org, gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: kern/45156: Patch to support XS Stick P14 USB 3G Modem and similar
devices
Date: Mon, 18 Jul 2011 00:41:28 +0200
Mail-Followup-To: Moritz Wilhelmy <moritz@wzff.de>, kern-bug-people@netbsd.org,
gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
On Sun, Jul 17, 2011 at 21:20:00 +0000, Moritz Wilhelmy wrote:
> Plug in the stick in vanilla NetBSD, it will show up as USB CD drive
> that does not support being ejected. After applying the patch, it will
> auto-initialise as ucom device taking up two slots. The first one
> (ttyU0 in my case) is not usable and seemingly simply blocked by the
> manufacturer for no particular reason; the second one (ttyU1) can be
> used to dial up.
This was a bit incorrect: It allocates 4 devices, three of which are
wasted: ttyU0-ttyU2 are seemingly useless, ttyU3 can be used to dial up.
I was able to extract a bit more information out of the device. It
reports the following data:
-> AT&V
&C: 1; &D: 2; &E: 0; &F: 0; &S: 0; &W: 0; E: 1; L: 0; M: 0; Q: 0; V: 1;
X: 1; Z: 0; \Q: 3; \S: 0; \V: 0; S0: 0; S2: 43; S3: 13; S4: 10; S5: 8;
S6: 2; S7: 50; S8: 2; S9: 6; S10: 14; S11: 95; S30: 0; S103: 1; S104: 1;
+FCLASS: 0; +ICF: 3,3; +IFC: 2,2; +IPR: 115200; +DR: 0; +DS: 0,0,2048,6;
+WS46: 12; +LCTSN: 0,5,""; +TESTINF2: ; +SPN: 0; +DISK: 0,""; +TCARD: ;
+PASEL: 3,3,3,3,3,3,3; +SER3: ; +CBST: 0,0,1;
+CRLP: (61,61,48,6,0),(61,61,48,6,1),(240,240,52,6,2);
+CV120: 1,1,1,0,0,0; +CHSN: 0,0,0,0; +CSSN: 0,0; +CREG: 0; +CGREG: 0;
+CFUN:; +CSCS: "IRA"; +CSTA: 129; +CR: 0; +CRC: 0; +CMEE: 0;
+CGDCONT: (1,"IP","internet.t-mobile","0.0.0.0",0,0); +CGDSCONT: ;
+CGTFT: ; +CGEQREQ: ; +CGEQMIN: ; +CGQREQ: ; +CGQMIN: ; +CGEREP: 0,0;
+CGDATA: "PPP"; +CGCLASS: "A"; +CGSMS: 3; +CSMS: 0; +CMGF: 0; +CSAS: 0;
+CRES: 0; +CSCA: "+491710760322",145; +CSMP: ,,0,0; +CSDH: 0;
+CSCB: 0,"",""; +FDD: 0; +FAR: 0; +FCL: 0; +FIT: 0,0; +ES: ,,;
+ESA: 0,,,,0,0,255,; +CMOD: 0; +CVHU: 1; +CPIN: ????????,????????;
+CMEC: 0,0,0KF: 0; +NWLSET: 0,; +MODODR: 2;
+AUTOTIME: 0; +LEDCFG: 0,; +POWERCFG: 0
OK
-> ATI
Manufacturer: 4G Systems GmbH & Co. KG
Model: XS Stick P14
Revision: LQA0064.1.2_MG29
IMEI: 352161043955172
+GCAP: +CGSM,+DS,+ES
OK
I'm not sure whether 1c9e is a genuine, registered USB product ID.
`lsusb' on Linux doesn't know the device either, and I'm not really sure
where to obtain information about registered/allocated USB vendor IDs.
Moritz
From: David Laight <david@l8s.co.uk>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: kern/45156: Patch to support XS Stick P14 USB 3G Modem and similar devices
Date: Mon, 18 Jul 2011 08:01:31 +0100
On Sun, Jul 17, 2011 at 09:20:00PM +0000, Moritz Wilhelmy wrote:
> >Number: 45156
> >Category: kern
> >Synopsis: Patch to support XS Stick P14 USB 3G Modem and similar devices
...
> static int
> +u3g_unknown_1c9e_reinit(usbd_device_handle dev)
> +{
> + unsigned char cmd[31];
> +
> + /* magic string adapted from usb_modeswitch database */
> + memset(cmd, 0, sizeof(cmd));
> + cmd[0] = 0x55;
> + cmd[1] = 0x53;
> + cmd[2] = 0x42;
...
> + cmd[19]= 0x52;
> + cmd[20]= 0x70;
Why not a 'static const magic_cmd[31] = { 0x55, ....
David
--
David Laight: david@l8s.co.uk
From: Moritz Wilhelmy <moritz@wzff.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: kern/45156: Patch to support XS Stick P14 USB 3G Modem and
similar devices
Date: Mon, 18 Jul 2011 11:15:10 +0200
On Mon, Jul 18, 2011 at 07:05:03 +0000, David Laight wrote:
> Why not a 'static const magic_cmd[31] = { 0x55, ....
The code around it did it that way, but you're right, it'd be shorter,
because it contains less zeroes than the other devices.
Moritz
From: David Laight <david@l8s.co.uk>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: kern/45156: Patch to support XS Stick P14 USB 3G Modem and similar devices
Date: Mon, 18 Jul 2011 17:37:14 +0100
On Mon, Jul 18, 2011 at 09:20:03AM +0000, Moritz Wilhelmy wrote:
> The following reply was made to PR kern/45156; it has been noted by GNATS.
>
> From: Moritz Wilhelmy <moritz@wzff.de>
> To: gnats-bugs@NetBSD.org
> Cc:
> Subject: Re: kern/45156: Patch to support XS Stick P14 USB 3G Modem and
> similar devices
> Date: Mon, 18 Jul 2011 11:15:10 +0200
>
> On Mon, Jul 18, 2011 at 07:05:03 +0000, David Laight wrote:
> > Why not a 'static const magic_cmd[31] = { 0x55, ....
>
> The code around it did it that way, but you're right, it'd be shorter,
> because it contains less zeroes than the other devices.
That isn't the point, since none of the bytes are variable you don't
need an on-stack buffer, a compile-time initialised one will do.
David
--
David Laight: david@l8s.co.uk
From: Moritz Wilhelmy <moritz@wzff.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: kern/45156: Patch to support XS Stick P14 USB 3G Modem and
similar devices
Date: Mon, 18 Jul 2011 19:30:45 +0200
On Mon, Jul 18, 2011 at 16:40:03 +0000, David Laight wrote:
> That isn't the point, since none of the bytes are variable you don't
> need an on-stack buffer, a compile-time initialised one will do.
The other devices should probably be fixed too, in that case.
I don't care which version will be adapted, all I want is my 3G stick
to work :^)
This might still have a quirk, since I have to plug in the stick twice
in order to do a full mode switch. Here the relevant bits from dmesg:
| u3ginit0 at uhub4 port 4: Switching to 3G mode
| u3ginit0: detached
| u3ginit0: at uhub4 port 4 (addr 2) disconnected
This is after I plug the stick in for the first time. Afterwards,
/dev/ttyU3 isn't yet usable. After I plug it out and reinsert it, I get
the following messages:
| u3ginit0 at uhub4 port 4: Switching to 3G mode
| u3ginit0: detached
| u3ginit0: at uhub4 port 4 (addr 2) disconnected
| u3g0 at uhub4 port 4 configuration 1 interface 0
| ucom0 at u3g0 portno 0: 3G Modem
| u3g1 at uhub4 port 4 configuration 1 interface 1
| ucom1 at u3g1 portno 1: 3G Modem
| u3g2 at uhub4 port 4 configuration 1 interface 2
| ucom2 at u3g2 portno 2: 3G Modem
| u3g3 at uhub4 port 4 configuration 1 interface 3
| ucom3 at u3g3 portno 3: 3G Modem
| umass0 at uhub4 port 4 configuration 1 interface 4
| umass0: USB Modem USB Modem, rev 2.00/0.00, addr 2
| umass0: using SCSI over Bulk-Only
| scsibus0 at umass0: 2 targets, 1 lun per target
| sd0 at scsibus0 target 0 lun 0: <USBModem, Disk, 2.31> disk removable
| sd0: drive offline
| sd0(umass0:0:0:0): Check Condition on CDB: 0x00 00 00 00 00 00
| SENSE KEY: Not Ready
| ASC/ASCQ: Medium Not Present
|
| sd0: unable to open device, error = 19
Afterwards, the device is usable.
New diff which initialises the array directly attached, so whoever
actually fixes this has less boring copypasta work, regardless of which
way they prefer it.
Note that the other devices are initialised the same way as in my first
diff, see u3g_huawei_k3765_reinit and u3g_novatel_reinit in particular.
Moritz
Index: u3g.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/u3g.c,v
retrieving revision 1.17
diff -u -p -r1.17 u3g.c
--- u3g.c 10 Mar 2011 00:13:56 -0000 1.17
+++ u3g.c 18 Jul 2011 17:04:19 -0000
@@ -244,6 +244,9 @@ static const struct usb_devno u3g_devs[]
/* Toshiba */
{ USB_VENDOR_TOSHIBA, USB_PRODUCT_TOSHIBA_HSDPA_MODEM_EU870DT1 },
+
+ /* Unknown vendor */
+ { USB_VENDOR_UNKNOWN_1C9E, USB_PRODUCT_UNKNOWN_1C9E_M9605 },
};
static int
@@ -416,6 +419,20 @@ u3g_huawei_k3765_reinit(usbd_device_hand
}
static int
+u3g_unknown_1c9e_reinit(usbd_device_handle dev)
+{
+ /* magic string adapted from usb_modeswitch database */
+ unsigned char cmd[31] = {
+ 0x55, 0x53, 0x42, 0x43, 0x12, 0x34, 0x56, 0x78, 0x80, 0x00,
+ 0x00, 0x00, 0x80, 0x00, 0x06, 0x06, 0xf5, 0x04, 0x02, 0x52,
+ 0x70, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x00
+ };
+
+ return send_bulkmsg(dev, cmd, sizeof(cmd));
+}
+
+static int
u3g_sierra_reinit(usbd_device_handle dev)
{
/* Some Sierra devices presents themselves as a umass device with
@@ -486,6 +503,11 @@ u3ginit_match(device_t parent, cfdata_t
return u3g_novatel_reinit(uaa->device);
break;
+ case USB_VENDOR_UNKNOWN_1C9E:
+ if (uaa->product == USB_PRODUCT_UNKNOWN_1C9E_INSTALLER)
+ return u3g_unknown_1c9e_reinit(uaa->device);
+ break;
+
default:
break;
}
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/45156 CVS commit: src/sys/dev/usb
Date: Fri, 30 Sep 2011 14:59:05 -0400
Module Name: src
Committed By: christos
Date: Fri Sep 30 18:59:04 UTC 2011
Modified Files:
src/sys/dev/usb: u3g.c
Log Message:
PR/45156: Moritz Wilhelmy: Add 4G Systems XS Stick P14 USB 3G modem support.
To generate a diff of this commit:
cvs rdiff -u -r1.19 -r1.20 src/sys/dev/usb/u3g.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 05 Nov 2011 16:23:00 +0000
State-Changed-Why:
Does it work as committed?
From: Moritz Wilhelmy <moritz@wzff.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: kern/45156 (Patch to support XS Stick P14 USB 3G Modem and
similar devices)
Date: Sat, 5 Nov 2011 17:33:39 +0100
Nope, This tries to modeswitch the modeswitched device, not the
installer... Sorry for all the "unknown"s in my original patch.
Moritz
State-Changed-From-To: feedback->open
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 05 Nov 2011 19:59:23 +0000
State-Changed-Why:
no dice.
From: Moritz Wilhelmy <moritz@wzff.de>
To: kern-bug-people@netbsd.org, gnats-admin@netbsd.org,
netbsd-bugs@netbsd.org, gnats-bugs@netbsd.org
Cc:
Subject: Re: kern/45156 (Patch to support XS Stick P14 USB 3G Modem and
similar devices)
Date: Sat, 5 Nov 2011 22:08:25 +0100
Well, here's another diff. Thanks to Christos for taking care of this.
Not that it's important or anything. I guess most USB UMTS
initialisation strings could be ported from Linux/usb_modeswitch, a tool
with horrible code, but proper reverse engineering.
One remaining issue, I have to pull the stick out and re-insert it. Can
someone clarify whether this happens with other hardware as well? This
wasn't required with usb_modeswitch. Maybe resets the USB device
somehow? (Caveat: I am not very experienced with regards to the USB
Bus.)
Thanks,
Moritz
Index: dev/usb/u3g.c
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/u3g.c,v
retrieving revision 1.20
diff -u -p -r1.20 u3g.c
--- dev/usb/u3g.c 30 Sep 2011 18:59:04 -0000 1.20
+++ dev/usb/u3g.c 5 Nov 2011 20:49:41 -0000
@@ -506,7 +506,7 @@ u3ginit_match(device_t parent, cfdata_t
break;
case USB_VENDOR_4GSYSTEMS:
- if (uaa->product == USB_PRODUCT_4GSYSTEMS_XSSTICK_P14)
+ if (uaa->product == USB_PRODUCT_4GSYSTEMS_XSSTICK_P14_INSTALLER)
return u3g_4gsystems_reinit(uaa->device);
break;
Index: dev/usb/usbdevs
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/usbdevs,v
retrieving revision 1.597
diff -u -p -r1.597 usbdevs
--- dev/usb/usbdevs 30 Sep 2011 18:42:59 -0000 1.597
+++ dev/usb/usbdevs 5 Nov 2011 20:49:42 -0000
@@ -576,6 +576,7 @@ product 3COMUSR USR56K 0x3021 U.S.Robot
/* 4G Systems products */
product 4GSYSTEMS XSSTICK_P14 0x9605 4G Systems XSStick P14
+product 4GSYSTEMS XSSTICK_P14_INSTALLER 0xf000 4G Systems XSStick P14 - Windows driver
/* ACDC products */
product ACDC HUB 0x2315 USB Pen Drive HUB
Index: dev/usb/usbdevs.h
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/usbdevs.h,v
retrieving revision 1.590
diff -u -p -r1.590 usbdevs.h
--- dev/usb/usbdevs.h 30 Sep 2011 18:43:19 -0000 1.590
+++ dev/usb/usbdevs.h 5 Nov 2011 20:49:42 -0000
@@ -1,4 +1,4 @@
-/* $NetBSD: usbdevs.h,v 1.590 2011/09/30 18:43:19 christos Exp $ */
+/* $NetBSD$ */
/*
* THIS FILE IS AUTOMATICALLY GENERATED. DO NOT EDIT.
@@ -583,6 +583,7 @@
/* 4G Systems products */
#define USB_PRODUCT_4GSYSTEMS_XSSTICK_P14 0x9605 /* 4G Systems XSStick P14 */
+#define USB_PRODUCT_4GSYSTEMS_XSSTICK_P14_INSTALLER 0xf000 /* 4G Systems XSStick P14 - Windows driver */
/* ACDC products */
#define USB_PRODUCT_ACDC_HUB 0x2315 /* USB Pen Drive HUB */
Index: dev/usb/usbdevs_data.h
===================================================================
RCS file: /cvsroot/src/sys/dev/usb/usbdevs_data.h,v
retrieving revision 1.591
diff -u -p -r1.591 usbdevs_data.h
--- dev/usb/usbdevs_data.h 30 Sep 2011 18:43:19 -0000 1.591
+++ dev/usb/usbdevs_data.h 5 Nov 2011 20:49:58 -0000
@@ -1,4 +1,4 @@
-/* $NetBSD: usbdevs_data.h,v 1.591 2011/09/30 18:43:19 christos Exp $ */
+/* $NetBSD$ */
/*
* THIS FILE IS AUTOMATICALLY GENERATED. DO NOT EDIT.
@@ -2079,6 +2079,10 @@ const struct usb_product usb_products[]
"4G Systems XSStick P14",
},
{
+ USB_VENDOR_4GSYSTEMS, USB_PRODUCT_4GSYSTEMS_XSSTICK_P14_INSTALLER,
+ "4G Systems XSStick P14 - Windows driver",
+ },
+ {
USB_VENDOR_ACDC, USB_PRODUCT_ACDC_HUB,
"USB Pen Drive HUB",
},
@@ -8559,4 +8563,4 @@ const struct usb_product usb_products[]
"Prestige",
},
};
-const int usb_nproducts = 1632;
+const int usb_nproducts = 1633;
From: Martin Husemann <martin@duskware.de>
To: Moritz Wilhelmy <moritz@wzff.de>
Cc: gnats-bugs@netbsd.org
Subject: Re: kern/45156 (Patch to support XS Stick P14 USB 3G Modem and similar devices)
Date: Sat, 5 Nov 2011 22:20:27 +0100
On Sat, Nov 05, 2011 at 10:08:25PM +0100, Moritz Wilhelmy wrote:
> One remaining issue, I have to pull the stick out and re-insert it. Can
> someone clarify whether this happens with other hardware as well?
No, there is no manual action needed with other sticks. The installer
device disappears and the ucom device(s) attach fully automatically.
Martin
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/45156 CVS commit: src/sys/dev/usb
Date: Sat, 5 Nov 2011 22:29:34 -0400
Module Name: src
Committed By: christos
Date: Sun Nov 6 02:29:33 UTC 2011
Modified Files:
src/sys/dev/usb: u3g.c usbdevs
Log Message:
PR/45156: Moritz Wilhelmy: XS Stick P14 amendment
To generate a diff of this commit:
cvs rdiff -u -r1.20 -r1.21 src/sys/dev/usb/u3g.c
cvs rdiff -u -r1.599 -r1.600 src/sys/dev/usb/usbdevs
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
State-Changed-From-To: open->feedback
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sun, 06 Nov 2011 15:16:37 +0000
State-Changed-Why:
does that do it?
From: Moritz Wilhelmy <moritz@wzff.de>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: kern/45156 (Patch to support XS Stick P14 USB 3G Modem and
similar devices)
Date: Tue, 15 Nov 2011 00:27:49 +0100
On Sun, Nov 06, 2011 at 15:16:38 +0000, dholland@NetBSD.org wrote:
> does that do it?
Looks like the version in the repository is identical to what I had on
my disk, but I didn't recompile and check (at least that's how I read
the output of "cvs diff"). Should I?
From: David Holland <dholland-bugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc:
Subject: Re: kern/45156 (Patch to support XS Stick P14 USB 3G Modem and
similar devices)
Date: Thu, 17 Nov 2011 02:04:35 +0000
On Mon, Nov 14, 2011 at 11:30:05PM +0000, Moritz Wilhelmy wrote:
> The following reply was made to PR kern/45156; it has been noted by GNATS.
>
> From: Moritz Wilhelmy <moritz@wzff.de>
> To: gnats-bugs@NetBSD.org
> Cc:
> Subject: Re: kern/45156 (Patch to support XS Stick P14 USB 3G Modem and
> similar devices)
> Date: Tue, 15 Nov 2011 00:27:49 +0100
>
> On Sun, Nov 06, 2011 at 15:16:38 +0000, dholland@NetBSD.org wrote:
> > does that do it?
>
> Looks like the version in the repository is identical to what I had on
> my disk, but I didn't recompile and check (at least that's how I read
> the output of "cvs diff"). Should I?
If the source matches what you tested, it should be fine. I just
wanted to make sure; sometimes things get changed on the way to being
committed, whether by mistake or to correct/expand/clarify something,
and sometimes when that happens the results don't work.
Also when there are multiple patches in the PR it's usually a good
idea to crosscheck to make sure they all got committed; it's easy to
leave one out by accident.
But it sounds like it's fine. If it turns out not to work or something
anyway, let us know.
--
David A. Holland
dholland@netbsd.org
State-Changed-From-To: feedback->closed
State-Changed-By: snj@NetBSD.org
State-Changed-When: Tue, 03 Jan 2012 01:20:05 +0000
State-Changed-Why:
Confirmed fixed. Thanks!
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.
Home