NetBSD Problem Report #45343

From www@NetBSD.org  Thu Sep  8 20:42:21 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id AA53B63BBFF
	for <gnats-bugs@gnats.NetBSD.org>; Thu,  8 Sep 2011 20:42:20 +0000 (UTC)
Message-Id: <20110908204219.2F86C63BB48@www.NetBSD.org>
Date: Thu,  8 Sep 2011 20:42:19 +0000 (UTC)
From: pallegra@gmail.com
Reply-To: pallegra@gmail.com
To: gnats-bugs@NetBSD.org
Subject: build fails with MKBSDTAR=yes
X-Send-Pr-Version: www-1.0

>Number:         45343
>Category:       bin
>Synopsis:       build fails with MKBSDTAR=yes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    christos
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Sep 08 20:45:00 +0000 2011
>Closed-Date:    Sat Nov 05 16:35:33 +0000 2011
>Last-Modified:  Sat Nov 05 16:35:33 +0000 2011
>Originator:     Pierre Allegraud
>Release:        CURRENT
>Organization:
>Environment:
>Description:
With the new gcc and -Wformat flag, external/bsd/libarchive/bin/cpio and external/bsd/libarchive/bin/tar (used with MKBSDTAR=yes environment) don't compile.
>How-To-Repeat:

>Fix:
I m using this patch:

Index: external/bsd/libarchive/bin/cpio/Makefile
===================================================================
--- external/bsd/libarchive/bin/cpio/Makefile
+++ external/bsd/libarchive/bin/cpio/Makefile
@@ -4,14 +4,16 @@
 SRCS=	cmdline.c cpio.c

 .include <bsd.init.mk>

 .PATH:		${LIBARCHIVEDIR}/cpio
+
+COPTS.cpio.c+=	-Wno-format-nonliteral

 CLEANFILES+=	cpio.1

 cpio.1: ${LIBARCHIVEDIR}/cpio/bsdcpio.1
 	${TOOL_CAT} ${LIBARCHIVEDIR}/cpio/bsdcpio.1 > $@

 SYMLINKS+=${BINDIR}/cpio /usr/bin/cpio

 .include <bsd.prog.mk>

Index: external/bsd/libarchive/bin/tar/Makefile
===================================================================
--- external/bsd/libarchive/bin/tar/Makefile
+++ external/bsd/libarchive/bin/tar/Makefile
@@ -4,14 +4,16 @@
 SRCS=	bsdtar.c cmdline.c getdate.c read.c subst.c tree.c util.c write.c

 .include <bsd.init.mk>

 .PATH:		${LIBARCHIVEDIR}/tar
+
+COPTS.read.c+=	-Wno-format-nonliteral

 CLEANFILES+=	tar.1

 tar.1: ${LIBARCHIVEDIR}/tar/bsdtar.1
 	${TOOL_CAT} ${LIBARCHIVEDIR}/tar/bsdtar.1 > $@

 SYMLINKS+=${BINDIR}/tar /usr/bin/tar

 .include <bsd.prog.mk>


>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45343 CVS commit: src/external/bsd/libarchive/bin/cpio
Date: Thu, 8 Sep 2011 18:05:00 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Thu Sep  8 22:05:00 UTC 2011

 Modified Files:
 	src/external/bsd/libarchive/bin/cpio: Makefile

 Log Message:
 PR/45343: Pierre Allegraud: Add missing nonliteral format comment.


 To generate a diff of this commit:
 cvs rdiff -u -r1.3 -r1.4 src/external/bsd/libarchive/bin/cpio/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->feedback
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Thu, 08 Sep 2011 22:14:33 +0000
State-Changed-Why:
Christos committed it, ok to close?


From: Pierre Allegraud <pallegra@gmail.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/45343 (build fails with MKBSDTAR=yes)
Date: Fri, 9 Sep 2011 11:53:18 +0200

 Hi !
 cpio can now be built, but tar can't. Could you commit also patch
 external/bsd/libarchive/tar/Makefile, please ?
 Thank you !

 2011/9/9  <wiz@netbsd.org>:
 > Synopsis: build fails with MKBSDTAR=yes
 >
 > State-Changed-From-To: open->feedback
 > State-Changed-By: wiz@NetBSD.org
 > State-Changed-When: Thu, 08 Sep 2011 22:14:33 +0000
 > State-Changed-Why:
 > Christos committed it, ok to close?
 >
 >
 >
 >



 -- 
 Pierre Allegraud

Responsible-Changed-From-To: bin-bug-people->christos
Responsible-Changed-By: wiz@NetBSD.org
Responsible-Changed-When: Fri, 09 Sep 2011 10:28:16 +0000
Responsible-Changed-Why:
Only part of the patches committed.


State-Changed-From-To: feedback->open
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Fri, 09 Sep 2011 10:28:16 +0000
State-Changed-Why:
feedback supplied.


From: Pierre Allegraud <pallegra@gmail.com>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: bin/45343 (build fails with MKBSDTAR=yes)
Date: Mon, 12 Sep 2011 11:04:31 +0200

 Hi !

 One typo left :
 could you replace
 COPTS.cpio.c += -Wformat-nonliteral
 by
 COPTS.cpio.c += -Wnoformat-nonliteral
 in external/bsd/libarchive/bin/cpio/Makefile, please ?

 Once done, I think this PR could be closed.

 Best regards,

 2011/9/9  <wiz@netbsd.org>:
 > Synopsis: build fails with MKBSDTAR=yes
 >
 > Responsible-Changed-From-To: bin-bug-people->christos
 > Responsible-Changed-By: wiz@NetBSD.org
 > Responsible-Changed-When: Fri, 09 Sep 2011 10:28:16 +0000
 > Responsible-Changed-Why:
 > Only part of the patches committed.
 >
 >
 > State-Changed-From-To: feedback->open
 > State-Changed-By: wiz@NetBSD.org
 > State-Changed-When: Fri, 09 Sep 2011 10:28:16 +0000
 > State-Changed-Why:
 > feedback supplied.
 >
 >
 >
 >



 -- 
 Pierre Allegraud

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 05 Nov 2011 16:35:33 +0000
State-Changed-Why:
The rest of the bits did get committed.


>Unformatted:

Home	PR Database Search