NetBSD Problem Report #45384

From www@NetBSD.org  Wed Sep 21 12:30:53 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id D6D8363B89A
	for <gnats-bugs@gnats.NetBSD.org>; Wed, 21 Sep 2011 12:30:53 +0000 (UTC)
Message-Id: <20110921123053.5100F63B86B@www.NetBSD.org>
Date: Wed, 21 Sep 2011 12:30:53 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Swapped arguments in record.c
X-Send-Pr-Version: www-1.0

>Number:         45384
>Category:       bin
>Synopsis:       Swapped arguments in record.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Sep 21 12:35:00 +0000 2011
>Closed-Date:    Wed Sep 21 18:05:55 +0000 2011
>Last-Modified:  Wed Sep 21 18:05:55 +0000 2011
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Swapped arguments in lseek audio/record/record.c
>How-To-Repeat:

>Fix:
diff -u -r1.51 record.c
--- usr.bin/audio/record/record.c	28 Aug 2011 01:17:48 -0000	1.51
+++ usr.bin/audio/record/record.c	21 Sep 2011 08:41:47 -0000
@@ -755,7 +755,7 @@
 	if (outfd == STDOUT_FILENO)
 		return;

-	if (lseek(outfd, SEEK_SET, 0) < 0)
+	if (lseek(outfd, (off_t)0, SEEK_SET) < 0)
 		err(1, "could not seek to start of file for header rewrite");
 	write_header();
 }

>Release-Note:

>Audit-Trail:
From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45384 CVS commit: src/usr.bin/audio/record
Date: Wed, 21 Sep 2011 10:32:14 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Wed Sep 21 14:32:14 UTC 2011

 Modified Files:
 	src/usr.bin/audio/record: record.c

 Log Message:
 PR/45384: Henning Petersen: Swapped arguments in lseek


 To generate a diff of this commit:
 cvs rdiff -u -r1.51 -r1.52 src/usr.bin/audio/record/record.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Wed, 21 Sep 2011 18:05:55 +0000
State-Changed-Why:
Committed by christos, thanks!


>Unformatted:

Home	PR Database Search