NetBSD Problem Report #45422

From woods@once.weird.com  Tue Oct  4 18:40:09 2011
Return-Path: <woods@once.weird.com>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 3D39463D48F
	for <gnats-bugs@gnats.NetBSD.org>; Tue,  4 Oct 2011 18:40:09 +0000 (UTC)
Message-Id: <m1RB9uO-001EBeC@once.weird.com>
Date: Tue, 4 Oct 2011 11:40:04 -0700 (PDT)
From: "Greg A. Woods" <woods@planix.com>
Sender: "Greg A. Woods" <woods@once.weird.com>
Reply-To: "Greg A. Woods" <woods@planix.com>
To: gnats-bugs@gnats.NetBSD.org
Subject: don't use "null" when you mean "NUL"
X-Send-Pr-Version: 3.95

>Number:         45422
>Category:       kern
>Synopsis:       don't use "null" when you mean "NUL"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          closed
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 04 18:45:00 +0000 2011
>Closed-Date:    Wed Oct 05 13:55:41 +0000 2011
>Last-Modified:  Wed Oct 05 13:55:41 +0000 2011
>Originator:     Greg A. Woods
>Release:        NetBSD-current 2011/10/04
>Organization:
Planix, Inc.; Kelowna, BC; Canada
>Environment:
System: NetBSD
Architecture: all
Machine: all
>Description:


>How-To-Repeat:

>Fix:

Index: sys/kern/kern_sysctl.c
===================================================================
RCS file: /cvs/master/m-NetBSD/main/src/sys/kern/kern_sysctl.c,v
retrieving revision 1.231
diff -u -r1.231 kern_sysctl.c
--- sys/kern/kern_sysctl.c	17 Jul 2011 20:54:52 -0000	1.231
+++ sys/kern/kern_sysctl.c	4 Oct 2011 18:00:50 -0000
@@ -1574,7 +1574,7 @@
 		}

 		/*
-		 * did they null terminate it, or do we have space
+		 * did they NUL terminate it, or do we have space
 		 * left to do it ourselves?
 		 */
 		if (newbuf[len - 1] != '\0' && len == sz) {

>Release-Note:

>Audit-Trail:
From: "Alan Barrett" <apb@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45422 CVS commit: src/sys/kern
Date: Wed, 5 Oct 2011 13:24:10 +0000

 Module Name:	src
 Committed By:	apb
 Date:		Wed Oct  5 13:24:10 UTC 2011

 Modified Files:
 	src/sys/kern: kern_sysctl.c

 Log Message:
 s/null terminate/NUL terminate/ in a comment.
 From PR 45422 by Greg Woods.


 To generate a diff of this commit:
 cvs rdiff -u -r1.231 -r1.232 src/sys/kern/kern_sysctl.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: apb@NetBSD.org
State-Changed-When: Wed, 05 Oct 2011 13:55:41 +0000
State-Changed-Why:
patch applied.


>Unformatted:

Home	PR Database Search