NetBSD Problem Report #45450

From www@NetBSD.org  Mon Oct 10 15:35:43 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 2D37063D4FC
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 10 Oct 2011 15:35:43 +0000 (UTC)
Message-Id: <20111010153542.909CE63B955@www.NetBSD.org>
Date: Mon, 10 Oct 2011 15:35:42 +0000 (UTC)
From: netbsd@marino.st
Reply-To: netbsd@marino.st
To: gnats-bugs@NetBSD.org
Subject: pkgtools/p5-pkgsrc-Dewey fails to build with non-standard $WRKOBJDIR 
X-Send-Pr-Version: www-1.0

>Number:         45450
>Category:       pkg
>Synopsis:       pkgtools/p5-pkgsrc-Dewey fails to build with non-standard $WRKOBJDIR
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    pkg-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 10 15:40:00 +0000 2011
>Closed-Date:    Tue Oct 11 22:17:10 +0000 2011
>Last-Modified:  Sat Nov 05 14:55:01 +0000 2011
>Originator:     John Marino
>Release:        
>Organization:
>Environment:
>Description:
pkgtools/p5-pkgsrc-Dewey needs some files from the pkgtools/pkg_install package.

The makefile assumes that the pkg files are always available via a relative path (in the case ../../pkgtools/pkg_install) but this is only true if $WRKOBJDIR is not overridden.

Relative paths should not be used here.
>How-To-Repeat:
set $WRKOBJDIR to a temporary directory in the mk.conf file, then try to build pkgtools/p5-pkgsrc-Dewey

>Fix:
Apply this patch:


--- Makefile.orig	2011-09-26 19:51:08.364306000 +0200
+++ Makefile	2011-10-10 17:15:58.187907000 +0200
@@ -21,7 +21,7 @@

 PERL5_PACKLIST=		auto/pkgsrc/Dewey/.packlist

-PKG_INSTALL_FILESDIR=	../../pkgtools/pkg_install/files
+PKG_INSTALL_FILESDIR=	${PKGSRCDIR}/pkgtools/pkg_install/files
 PKG_INSTALL_FILES=	lib/dewey.c lib/dewey.h lib/defs.h

 do-extract:

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 non-standard $WRKOBJDIR
Date: Tue, 11 Oct 2011 10:21:56 +0200

 On Mon, Oct 10, 2011 at 03:40:01PM +0000, netbsd@marino.st wrote:
 > -PKG_INSTALL_FILESDIR=	../../pkgtools/pkg_install/files
 > +PKG_INSTALL_FILESDIR=	${PKGSRCDIR}/pkgtools/pkg_install/files

 I think the usual method is ${.CURDIR}/../../pkgtools/pkg_install/files
 Does this work for you here too?
  Thomas

From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 non-standard $WRKOBJDIR
Date: Tue, 11 Oct 2011 11:09:37 +0200

 On Mon, Oct 10, 2011 at 03:40:01PM +0000, netbsd@marino.st wrote:
 > >Description:
 > pkgtools/p5-pkgsrc-Dewey needs some files from the pkgtools/pkg_install package.
 > 
 > The makefile assumes that the pkg files are always available via a
 > relative path (in the case ../../pkgtools/pkg_install) but this is only
 > true if $WRKOBJDIR is not overridden.

 Well, I have a binary package for it from my bulk builds and they always
 use WRKOBJDIR. So maybe you should start by telling it exactly what your
 problem is.

 Joerg

From: John Marino <netbsd@marino.st>
To: gnats-bugs@NetBSD.org
Cc: Joerg Sonnenberger <joerg@britannica.bec.de>, pkg-manager@netbsd.org, 
 gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with non-standard
 $WRKOBJDIR
Date: Tue, 11 Oct 2011 11:20:57 +0200

 On 10/11/2011 11:10 AM, Joerg Sonnenberger wrote:
 > The following reply was made to PR pkg/45450; it has been noted by GNATS.
 > 
 > From: Joerg Sonnenberger <joerg@britannica.bec.de>
 > To: gnats-bugs@NetBSD.org
 > Cc: 
 > Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 >  non-standard $WRKOBJDIR
 > Date: Tue, 11 Oct 2011 11:09:37 +0200
 > 
 >  On Mon, Oct 10, 2011 at 03:40:01PM +0000, netbsd@marino.st wrote:
 >  > >Description:
 >  > pkgtools/p5-pkgsrc-Dewey needs some files from the pkgtools/pkg_install package.
 >  > 
 >  > The makefile assumes that the pkg files are always available via a
 >  > relative path (in the case ../../pkgtools/pkg_install) but this is only
 >  > true if $WRKOBJDIR is not overridden.
 >  
 >  Well, I have a binary package for it from my bulk builds and they always
 >  use WRKOBJDIR. So maybe you should start by telling it exactly what your
 >  problem is.
 >  
 >  Joerg
 >  

 Joerg,
 The problem is that the build can't find the files
 pkgtools/pkg_install/files/lib/dewey.h (dewey.c, defs.h)

 If I apply the patch, it can find them.
 There's clearly a problem here.  Why it's not a problem for bulk builds,
 I don't know as I'm not familiar with how they are set up.

 I don't believe I've changed any other variables, I just wanted the work
 directories at /usr/obj/usr/pkgsrc/.

 John



From: John Marino <netbsd@marino.st>
To: gnats-bugs@NetBSD.org
Cc: Thomas Klausner <wiz@NetBSD.org>, pkg-manager@netbsd.org, 
 gnats-admin@netbsd.org, pkgsrc-bugs@netbsd.org
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with non-standard
 $WRKOBJDIR
Date: Tue, 11 Oct 2011 11:25:51 +0200

 On 10/11/2011 10:25 AM, Thomas Klausner wrote:
 > The following reply was made to PR pkg/45450; it has been noted by GNATS.
 > 
 > From: Thomas Klausner <wiz@NetBSD.org>
 > To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
 > Cc: 

 > Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 >  non-standard $WRKOBJDIR
 > Date: Tue, 11 Oct 2011 10:21:56 +0200
 > 
 >  On Mon, Oct 10, 2011 at 03:40:01PM +0000, netbsd@marino.st wrote:
 >  > -PKG_INSTALL_FILESDIR=	../../pkgtools/pkg_install/files
 >  > +PKG_INSTALL_FILESDIR=	${PKGSRCDIR}/pkgtools/pkg_install/files
 >  
 >  I think the usual method is ${.CURDIR}/../../pkgtools/pkg_install/files
 >  Does this work for you here too?
 >   Thomas
 >  

 Hi Thomas,
 I don't have access to that machine until tonight, so I can check then.
 Is ${.CURDIR} equal to ${PKGSRCDIR}/pkgtools/p5-pkgsrc-Dewey in this case?

 I would think my method is a bit cleaner if both are the same, but if
 folks would prefer to stick with .CURDIR, that's fine with me.

 John

From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 non-standard $WRKOBJDIR
Date: Tue, 11 Oct 2011 11:40:48 +0200

 Hi John!

 > I don't have access to that machine until tonight, so I can check then.

 That's plenty early enough :)

 > Is ${.CURDIR} equal to ${PKGSRCDIR}/pkgtools/p5-pkgsrc-Dewey in this case?

 I think so, yes.

 > I would think my method is a bit cleaner if both are the same, but if
 > folks would prefer to stick with .CURDIR, that's fine with me.

 Since it's conventionally used, I'd stick with it.
  Thomas

 P.S.: sending to "gnats-bugs@NetBSD.org" is sufficient, it sends
 copies to Responsible, submitter, and the mailing lists.

From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 non-standard $WRKOBJDIR
Date: Tue, 11 Oct 2011 12:48:17 +0200

 On Tue, Oct 11, 2011 at 09:25:02AM +0000, John Marino wrote:
 >  I don't believe I've changed any other variables, I just wanted the work
 >  directories at /usr/obj/usr/pkgsrc/.

 Ah! That's your problem. You are triggering special OBJDIR logic in make
 that case, so you really should consider using a different directory --
 this is asking for trouble in other places as well.

 Joerg

From: John Marino <netbsd@marino.st>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with non-standard
 $WRKOBJDIR
Date: Tue, 11 Oct 2011 22:14:19 +0200

 On 10/11/2011 11:45 AM, Thomas Klausner wrote:
 >  
 >  > Is ${.CURDIR} equal to ${PKGSRCDIR}/pkgtools/p5-pkgsrc-Dewey in this case?
 >  
 >  I think so, yes.
 >  
 >  > I would think my method is a bit cleaner if both are the same, but if
 >  > folks would prefer to stick with .CURDIR, that's fine with me.
 >  
 >  Since it's conventionally used, I'd stick with it.
 >   Thomas
 >  

 Hi Thomas,
 Using ${.CURDIR} did *not* work on my system.

 Joerg says that the directory /usr/obj/usr/pkgsrc is triggering some
 kind of special handling, although I've never had an issue with it before.

 I'd like to have the p5-pkgsrc-Dewey package work in all cases though.
 Is there a real problem with the patch I suggested?

 Thanks,
 John

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Tue, 11 Oct 2011 22:17:10 +0000
State-Changed-Why:
Committed as suggested, thanks.


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45450 CVS commit: pkgsrc/pkgtools/p5-pkgsrc-Dewey
Date: Tue, 11 Oct 2011 22:16:52 +0000

 Module Name:	pkgsrc
 Committed By:	wiz
 Date:		Tue Oct 11 22:16:52 UTC 2011

 Modified Files:
 	pkgsrc/pkgtools/p5-pkgsrc-Dewey: Makefile

 Log Message:
 Make path absolute. Addresses PR 45450.


 To generate a diff of this commit:
 cvs rdiff -u -r1.18 -r1.19 pkgsrc/pkgtools/p5-pkgsrc-Dewey/Makefile

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 non-standard $WRKOBJDIR
Date: Wed, 12 Oct 2011 10:33:10 +0900

 On Wed, 12 Oct 2011 05:15:04 +0900, John Marino <netbsd@marino.st> wrote:

 >  I'd like to have the p5-pkgsrc-Dewey package work in all cases though.
 >  Is there a real problem with the patch I suggested?

 It will not resolve all problems.
 We need to change all relative path reference in pkgsrc,
 or prevent bmake to "cd /usr/obj/${.CURDIR}" even if it exists.

 For example,

 (I already have /usr/obj/pkgsrc/pkgtools/p5-pkgsrc-Dewey)
 % make
 ===> Skipping vulnerability checks.
 ===> Installing dependencies for p5-pkgsrc-Dewey-1.1nb2
 ERROR: [reduce-depends.awk] ../../sysutils/checkperms does not exist.
 *** Error code 1


 Curiously, try again, and it will not happen anymore,
 but...

 % make
 ===> Installing dependencies for p6-pkgsrc-Dewey-1.1nb2
 ===> Overriding tools for p5-pkgsrc-Dewey-1.1.nb2
 ===> Extracting for p5-pkgsrc-Dewey-1.1nb2
 (snip)
 ===> Unwrapping files-to-be-installed.
 sed: ../../mk/pkginstall/usergroup: No such file or directory
 sed: ../../mk/pkginstall/perms: No such file or directory
 *** Error code 1

 -- 
 OBATA Akio / obache@NetBSD.org

From: John Marino <netbsd@marino.st>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with non-standard
 $WRKOBJDIR
Date: Wed, 12 Oct 2011 07:55:06 +0200

 On 10/12/2011 3:35 AM, OBATA Akio wrote:
 > The following reply was made to PR pkg/45450; it has been noted by GNATS.
 >
 > From: "OBATA Akio"<obache@netbsd.org>
 > To: gnats-bugs@netbsd.org
 > Cc:
 > Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 >   non-standard $WRKOBJDIR
 > Date: Wed, 12 Oct 2011 10:33:10 +0900
 >
 >   It will not resolve all problems.
 >   We need to change all relative path reference in pkgsrc,
 >   or prevent bmake to "cd /usr/obj/${.CURDIR}" even if it exists.
 >
 >   For example,
 >
 >   (I already have /usr/obj/pkgsrc/pkgtools/p5-pkgsrc-Dewey)
 >   % make
 >   ===>  Skipping vulnerability checks.
 >   ===>  Installing dependencies for p5-pkgsrc-Dewey-1.1nb2
 >   ERROR: [reduce-depends.awk] ../../sysutils/checkperms does not exist.
 >   *** Error code 1
 >
 >
 >   Curiously, try again, and it will not happen anymore,
 >   but...
 >
 >   % make
 >   ===>  Installing dependencies for p6-pkgsrc-Dewey-1.1nb2
 >   ===>  Overriding tools for p5-pkgsrc-Dewey-1.1.nb2
 >   ===>  Extracting for p5-pkgsrc-Dewey-1.1nb2
 >   (snip)
 >   ===>  Unwrapping files-to-be-installed.
 >   sed: ../../mk/pkginstall/usergroup: No such file or directory
 >   sed: ../../mk/pkginstall/perms: No such file or directory
 >   *** Error code 1
 >
 >   --
 >   OBATA Akio / obache@NetBSD.org
 >

 Hmm, I'm not see seeing an issue like that and I've been putting the 
 work dirs on /usr/obj/usr/pkgsrc for 6 months now.  I have not seen many 
 relative links that outright break like p5-pkgsrc-Dewey did, but I do 
 agree that any others like this one should have their relative path fixed.
 John

From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 non-standard $WRKOBJDIR
Date: Wed, 12 Oct 2011 13:35:16 +0200

 On Wed, Oct 12, 2011 at 05:50:04AM +0000, John Marino wrote:
 >  >   We need to change all relative path reference in pkgsrc,
 >  >   or prevent bmake to "cd /usr/obj/${.CURDIR}" even if it exists.
 >  >
 >  
 >  Hmm, I'm not see seeing an issue like that and I've been putting the 
 >  work dirs on /usr/obj/usr/pkgsrc for 6 months now.  I have not seen many 
 >  relative links that outright break like p5-pkgsrc-Dewey did, but I do 
 >  agree that any others like this one should have their relative path fixed.

 That's what I meant originally. Just don't do it. Please resist the
 desire to shoot your own foot and just pick a different directory.

 Joerg

From: John Marino <netbsd@marino.st>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with non-standard
 $WRKOBJDIR
Date: Wed, 12 Oct 2011 13:49:16 +0200

 On 10/12/2011 1:40 PM, Joerg Sonnenberger wrote:
 > The following reply was made to PR pkg/45450; it has been noted by GNATS.
 > 
 > From: Joerg Sonnenberger <joerg@britannica.bec.de>
 > To: gnats-bugs@NetBSD.org
 > Cc: 
 > Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 >  non-standard $WRKOBJDIR
 > Date: Wed, 12 Oct 2011 13:35:16 +0200
 > 
 >  On Wed, Oct 12, 2011 at 05:50:04AM +0000, John Marino wrote:
 >  >  >   We need to change all relative path reference in pkgsrc,
 >  >  >   or prevent bmake to "cd /usr/obj/${.CURDIR}" even if it exists.
 >  >  >
 >  >  
 >  >  Hmm, I'm not see seeing an issue like that and I've been putting the 
 >  >  work dirs on /usr/obj/usr/pkgsrc for 6 months now.  I have not seen many 
 >  >  relative links that outright break like p5-pkgsrc-Dewey did, but I do 
 >  >  agree that any others like this one should have their relative path fixed.
 >  
 >  That's what I meant originally. Just don't do it. Please resist the
 >  desire to shoot your own foot and just pick a different directory.
 >  
 >  Joerg
 >  

 What you interpret as shooting your own foot might be interpreted a bug
 in pkgsrc by others.  The directory /usr/obj/ was not selected at
 random.  There should be a very good reason why this is off-limits (if
 it's really is off-limits), and if so, pkgsrc should be actively
 enforcing this limitation as OBATA suggested.

 That said, pkgsrc has mostly been working fine literally for months.  I
 do notice a "../../pkgtools/digest not found" message at the start of
 every build which is probably related to this issue, but other than the
 two issues mentioned in this thread, pkgsrc has been behaving well with
 the $WRKOBJDIR overridden to the value /usr/obj/usr/pkgsrc.  If a couple
 of more relatively links need to be fixed to entirely support this
 directory base, we should probably do that rather than passing off these
 issues as stupid user error.

 Regards,
 John

From: "OBATA Akio" <obache@netbsd.org>
To: gnats-bugs@netbsd.org
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 non-standard $WRKOBJDIR
Date: Wed, 12 Oct 2011 21:26:00 +0900

 How about put following in mk/bsd.prefs.mk (or somewhere)?

 .OBJDIR:	${PKGDIR}

 maybe, it produce a side effect, though.

From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 non-standard $WRKOBJDIR
Date: Wed, 12 Oct 2011 14:26:15 +0200

 On Wed, Oct 12, 2011 at 11:50:05AM +0000, John Marino wrote:
 >  What you interpret as shooting your own foot might be interpreted a bug
 >  in pkgsrc by others.  The directory /usr/obj/ was not selected at
 >  random.  There should be a very good reason why this is off-limits (if
 >  it's really is off-limits), and if so, pkgsrc should be actively
 >  enforcing this limitation as OBATA suggested.

 You sound like a cancer patient that tells his doc about the head ache
 he had for years. The very good reason for this being off-limits is that
 it triggers magic behavior in make. Enforcing it is non-trivial as there
 are too many different ways to trigger it.

 >  That said, pkgsrc has mostly been working fine literally for months.  I
 >  do notice a "../../pkgtools/digest not found" message at the start of
 >  every build which is probably related to this issue, but other than the
 >  two issues mentioned in this thread, pkgsrc has been behaving well with
 >  the $WRKOBJDIR overridden to the value /usr/obj/usr/pkgsrc.  If a couple
 >  of more relatively links need to be fixed to entirely support this
 >  directory base, we should probably do that rather than passing off these
 >  issues as stupid user error.

 Frankly, I am more in favour of something being openly broken that
 seemingly working most of the time. This is such a case where pretty
 much every make target can easily create a more or less obvious error.
 I don't see the advantage in hunting them down.

 Joerg

From: John Marino <netbsd@marino.st>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with non-standard
 $WRKOBJDIR
Date: Wed, 12 Oct 2011 14:58:06 +0200

 On 10/12/2011 2:30 PM, Joerg Sonnenberger wrote:
 >  You sound like a cancer patient that tells his doc about the head ache
 >  he had for years. The very good reason for this being off-limits is that
 >  it triggers magic behavior in make. Enforcing it is non-trivial as there
 >  are too many different ways to trigger it.

 I assumed the trivial way to enforce it is to check the value of
 $WRKOBJDIR and emit an error/die if it starts with "/usr/obj/".

 >  Frankly, I am more in favour of something being openly broken that
 >  seemingly working most of the time. This is such a case where pretty
 >  much every make target can easily create a more or less obvious error.
 >  I don't see the advantage in hunting them down.

 I'd rather the case just be handled rather gracefully than let it go on
 with unexpected behavior.  If the decision is really that "/usr/obj/" is
 a sacred directory, then A) publish that in the pkgsrc guide and B) have
 pkgsrc enforce the limitation.  Obviously I'd rather there was no such
 limitation, but if that's not practical then so be it.

 John

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 non-standard $WRKOBJDIR
Date: Thu, 13 Oct 2011 14:53:34 +0000

 On Wed, Oct 12, 2011 at 01:00:09PM +0000, John Marino wrote:
  >>  You sound like a cancer patient that tells his doc about the head ache
  >>  he had for years. The very good reason for this being off-limits is that
  >>  it triggers magic behavior in make. Enforcing it is non-trivial as there
  >>  are too many different ways to trigger it.
  >  
  >  I assumed the trivial way to enforce it is to check the value of
  >  $WRKOBJDIR and emit an error/die if it starts with "/usr/obj/".

 Nope.

  >  >  Frankly, I am more in favour of something being openly broken that
  >  >  seemingly working most of the time. This is such a case where pretty
  >  >  much every make target can easily create a more or less obvious error.
  >  >  I don't see the advantage in hunting them down.
  >  
  >  I'd rather the case just be handled rather gracefully than let it go on
  >  with unexpected behavior.  If the decision is really that "/usr/obj/" is
  >  a sacred directory, then A) publish that in the pkgsrc guide and B) have
  >  pkgsrc enforce the limitation.  Obviously I'd rather there was no such
  >  limitation, but if that's not practical then so be it.

 It's not sacred, it's just a special case, and it's never going to
 work. (Or at least, not until make's objdir handling misfeature is
 expunged, but that isn't happening anytime soon.)

 Something like

 .if ${.OBJDIR} != ${.CURDIR}
 .error "Hit an objdir, please don't do this"
 .endif

 will probably work, but the error isn't going to be comprehensible.
 Writing a test that will allow reporting what went wrong requires
 duplicating make's rather complicated objdir search logic, which isn't
 a very good idea.

 In the meantime, just change your WRKOBJDIR to /usr/obj/pkg. This will
 also help keep it from getting mixed up with object dirs from the base
 system build.

 -- 
 David A. Holland
 dholland@netbsd.org

From: John Marino <netbsd@marino.st>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with non-standard
 $WRKOBJDIR
Date: Mon, 17 Oct 2011 10:53:56 +0200

 On 10/13/2011 4:55 PM, David Holland wrote:
 > The following reply was made to PR pkg/45450; it has been noted by GNATS.
 > 
 > From: David Holland <dholland-pbugs@netbsd.org>
 >  (...)
 >  It's not sacred, it's just a special case, and it's never going to
 >  work. (Or at least, not until make's objdir handling misfeature is
 >  expunged, but that isn't happening anytime soon.)
 >  
 >  Something like
 >  
 >  .if ${.OBJDIR} != ${.CURDIR}
 >  .error "Hit an objdir, please don't do this"
 >  .endif
 >  
 >  will probably work, but the error isn't going to be comprehensible.
 >  Writing a test that will allow reporting what went wrong requires
 >  duplicating make's rather complicated objdir search logic, which isn't
 >  a very good idea.
 >  
 >  In the meantime, just change your WRKOBJDIR to /usr/obj/pkg. This will
 >  also help keep it from getting mixed up with object dirs from the base
 >  system build.
 >  
 >  -- 
 >  David A. Holland
 >  dholland@netbsd.org


 Hi David,
 I would advocate a simple check as you mention above, but with an error
 that points to a paragraph on the pkgsrc guide (to be added) that
 describes the objdir limitation.  I stumbled upon this, so other users
 may in the future as well.

 That said, I've changed my objdir, so if such a check is not going to be
 added for whatever reason, somebody can close pkg/45450.

 Regards,
 John



From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45450: pkgtools/p5-pkgsrc-Dewey fails to build with
 non-standard $WRKOBJDIR
Date: Sat, 5 Nov 2011 14:50:08 +0000

 On Mon, Oct 17, 2011 at 08:55:02AM +0000, John Marino wrote:
  >  I would advocate a simple check as you mention above, but with an error
  >  that points to a paragraph on the pkgsrc guide (to be added) that
  >  describes the objdir limitation.  I stumbled upon this, so other users
  >  may in the future as well.

 That sounds like a workable approach... now just to do it :-)

 -- 
 David A. Holland
 dholland@netbsd.org

>Unformatted:

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.51 2026/08/10 02:28:17 riastradh Exp $
$NetBSD: gnats_config.sh,v 1.10 2026/05/13 22:00:09 riastradh Exp $
Copyright © 1994-2026 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.