NetBSD Problem Report #45517

From www@NetBSD.org  Mon Oct 24 08:38:22 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id F101A63C346
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 24 Oct 2011 08:38:21 +0000 (UTC)
Message-Id: <20111024083821.5B90763B86B@www.NetBSD.org>
Date: Mon, 24 Oct 2011 08:38:21 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Add keyword restrict in glob().
X-Send-Pr-Version: www-1.0

>Number:         45517
>Category:       lib
>Synopsis:       Add keyword restrict in glob().
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 24 08:40:00 +0000 2011
>Closed-Date:    Sun Oct 30 22:06:43 +0000 2011
>Last-Modified:  Sun Oct 30 22:06:43 +0000 2011
>Originator:     Henning Petersen
>Release:        
>Organization:
>Environment:
>Description:

>How-To-Repeat:

>Fix:
diff -u -p -r1.30 glob.c
--- lib/libc/gen/glob.c	14 May 2011 22:44:06 -0000	1.30
+++ lib/libc/gen/glob.c	24 Oct 2011 06:32:20 -0000
@@ -180,8 +180,9 @@ static void	 qprintf(const char *, Char 
 #endif

 int
-glob(const char *pattern, int flags, int (*errfunc)(const char *, int),
-    glob_t *pglob)
+glob(const char * __restrict pattern, int flags,
+	int (*errfunc)(const char *, int),
+	glob_t * __restrict pglob)
 {
 	const u_char *patnext;
 	int c;

>Release-Note:

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: lib/45517: Add keyword restrict in glob().
Date: Sun, 30 Oct 2011 22:47:35 +0100

 On Mon, Oct 24, 2011 at 08:40:01AM +0000, henning.petersen@t-online.de wrote:
 > >Number:         45517
 > >Category:       lib
 > >Synopsis:       Add keyword restrict in glob().

 Why? :)
  Thomas

From: "Christos Zoulas" <christos@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45517 CVS commit: src/lib/libc/gen
Date: Sun, 30 Oct 2011 17:53:43 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Sun Oct 30 21:53:43 UTC 2011

 Modified Files:
 	src/lib/libc/gen: glob.c

 Log Message:
 PR/45517: Henning Petersen: Add restrict keywords in the definition of glob
 to match the declaration.


 To generate a diff of this commit:
 cvs rdiff -u -r1.30 -r1.31 src/lib/libc/gen/glob.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, lib-bug-people@netbsd.org, 
	gnats-admin@netbsd.org, netbsd-bugs@netbsd.org, 
	henning.petersen@t-online.de
Cc: 
Subject: Re: lib/45517: Add keyword restrict in glob().
Date: Sun, 30 Oct 2011 17:54:02 -0400

 On Oct 30,  9:50pm, wiz@NetBSD.org (Thomas Klausner) wrote:
 -- Subject: Re: lib/45517: Add keyword restrict in glob().

 | The following reply was made to PR lib/45517; it has been noted by GNATS.
 | 
 | From: Thomas Klausner <wiz@NetBSD.org>
 | To: gnats-bugs@NetBSD.org
 | Cc: 
 | Subject: Re: lib/45517: Add keyword restrict in glob().
 | Date: Sun, 30 Oct 2011 22:47:35 +0100
 | 
 |  On Mon, Oct 24, 2011 at 08:40:01AM +0000, henning.petersen@t-online.de wrote:
 |  > >Number:         45517
 |  > >Category:       lib
 |  > >Synopsis:       Add keyword restrict in glob().
 |  
 |  Why? :)
 |   Thomas

 To match the declaration?

 christos

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 30 Oct 2011 22:06:43 +0000
State-Changed-Why:
Christos committed it, thanks.


>Unformatted:

Home	PR Database Search