NetBSD Problem Report #45518

From www@NetBSD.org  Mon Oct 24 08:42:20 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 7B66963C3B0
	for <gnats-bugs@gnats.NetBSD.org>; Mon, 24 Oct 2011 08:42:20 +0000 (UTC)
Message-Id: <20111024084219.E9E9063C346@www.NetBSD.org>
Date: Mon, 24 Oct 2011 08:42:19 +0000 (UTC)
From: henning.petersen@t-online.de
Reply-To: henning.petersen@t-online.de
To: gnats-bugs@NetBSD.org
Subject: Change from bitwise to boolean.
X-Send-Pr-Version: www-1.0

>Number:         45518
>Category:       lib
>Synopsis:       Change from bitwise to boolean.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 24 08:45:00 +0000 2011
>Closed-Date:    Sun Oct 30 21:48:39 +0000 2011
>Last-Modified:  Sun Oct 30 21:50:06 +0000 2011
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Change from bitwise to boolean in macro _DIAGASSERT .
>How-To-Repeat:

>Fix:
diff -u -r1.8 citrus_mapper_std.c
--- lib/libc/citrus/modules/citrus_mapper_std.c	11 Sep 2006 13:06:33 -0000	1.8
+++ lib/libc/citrus/modules/citrus_mapper_std.c	7 Oct 2011 07:27:01 -0000
@@ -426,7 +426,7 @@
 {
 	struct _citrus_mapper_std *ms;

-	_DIAGASSERT(cm!=NULL & cm->cm_closure!=NULL);
+	_DIAGASSERT(cm!=NULL && cm->cm_closure!=NULL);

 	ms = cm->cm_closure;
 	if (ms->ms_uninit)

>Release-Note:

>Audit-Trail:

State-Changed-From-To: open->closed
State-Changed-By: wiz@NetBSD.org
State-Changed-When: Sun, 30 Oct 2011 21:48:39 +0000
State-Changed-Why:
Committed, thanks!


From: "Thomas Klausner" <wiz@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45518 CVS commit: src/lib/libc/citrus/modules
Date: Sun, 30 Oct 2011 21:48:28 +0000

 Module Name:	src
 Committed By:	wiz
 Date:		Sun Oct 30 21:48:27 UTC 2011

 Modified Files:
 	src/lib/libc/citrus/modules: citrus_mapper_std.c

 Log Message:
 Use boolean AND instead of bitwise one in _DIAGASSERT.
 From Henning Petersen in PR 45518.


 To generate a diff of this commit:
 cvs rdiff -u -r1.8 -r1.9 src/lib/libc/citrus/modules/citrus_mapper_std.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

>Unformatted:

Home	PR Database Search