NetBSD Problem Report #45527

From www@NetBSD.org  Thu Oct 27 14:24:15 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 9F3DE63D69C
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 27 Oct 2011 14:24:15 +0000 (UTC)
Message-Id: <20111027142415.1259563BEB0@www.NetBSD.org>
Date: Thu, 27 Oct 2011 14:24:15 +0000 (UTC)
From: ppedaal@mail.ee
Reply-To: ppedaal@mail.ee
To: gnats-bugs@NetBSD.org
Subject: PLIST of multimedia/vlc is x86-centric
X-Send-Pr-Version: www-1.0

>Number:         45527
>Category:       pkg
>Synopsis:       PLIST of multimedia/vlc is x86-centric
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 27 14:25:00 +0000 2011
>Last-Modified:  Tue Nov 15 08:15:02 +0000 2011
>Originator:     Mihkel Ader
>Release:        NetBSD-current
>Organization:
>Environment:
NetBSD ubin 5.99.56 NetBSD 5.99.56 (MYGENERIC) #0: Thu Oct 20 19:07:41 UTC 2011  root@ubin:/usr/src/sys/arch/macppc/compile/MYGENERIC macppc
>Description:
The PLIST of multimedia/vlc lists 3DNow!/MMX/SSE-optimised modules which are not built on non-x86 machines and it does not include AltiVec modules which do get built on PPC.
>How-To-Repeat:
Try to build VLC on something that is not i386/x86_64.
>Fix:
Adjust PLIST according to the multimedia extensions available.

>Audit-Trail:
From: Thomas Klausner <wiz@NetBSD.org>
To: NetBSD bugtracking <gnats-bugs@NetBSD.org>
Cc: 
Subject: Re: pkg/45527: PLIST of multimedia/vlc is x86-centric
Date: Fri, 28 Oct 2011 10:01:26 +0200

 On Thu, Oct 27, 2011 at 02:25:01PM +0000, ppedaal@mail.ee wrote:
 > The PLIST of multimedia/vlc lists 3DNow!/MMX/SSE-optimised modules which are not built on non-x86 machines and it does not include AltiVec modules which do get built on PPC.
 > >How-To-Repeat:
 > Try to build VLC on something that is not i386/x86_64.
 > >Fix:
 > Adjust PLIST according to the multimedia extensions available.

 Do you have a diff for the PLIST?
 If you can, including the pkgsrc magic, but if not, it'd still help someone looking at it who doesn't have PPC available.
  Thomas

From: John Marino <marino@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45527 VLC and insufficient PLIST
Date: Sat, 12 Nov 2011 08:34:00 +0100

 The subject of this existing PR is "PLIST of multimedia/vlc is x86-centric"
 It seems the package is also NetBSD-centric, according to PKG_DEVELOPER=yes

 Build log:
 =======================
 => Automatic manual page handling
 => Generating post-install file lists
 => Checking file-check results for vlc-1.1.12nb1
 ERROR: ************************************************************
 ERROR: The following files are in /usr/pkg but not in the PLIST:
 ERROR:         
 /work/multimedia/vlc/work/.destdir/usr/pkg/lib/vlc/plugins/access/libcdda_plugin.a
 ERROR:         
 /work/multimedia/vlc/work/.destdir/usr/pkg/lib/vlc/plugins/access/libcdda_plugin.la
 ERROR:         
 /work/multimedia/vlc/work/.destdir/usr/pkg/lib/vlc/plugins/access/libcdda_plugin.so
 ERROR:         
 /work/multimedia/vlc/work/.destdir/usr/pkg/lib/vlc/plugins/access/libvcd_plugin.a
 ERROR:         
 /work/multimedia/vlc/work/.destdir/usr/pkg/lib/vlc/plugins/access/libvcd_plugin.la
 ERROR:         
 /work/multimedia/vlc/work/.destdir/usr/pkg/lib/vlc/plugins/access/libvcd_plugin.so
 *** Error code 1

 Stop.
 bmake: stopped in /usr/pkgsrc/multimedia/vlc
 *** Error code 1
 =======================

 multimedia/vlc Makefile
 =======================
 .include "../../mk/bsd.prefs.mk"
 .include "options.mk"

 .if ${OPSYS} == "NetBSD"
 CONFIGURE_ARGS+=    --disable-vcd
 .else
 PLIST.vcd=        yes
 # This may need a closer look.
 PLIST.cdda=        yes
 .endif
 =======================

 The PLIST isn't adapted for what the Makefile is doing, not even on x86*.
 John

From: John Marino <netbsd@marino.st>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45527 VLC and insufficient PLIST
Date: Mon, 14 Nov 2011 18:37:37 +0100

 I propose the following patch to address the DragonFly build breakage of VLC:

 --- PLIST.orig	2011-10-07 21:13:19.000000000 +0200
 +++ PLIST	2011-11-14 16:10:45.613994000 +0100
 @@ -101,10 +101,12 @@
  lib/vlc/plugins/access/libaccess_oss_plugin.la
  lib/vlc/plugins/access/libaccess_tcp_plugin.la
  lib/vlc/plugins/access/libaccess_udp_plugin.la
 +${PLIST.cdda}lib/vlc/plugins/access/libcdda_plugin.la
  lib/vlc/plugins/access/libdvdnav_plugin.la
  lib/vlc/plugins/access/libdvdread_plugin.la
  lib/vlc/plugins/access/libfilesystem_plugin.la
  lib/vlc/plugins/access/librtp_plugin.la
 +${PLIST.vcd}lib/vlc/plugins/access/libvcd_plugin.la
  ${PLIST.x11}lib/vlc/plugins/access/libxcb_screen_plugin.la
  lib/vlc/plugins/access/libzip_plugin.la
  lib/vlc/plugins/access_output/libaccess_output_dummy_plugin.la

 Any objection?
 The PLIST variables cdda and vcd are already defined in the makefile.
 -- John

From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45527 VLC and insufficient PLIST
Date: Mon, 14 Nov 2011 18:00:05 +0000

 On Mon, Nov 14, 2011 at 05:40:07PM +0000, John Marino wrote:
  >  --- PLIST.orig	2011-10-07 21:13:19.000000000 +0200
  >  +++ PLIST	2011-11-14 16:10:45.613994000 +0100
  >  @@ -101,10 +101,12 @@
  >   lib/vlc/plugins/access/libaccess_oss_plugin.la
  >   lib/vlc/plugins/access/libaccess_tcp_plugin.la
  >   lib/vlc/plugins/access/libaccess_udp_plugin.la
  >  +${PLIST.cdda}lib/vlc/plugins/access/libcdda_plugin.la
  >   lib/vlc/plugins/access/libdvdnav_plugin.la
  >   lib/vlc/plugins/access/libdvdread_plugin.la
  >   lib/vlc/plugins/access/libfilesystem_plugin.la
  >   lib/vlc/plugins/access/librtp_plugin.la
  >  +${PLIST.vcd}lib/vlc/plugins/access/libvcd_plugin.la
  >   ${PLIST.x11}lib/vlc/plugins/access/libxcb_screen_plugin.la
  >   lib/vlc/plugins/access/libzip_plugin.la
  >   lib/vlc/plugins/access_output/libaccess_output_dummy_plugin.la
  >  
  >  Any objection?
  >  The PLIST variables cdda and vcd are already defined in the makefile.

 Looks reasonable to me.

 It seems... odd that two PLIST vars are defined in the makefile and
 not currently used in the PLIST. Maybe someone messed it up when
 updating?

 -- 
 David A. Holland
 dholland@netbsd.org

From: Matthew Mondor <mm_lists@pulsar-zone.net>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45527 VLC and insufficient PLIST
Date: Mon, 14 Nov 2011 13:18:44 -0500

 >  On Mon, Nov 14, 2011 at 05:40:07PM +0000, John Marino wrote:
 >   >  --- PLIST.orig	2011-10-07 21:13:19.000000000 +0200
 >   >  +++ PLIST	2011-11-14 16:10:45.613994000 +0100
 >   >  @@ -101,10 +101,12 @@
 >   >   lib/vlc/plugins/access/libaccess_oss_plugin.la
 >   >   lib/vlc/plugins/access/libaccess_tcp_plugin.la
 >   >   lib/vlc/plugins/access/libaccess_udp_plugin.la
 >   >  +${PLIST.cdda}lib/vlc/plugins/access/libcdda_plugin.la
 >   >   lib/vlc/plugins/access/libdvdnav_plugin.la
 >   >   lib/vlc/plugins/access/libdvdread_plugin.la
 >   >   lib/vlc/plugins/access/libfilesystem_plugin.la
 >   >   lib/vlc/plugins/access/librtp_plugin.la
 >   >  +${PLIST.vcd}lib/vlc/plugins/access/libvcd_plugin.la
 >   >   ${PLIST.x11}lib/vlc/plugins/access/libxcb_screen_plugin.la
 >   >   lib/vlc/plugins/access/libzip_plugin.la
 >   >   lib/vlc/plugins/access_output/libaccess_output_dummy_plugin.la
 >   >  
 >   >  Any objection?
 >   >  The PLIST variables cdda and vcd are already defined in the makefile.
 >  
 >  Looks reasonable to me.
 >  
 >  It seems... odd that two PLIST vars are defined in the makefile and
 >  not currently used in the PLIST. Maybe someone messed it up when
 >  updating?

 When seeing this PR it made me remember of other vlc PLIST related
 issues that I filed as pkg/45209 (just as reference, as the issues were
 not with the same files).

 Thanks,

From: "John Marino" <marino@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45527 CVS commit: pkgsrc/multimedia/vlc
Date: Mon, 14 Nov 2011 19:53:18 +0000

 Module Name:	pkgsrc
 Committed By:	marino
 Date:		Mon Nov 14 19:53:18 UTC 2011

 Modified Files:
 	pkgsrc/multimedia/vlc: Makefile PLIST

 Log Message:
 PR#45527 multimedia/vlc: Fix DragonFly breakage (PLIST)

 DragonFly builds with two plugins that NetBSD suppresses, but these
 plugins were not on PLIST although the definition of suitable PLIST
 variables suggest this was intended originally.  The plugins have
 been conditionally added to the PLIST to properly support DragonFly.


 To generate a diff of this commit:
 cvs rdiff -u -r1.120 -r1.121 pkgsrc/multimedia/vlc/Makefile
 cvs rdiff -u -r1.46 -r1.47 pkgsrc/multimedia/vlc/PLIST

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: John Marino <marino@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45527 VLC and insufficient PLIST
Date: Mon, 14 Nov 2011 21:24:57 +0100

 David Holland:
 >  It seems... odd that two PLIST vars are defined in the makefile and
 >  not currently used in the PLIST. Maybe someone messed it up when
 >  updating?

 No, the PLIST variable were correctly implemented on 2 Oct 2008, and were present in the PLIST until Jan 24, 2011, which is when DragonFly was broken and when VLC was updated from WIP to version 1.1.6.  Clearly the WIP version was not a 1:1 replacement:

 https://github.com/jsonn/pkgsrc/commit/c86fc94adab75436b622241dc36314a0cfec04fe

 Maybe some of these other PLIST issues were introduced at that time as well?
 John

From: John Marino <marino@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45527 VLC and insufficient PLIST
Date: Tue, 15 Nov 2011 09:17:15 +0100

 Taking at look at gnats, PR 44655 is also caused by the import of 
 version 1.1.6 from WIP.

 Maybe it's time that somebody audit this package, taking all these open 
 PRs into account?
 It seems like a lot of problems were introduced  with that version.

 John

NetBSD Home
NetBSD PR Database Search

(Contact us) $NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2007 The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.