NetBSD Problem Report #45532

From www@NetBSD.org  Fri Oct 28 00:11:51 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 0944E63CAEB
	for <gnats-bugs@gnats.NetBSD.org>; Fri, 28 Oct 2011 00:11:51 +0000 (UTC)
Message-Id: <20111028001150.6826163BEB0@www.NetBSD.org>
Date: Fri, 28 Oct 2011 00:11:50 +0000 (UTC)
From: dogcow@babymeat.com
Reply-To: dogcow@babymeat.com
To: gnats-bugs@NetBSD.org
Subject: regress/.../ehter_aton_r/autogen should use awk, not ed.
X-Send-Pr-Version: www-1.0

>Number:         45532
>Category:       toolchain
>Synopsis:       regress/.../ehter_aton_r/autogen should use awk, not ed.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    toolchain-manager
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Oct 28 03:05:04 +0000 2011
>Closed-Date:    Sat Dec 31 21:15:33 +0000 2011
>Last-Modified:  Sat Dec 31 21:15:33 +0000 2011
>Originator:     moof
>Release:        -current
>Organization:
>Environment:
Linux herpderp 3.0.0-12-generic #0-Ubuntu SMP blah blah blah
>Description:
src/regress/sys/net/ether_aton_r/autogen uses /bin/ed to generate one of the regress files. However, /bin/ed (despite being "the standard text editor") is not installed on many lignuces. As nbawk is built as part of the toolchain, however, that might be a better choice for the file generation.
>How-To-Repeat:
Use leenooks. Do not install /bin/ed
>Fix:
Rewrite script, or force everybody to use The Standard Text Editor.

>Release-Note:

>Audit-Trail:
From: christos@zoulas.com (Christos Zoulas)
To: gnats-bugs@NetBSD.org, toolchain-manager@netbsd.org, 
	gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Cc: 
Subject: Re: toolchain/45532: regress/.../ehter_aton_r/autogen should use awk, not ed.
Date: Fri, 28 Oct 2011 09:39:47 -0400

 On Oct 28,  3:05am, dogcow@babymeat.com (dogcow@babymeat.com) wrote:
 -- Subject: toolchain/45532: regress/.../ehter_aton_r/autogen should use awk,

 | Rewrite script, or force everybody to use The Standard Text Editor.

 It is clumsy to do in awk.

 christos

From: Wolfgang Solfrank <Wolfgang@Solfrank.net>
To: Christos Zoulas <christos@zoulas.com>
Cc: gnats-bugs@NetBSD.org, toolchain-manager@netbsd.org, 
 gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: toolchain/45532: regress/.../ehter_aton_r/autogen should use
 awk, not ed.
Date: Fri, 28 Oct 2011 17:03:29 +0200

 This is a multi-part message in MIME format.
 --------------060108070209020900090205
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit

 Hi,

 > It is clumsy to do in awk.

 What about the attached script?

 Ciao,
 Wolfgang
 -- 
 Wolfgang@Solfrank.net				Wolfgang Solfrank

 --------------060108070209020900090205
 Content-Type: text/plain;
  name="autogen"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="autogen"

 #!/bin/sh

 awk '
 BEGIN {
 	print
 	print "#include <ctype.h>"
 	print "#include <sys/types.h>"
 	print "#include <errno.h>"
 	print
 	print "#define ETHER_ADDR_LEN 6"
 	print
 	print "int ether_aton_r(u_char *dest, size_t len, const char *str);"
 	print
 }
 /^ether_aton_r/ {
 	print prevline
 	out = 1
 }
 {
 	if (out) print
 	else prevline = $0
 }
 /^}$/ {
 	if (out) exit(0)
 }' $1 >$2

 --------------060108070209020900090205--

From: christos@zoulas.com (Christos Zoulas)
To: Wolfgang Solfrank <Wolfgang@Solfrank.net>
Cc: gnats-bugs@NetBSD.org, toolchain-manager@netbsd.org, 
	gnats-admin@netbsd.org, netbsd-bugs@netbsd.org
Subject: Re: toolchain/45532: regress/.../ehter_aton_r/autogen should use awk, not ed.
Date: Fri, 28 Oct 2011 13:02:16 -0400

 On Oct 28,  5:03pm, Wolfgang@Solfrank.net (Wolfgang Solfrank) wrote:
 -- Subject: Re: toolchain/45532: regress/.../ehter_aton_r/autogen should use 

 | What about the attached script?

 Looks great, please commit it!

 christos

From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
To: gnats-bugs@NetBSD.org
Cc: tsutsui@ceres.dti.ne.jp
Subject: Re: toolchain/45532: regress/.../ehter_aton_r/autogen should use awk,
	 not ed.
Date: Sat, 29 Oct 2011 02:15:14 +0900

 BTW, this ether_aton_r test should test all digits
 so that it could find this bug...
 http://cvsweb.NetBSD.org/bsdweb.cgi/src/sys/net/if_ethersubr.c#rev1.185

 ---
 Izumi Tsutsui

From: "Wolfgang Solfrank" <ws@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45532 CVS commit: src/regress/sys/net/ether_aton_r
Date: Tue, 1 Nov 2011 12:52:28 +0000

 Module Name:	src
 Committed By:	ws
 Date:		Tue Nov  1 12:52:28 UTC 2011

 Modified Files:
 	src/regress/sys/net/ether_aton_r: autogen

 Log Message:
 Replace ed usage with awk script.
 Fixes PR toolchain/45532, generating the exact same output as previously.
 Note that it doesn't address Tsutsui's additional check request.


 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/regress/sys/net/ether_aton_r/autogen

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

State-Changed-From-To: open->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Sat, 31 Dec 2011 21:15:33 +0000
State-Changed-Why:
Fixed in November.


>Unformatted:

Home	PR Database Search