NetBSD Problem Report #45579
From www@NetBSD.org Sun Nov 6 14:09:21 2011
Return-Path: <www@NetBSD.org>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
by www.NetBSD.org (Postfix) with ESMTP id 5E7FB63B974
for <gnats-bugs@gnats.NetBSD.org>; Sun, 6 Nov 2011 14:09:21 +0000 (UTC)
Message-Id: <20111106140920.833BD63B8DB@www.NetBSD.org>
Date: Sun, 6 Nov 2011 14:09:20 +0000 (UTC)
From: gnrp@komkon2.de
Reply-To: gnrp@komkon2.de
To: gnats-bugs@NetBSD.org
Subject: libfetch fetch(3) manpage with wrong summaries
X-Send-Pr-Version: www-1.0
>Number: 45579
>Category: lib
>Synopsis: libfetch fetch(3) manpage with wrong summaries
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: lib-bug-people
>State: closed
>Class: doc-bug
>Submitter-Id: net
>Arrival-Date: Sun Nov 06 14:10:00 +0000 2011
>Closed-Date: Tue May 31 16:29:17 +0000 2016
>Last-Modified: Tue May 31 18:05:00 +0000 2016
>Originator: Julian Fagir
>Release: NetBSD 5.99.56
>Organization:
>Environment:
>Description:
The manpage of fetch(3) reports wrong function summaries for fetchList* functions. The pattern-parameter is not mentioned in the summary.
>How-To-Repeat:
Look at manpage and then at fetch.h, the differences of all the fetchList* functions.
>Fix:
Index: external/bsd/fetch/dist/libfetch/fetch.3
===================================================================
RCS file: /cvsroot/src/external/bsd/fetch/dist/libfetch/fetch.3,v
retrieving revision 1.1.1.8
diff -u -r1.1.1.8 fetch.3
--- external/bsd/fetch/dist/libfetch/fetch.3 30 Jan 2010 21:26:10 -0000 1.1.1.8
+++ external/bsd/fetch/dist/libfetch/fetch.3 5 Nov 2011 08:44:32 -0000
@@ -91,7 +91,7 @@
.Ft int
.Fn fetchStatURL "const char *URL" "struct url_stat *us" "const char *flags"
.Ft int
-.Fn fetchListURL "struct url_list *list" "const char *URL" "const char *flags"
+.Fn fetchListURL "struct url_list *list" "const char *URL" "const char *pattern" "const char *flags"
.Ft fetchIO *
.Fn fetchXGet "struct url *u" "struct url_stat *us" "const char *flags"
.Ft fetchIO *
@@ -101,7 +101,7 @@
.Ft int
.Fn fetchStat "struct url *u" "struct url_stat *us" "const char *flags"
.Ft int
-.Fn fetchList "struct url_list *list" "struct url *u" "const char *flags"
+.Fn fetchList "struct url_list *list" "struct url *u" "const char *pattern" "const char *flags"
.Ft fetchIO *
.Fn fetchXGetFile "struct url *u" "struct url_stat *us" "const char *flags"
.Ft fetchIO *
@@ -111,7 +111,7 @@
.Ft int
.Fn fetchStatFile "struct url *u" "struct url_stat *us" "const char *flags"
.Ft int
-.Fn fetchListFile "struct url_list *list" "struct url *u" "const char *flags"
+.Fn fetchListFile "struct url_list *list" "struct url *u" "const char *pattern" "const char *flags"
.Ft fetchIO *
.Fn fetchXGetHTTP "struct url *u" "struct url_stat *us" "const char *flags"
.Ft fetchIO *
@@ -121,7 +121,7 @@
.Ft int
.Fn fetchStatHTTP "struct url *u" "struct url_stat *us" "const char *flags"
.Ft int
-.Fn fetchListHTTP "struct url_list *list" "struct url *u" "const char *flags"
+.Fn fetchListHTTP "struct url_list *list" "struct url *u" "const char *pattern" "const char *flags"
.Ft fetchIO *
.Fn fetchXGetFTP "struct url *u" "struct url_stat *us" "const char *flags"
.Ft fetchIO *
@@ -131,7 +131,7 @@
.Ft int
.Fn fetchStatFTP "struct url *u" "struct url_stat *us" "const char *flags"
.Ft int
-.Fn fetchListFTP "struct url_list *list" "struct url *u" "const char *flags"
+.Fn fetchListFTP "struct url_list *list" "struct url *u" "const char *pattern" "const char *flags"
.Ft void
.Fn fetchInitURLList "struct url_list *ul"
.Ft int
@@ -158,7 +158,7 @@
detailed in RFC 1738.
A regular expression which produces this syntax is:
.Bd -literal -offset indent
-\*[Lt]scheme\*[Gt]:(//(\*[Lt]user\*[Gt](:\*[Lt]pwd\*[Gt])?@)?\*[Lt]host\*[Gt](:\*[Lt]port\*[Gt])?)?/(\*[Lt]document\*[Gt])?
+\*[Lt]scheme\*[Gt]:(//(\*[Lt]user\*[Gt](:\*[Lt]pwd\*[Gt])?@)?\*[Lt]host\*[Gt](:\*[Lt]port\*[Gt])?)?/(\*[Lt]doc\*[Gt])?
.Ed
.Pp
If the URL does not seem to begin with a scheme name, it is assumed to be a local path.
@@ -169,7 +169,7 @@
For instance, the file scheme only needs the
.Aq scheme
and
-.Aq document
+.Aq doc
components.
.Fn fetchParseURL
quotes any unsafe character in the URL automatically.
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed
State-Changed-By: abhinav@NetBSD.org
State-Changed-When: Tue, 31 May 2016 16:29:17 +0000
State-Changed-Why:
Committed, thanks!
From: "Abhinav Upadhyay" <abhinav@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/45579 CVS commit: src/external/bsd/fetch/dist/libfetch
Date: Tue, 31 May 2016 16:26:48 +0000
Module Name: src
Committed By: abhinav
Date: Tue May 31 16:26:48 UTC 2016
Modified Files:
src/external/bsd/fetch/dist/libfetch: fetch.3
Log Message:
Add the missing parameter "const char *pattern" to the fetchList* functions.
From Julian Fagir in PR lib/45579
To generate a diff of this commit:
cvs rdiff -u -r1.3 -r1.4 src/external/bsd/fetch/dist/libfetch/fetch.3
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
From: "Abhinav Upadhyay" <abhinav@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc:
Subject: PR/45579 CVS commit: pkgsrc/net/libfetch/files
Date: Tue, 31 May 2016 18:02:36 +0000
Module Name: pkgsrc
Committed By: abhinav
Date: Tue May 31 18:02:36 UTC 2016
Modified Files:
pkgsrc/net/libfetch/files: fetch.3
Log Message:
Add the missing parameter "const char *pattern" to the fetchList* functions.
From Julian Fagir in PR lib/45579
To generate a diff of this commit:
cvs rdiff -u -r1.16 -r1.17 pkgsrc/net/libfetch/files/fetch.3
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
>Unformatted:
(Contact us)
$NetBSD: query-full-pr,v 1.39 2013/11/01 18:47:49 spz Exp $
$NetBSD: gnats_config.sh,v 1.8 2006/05/07 09:23:38 tsutsui Exp $
Copyright © 1994-2014
The NetBSD Foundation, Inc. ALL RIGHTS RESERVED.