NetBSD Problem Report #45649

From oster@mickey.localdomain  Thu Nov 24 19:50:39 2011
Return-Path: <oster@mickey.localdomain>
Received: from mail.netbsd.org (mail.netbsd.org [204.152.190.11])
	by www.NetBSD.org (Postfix) with ESMTP id 4ECAD63BA04
	for <gnats-bugs@gnats.NetBSD.org>; Thu, 24 Nov 2011 19:50:39 +0000 (UTC)
Message-Id: <20111124195034.CE01F88C67@mickey.localdomain>
Date: Thu, 24 Nov 2011 13:50:34 -0600 (CST)
From: oster@netbsd.org
Reply-To: oster@netbsd.org
To: gnats-bugs@gnats.NetBSD.org
Subject: devel/py-subvertpy fails to build
X-Send-Pr-Version: 3.95

>Number:         45649
>Category:       pkg
>Synopsis:       devel/py-subvertpy fails to build on NetBSD 5.1/amd64
>Confidential:   no
>Severity:       critical
>Priority:       low
>Responsible:    cheusov
>State:          closed
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 24 19:55:00 +0000 2011
>Closed-Date:    Mon Jan 23 00:59:10 +0000 2012
>Last-Modified:  Mon Jan 23 00:59:10 +0000 2012
>Originator:     Greg Oster
>Release:        NetBSD 5.1_STABLE
>Organization:
>Environment:


System: NetBSD quad 5.1_STABLE NetBSD 5.1_STABLE (QUAD) #0: Sun Nov 20 15:55:06 CST 2011  oster@quad:/u1/builds/build194/src/obj/amd64/u1/builds/build194/src/sys/arch/amd64/compile/QUAD amd64
Architecture: x86_64
Machine: amd64
>Description:

	Building devel/py-subvertypy fails thusly:

...

cc -DNDEBUG -O2 -pipe -DHAVE_DB_185_H -I/usr/include -I/usr/pkg/include -O2 -pipe -I/usr/pkg/include -I/usr/pkg/include/apr-1 -I/usr/include -I/usr/pkg/include -I/usr/pkg/include/apr-1 -I/usr/include -fPIC -I/usr/pkg/include/apr-1 -I/usr/pkg/include/apr-1 -I/usr/pkg/include/subversion-1 -Isubvertpy -I/usr/pkg/include/python2.6 -c subvertpy/client.c -o build/temp.netbsd-5.1_STABLE-amd64-2.6/subvertpy/client.o

...

subvertpy/wc.c: In function 'get_pristine_copy_path':
subvertpy/wc.c:2271: warning: 'svn_wc_get_pristine_copy_path' is deprecated (declared at /usr/pkgsrc/devel/py-subvertpy/work.quad/.buildlink/include/subversion-1/svn_wc.h:4994)
cc -pthread -shared -L/usr/pkgsrc/lang/python26/work.quad/Python-2.6.7 -L/usr/lib -Wl,-R/usr/lib -L/usr/pkg/lib -Wl,-R/usr/pkg/lib -L/usr/pkg/lib -Wl,-R/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib -O2 -pipe -I/usr/pkg/include -I/usr/pkg/include/apr-1 -I/usr/include -I/usr/pkg/include -I/usr/pkg/include/apr-1 -I/usr/include build/temp.netbsd-5.1_STABLE-amd64-2.6/subvertpy/client.o build/temp.netbsd-5.1_STABLE-amd64-2.6/subvertpy/editor.o build/temp.netbsd-5.1_STABLE-amd64-2.6/subvertpy/util.o build/temp.netbsd-5.1_STABLE-amd64-2.6/subvertpy/_ra.o build/temp.netbsd-5.1_STABLE-amd64-2.6/subvertpy/wc.o -L/usr/pkg/lib -lsvn_client-1 -lsvn_subr-1 -lsvn_ra-1 -lsvn_wc-1 -lpython2.6 -o build/lib.netbsd-5.1_STABLE-amd64-2.6/subvertpy/client.so -L/usr/pkg/lib -lapr-1 -lcrypt -lpthread -L/usr/pkg/lib -Wl,-R/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib
ld: build/temp.netbsd-5.1_STABLE-amd64-2.6/subvertpy/client.o: relocation R_X86_64_PC32 against `py_wc_notify_func' can not be used when making a shared object; recompile with -fPIC
ld: final link failed: Bad value
error: command 'cc' failed with exit status 1
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/devel/py-subvertpy
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/devel/py-subvertpy

Observe that client.o *IS* built with -fPIC.


>How-To-Repeat:
	On a NetBSD 5.1_STABLE amd64 box do:
	cd /usr/pkgsrc/devel/py-subvertpy
	make install

	watch it die
>Fix:
	In /usr/pkgsrc/devel/py-subvertpy/work.quad/subvertpy-0.8.2/subvertpy/wc.h there are two #prama lines.  Remove those two #pragma lines, and subvertypy builds and links fine.  Unsure if this is the right fix.


>Release-Note:

>Audit-Trail:
From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45649: devel/py-subvertpy fails to build
Date: Thu, 24 Nov 2011 21:22:47 +0100

 On Thu, Nov 24, 2011 at 07:55:00PM +0000, oster@netbsd.org wrote:
 > ld: build/temp.netbsd-5.1_STABLE-amd64-2.6/subvertpy/client.o: relocation R_X86_64_PC32 against `py_wc_notify_func' can not be used when making a shared object; recompile with -fPIC

 What do you get for readelf -s on wc.c? The symbol should be hidden...

 Joerg

From: Greg Oster <oster@cs.usask.ca>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45649: devel/py-subvertpy fails to build
Date: Thu, 24 Nov 2011 14:36:45 -0600

 On Thu, 24 Nov 2011 20:25:02 +0000 (UTC)
 Joerg Sonnenberger <joerg@britannica.bec.de> wrote:

 > The following reply was made to PR pkg/45649; it has been noted by
 > GNATS.
 > 
 > From: Joerg Sonnenberger <joerg@britannica.bec.de>
 > To: gnats-bugs@NetBSD.org
 > Cc: 
 > Subject: Re: pkg/45649: devel/py-subvertpy fails to build
 > Date: Thu, 24 Nov 2011 21:22:47 +0100
 > 
 >  On Thu, Nov 24, 2011 at 07:55:00PM +0000, oster@netbsd.org wrote:
 >  > ld: build/temp.netbsd-5.1_STABLE-amd64-2.6/subvertpy/client.o:
 >  > relocation R_X86_64_PC32 against `py_wc_notify_func' can not be
 >  > used when making a shared object; recompile with -fPIC
 >  
 >  What do you get for readelf -s on wc.c? The symbol should be
 > hidden... 

 I'm guessing you mean 'readelf -s wc.o', not 'readelf -s wc.c'.  What I
 get looks like:

 Symbol table '.symtab' contains 327 entries:
    Num:    Value          Size Type    Bind   Vis      Ndx Name
      0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT  UND 
      1: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS wc.c
      2: 0000000000000000     0 SECTION LOCAL  DEFAULT    1 
      3: 0000000000000000     0 SECTION LOCAL  DEFAULT    3 
      4: 0000000000000000     0 SECTION LOCAL  DEFAULT    4 
      5: 0000000000000000     0 SECTION LOCAL  DEFAULT    5 
      6: 0000000000000000     0 SECTION LOCAL  DEFAULT    6 
 ...
    235: 0000000000004870   132 FUNC    GLOBAL DEFAULT    1
    py_wc_notify_func
 ...
    325: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  UND
 PyErr_NewSubversionExcept 
    326: 0000000000004900   248 FUNC    GLOBAL
 DEFAULT    1 py_wc_handle_error

 (some wrapping has occurred).

 Later...

 Greg Oster

From: Greg Oster <oster@cs.usask.ca>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45649: devel/py-subvertpy fails to build
Date: Thu, 24 Nov 2011 15:40:09 -0600

 On Thu, 24 Nov 2011 19:55:00 +0000 (UTC)
 oster@netbsd.org wrote:

 > >Fix:
 > 	In /usr/pkgsrc/devel/py-subvertpy/work.quad/subvertpy-0.8.2/subvertpy/wc.h
 > there are two #prama lines.  Remove those two #pragma lines, and
 > subvertypy builds and links fine.  Unsure if this is the right fix.

 As joerg@ pointed out, adding:

   #include "wc.h"

 to wc.c fixes this.

 Later...

 Greg Oster

State-Changed-From-To: open->feedback
State-Changed-By: cheusov@NetBSD.org
State-Changed-When: Thu, 24 Nov 2011 22:45:11 +0000
State-Changed-Why:
A fix was commited. Please confirm it solves the problem.


Responsible-Changed-From-To: pkg-manager->ddeus.pkgsrc@mailnull.com
Responsible-Changed-By: cheusov@NetBSD.org
Responsible-Changed-When: Thu, 24 Nov 2011 22:47:13 +0000
Responsible-Changed-Why:
Oleksander, please confirm wip/bzr-svr works fine with patch packages
If it does, notify upstream about fix.


From: "Aleksey Cheusov" <cheusov@netbsd.org>
To: gnats-bugs@gnats.NetBSD.org
Cc: 
Subject: PR/45649 CVS commit: pkgsrc/devel/py-subvertpy
Date: Thu, 24 Nov 2011 22:32:01 +0000

 Module Name:	pkgsrc
 Committed By:	cheusov
 Date:		Thu Nov 24 22:32:01 UTC 2011

 Modified Files:
 	pkgsrc/devel/py-subvertpy: distinfo
 Added Files:
 	pkgsrc/devel/py-subvertpy/patches: patch-subvertpy_wc.c

 Log Message:
 Attempt to fix PR 45649 by Greg Oster.
 Fix was proposed by joerg@


 To generate a diff of this commit:
 cvs rdiff -u -r1.4 -r1.5 pkgsrc/devel/py-subvertpy/distinfo
 cvs rdiff -u -r0 -r1.1 pkgsrc/devel/py-subvertpy/patches/patch-subvertpy_wc.c

 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.

From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/45649 CVS commit: pkgsrc/devel/py-subvertpy
Date: Fri, 25 Nov 2011 00:04:50 +0100

 On Thu, Nov 24, 2011 at 10:50:08PM +0000, Aleksey Cheusov wrote:
 > The following reply was made to PR pkg/45649; it has been noted by GNATS.
 > 
 > From: "Aleksey Cheusov" <cheusov@netbsd.org>
 > To: gnats-bugs@gnats.NetBSD.org
 > Cc: 
 > Subject: PR/45649 CVS commit: pkgsrc/devel/py-subvertpy
 > Date: Thu, 24 Nov 2011 22:32:01 +0000
 > 
 >  Module Name:	pkgsrc
 >  Committed By:	cheusov
 >  Date:		Thu Nov 24 22:32:01 UTC 2011
 >  
 >  Modified Files:
 >  	pkgsrc/devel/py-subvertpy: distinfo
 >  Added Files:
 >  	pkgsrc/devel/py-subvertpy/patches: patch-subvertpy_wc.c
 >  
 >  Log Message:
 >  Attempt to fix PR 45649 by Greg Oster.
 >  Fix was proposed by joerg@

 Please check if this applies to the branch too.

 Joerg

From: Greg Oster <oster@cs.usask.ca>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: pkg/45649 (devel/py-subvertpy fails to build on NetBSD
 5.1/amd64)
Date: Thu, 24 Nov 2011 20:01:36 -0600

 On Thu, 24 Nov 2011 22:45:12 +0000 (UTC)
 cheusov@NetBSD.org wrote:

 > Synopsis: devel/py-subvertpy fails to build on NetBSD 5.1/amd64
 > 
 > State-Changed-From-To: open->feedback
 > State-Changed-By: cheusov@NetBSD.org
 > State-Changed-When: Thu, 24 Nov 2011 22:45:11 +0000
 > State-Changed-Why:
 > A fix was commited. Please confirm it solves the problem.

 It certainly solves the problem in -current pkgsrc.  Not closing this,
 pending someone else to check for the issue on the branch and doing
 pullups.

 Thanks (to all) for the quick fix!

 Later...

 Greg Oster

Responsible-Changed-From-To: ddeus.pkgsrc@mailnull.com->cheusov
Responsible-Changed-By: cheusov@NetBSD.org
Responsible-Changed-When: Fri, 25 Nov 2011 10:00:57 +0000
Responsible-Changed-Why:
Reassign to me, as maintainer is not a developer (note by wiz@)


From: David Holland <dholland-pbugs@netbsd.org>
To: gnats-bugs@NetBSD.org
Cc: 
Subject: Re: PR/45649 CVS commit: pkgsrc/devel/py-subvertpy
Date: Sun, 27 Nov 2011 03:54:17 +0000

 On Thu, Nov 24, 2011 at 11:10:06PM +0000, Joerg Sonnenberger wrote:
  >  >  Log Message:
  >  >  Attempt to fix PR 45649 by Greg Oster.
  >  >  Fix was proposed by joerg@
  >  
  >  Please check if this applies to the branch too.

 Yes it does, it's been broken for a while.

 -- 
 David A. Holland
 dholland@netbsd.org

State-Changed-From-To: feedback->closed
State-Changed-By: dholland@NetBSD.org
State-Changed-When: Mon, 23 Jan 2012 00:59:10 +0000
State-Changed-Why:
we have a new stable branch now; the fix is in 2011Q4 so there's no need
for further action.


>Unformatted:
  Sources from Nov 20, 2011

Home	PR Database Search